FreshRSS (Customized)/app/Models/UserConfiguration.php, branch 1.22.0

PHPStan Level 7 for FreshRSS_UserQuery (#5319)

2023-04-20T07:14:58+00:00

Follow-up of https://github.com/FreshRSS/FreshRSS/pull/5318

PHPStan 7 configureController (#5318)

2023-04-19T22:55:10+00:00

And fix bugs for saving user queries

Remove ConfigurationSetter (#5251)

2023-04-07T10:40:43+00:00

This class has not been maintained for a while. Only a subset of our configuration properties are there, and some code is not relevant anymore. Furthermore, it is relying exclusively on dynamically invoked functions, making it challenging to maintain, in particular to find out what is used and what is not, what is handled and what is not. It is not well suited for changes in data formats, which have been handled in the Context class instead. It is also not able to handle configuration properties that are missing. It is the class with most errors for PHPStan level 6 (179 errors). It is also making intense use of is_callable and call_user_func_array, which are performance killers. Should the need arrise again to perform validation of our internal configuration files, I suggest an implementation with the opposite approach, namely driven by our code instead of driven by the data. In summary, at the moment, this class is costly, while not offering many guarantees.

Phpstan Level6 for View.php (#5269)

2023-04-07T10:32:10+00:00

* Remarque's from Alkarex * indentation * indentation * Apply suggestions from code review Co-authored-by: Alexandre Alapetite * Remarque's from Alkarex * A few improvements * Remarque's from Alkarex * Remarque's from Alkarex * Remarque's from Alkarex * Remarque's from Alkarex * Fixes and improvments * Fix getTagsForEntry --------- Co-authored-by: Luc Co-authored-by: Alexandre Alapetite

Use typed access to request parameters (#5267)

2023-04-06T22:13:49+00:00

* Use typed access to request parameters This was a big source of mixed datatypes in many places * Fix notifications * Fix bookmarkAction

Automated test towards PHPStan level 6 (#5230)

2023-03-26T21:19:41+00:00

* Automated test towards PHPStan level 6 Contributes to https://github.com/FreshRSS/FreshRSS/issues/4112 With this automated tests, files that are passing Level 6 are tested to avoid regressions towards Level 5 (which is the current baseline for the whole code-base) It is included when calling `make test-all` or can be called specifically by `composer run-script phpstan-next` * Test and example with 3 new passing files

feat: create config to display website icon only / name only / icon and name / none on feeds (#4969)

2023-03-04T13:51:07+00:00

* feat: create config to display website icon only / name only / icon and name / none on feeds * fix title hovering * reverted: column in .phtml * Update app/i18n/fr/conf.php --------- Co-authored-by: mathContao Co-authored-by: Alexandre Alapetite

Added: Dark mode for Origine +Origine compact themes (#4843)

2023-01-09T09:40:38+00:00

* first draft * fix: theme slider: properties box * improved colors * option to enable/disable dark mode * fixes * Update app/i18n/fr/conf.php Co-authored-by: Alexandre Alapetite * i18n english improved * fix dark background color for favorites + hover colors * select list: no, auto Co-authored-by: Alexandre Alapetite

User-defined time zone (#4906)

2022-11-29T14:27:32+00:00

* User-defined time zone #fix https://github.com/FreshRSS/FreshRSS/issues/2754 * Update app/i18n/nl/conf.php Co-authored-by: Frans de Jonge * Timezone when creating a new user Co-authored-by: Frans de Jonge

Fix type hints regressions (#4855)

2022-11-15T14:42:26+00:00

Fix regressions from https://github.com/FreshRSS/FreshRSS/pull/4561 Example: ``` PHP Fatal error: Uncaught TypeError: Argument 1 passed to checkToken() must be an instance of FreshRSS_UserConfiguration, instance of Minz_Configuration given, called in /var/www/FreshRSS/p/api/greader.php on line 1091 and defined in /var/www/FreshRSS/p/api/greader.php:223 Stack trace: #0 /var/www/FreshRSS/p/api/greader.php(1091): checkToken() #1 {main} thrown in /var/www/FreshRSS/p/api/greader.php on line 223 ``` Improvement of https://github.com/FreshRSS/FreshRSS/pull/4110