Customized version of FreshRSS, a self-hosted RSS feed aggregator https://git.rdnlsmith.com/fresh-rss-custom/atom?h=1.19.2 2022-01-08T20:58:55+00:00 2022-01-08T20:58:55+00:00 Alexandre Alapetite alexandre@alapetite.fr 2022-01-08T20:58:55+00:00 urn:sha1:1acd3ab09be1b65bfd6122ee351490c3b5527bb8 * Use typographic quotes * A few fixes * Fix * Fix not saved * Implement feedback * Detail * Revert spoken English fixes Left for a future dedicated discussion * More reverts * Final reverts * Final minor 2022-01-08T15:25:17+00:00 Thomas Renes thomas@renesweb.nl 2022-01-08T15:25:17+00:00 urn:sha1:916df412f5b6f7fb9bcfb705a3c8c23e35304410 2022-01-04T12:59:09+00:00 Alexandre Alapetite alexandre@alapetite.fr 2022-01-04T12:59:09+00:00 urn:sha1:1335a0e3cf11a0d4248e9eaaf748b89e6df741ef * Fix most PHPDocs errors Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 https://phpstan.org/writing-php-code/phpdoc-types * Avoid func_get_args Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list And avoid dynamic functions names when possible to more easily identify calls and unused functions. Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 * PHPStan level 3 * PHPStand level 4 * Update default to PHPStan level 4 * Towards level 5 * Fix level 4 regression * Towards level 5 * Pass PHPStan level 5 * Towards level 6 * Remove erronenous regression from changelog https://github.com/FreshRSS/FreshRSS/pull/4116 2021-12-31T16:00:51+00:00 Alexandre Alapetite alexandre@alapetite.fr 2021-12-31T16:00:51+00:00 urn:sha1:77e9877316fcfacb26799afdf32d94c8411da80e * Add PHPStan #fix https://github.com/FreshRSS/FreshRSS/issues/4016 https://phpstan.org/ ```sh composer run-script phpstan ``` * More fixes * Fix global variables * Add .phtml * Fix merge https://github.com/FreshRSS/FreshRSS/pull/4090 * Fix more warnings * Fix view errors and enable in CI * ReturnTypeWillChange * Dynamic view type * Fix Minz static/self bug 2021-10-14T11:32:58+00:00 Luc SANCHEZ 4697568+ColonelMoutarde@users.noreply.github.com 2021-10-14T11:32:58+00:00 urn:sha1:7b15ffc838bcd63cc0716eccd2e39fdd0665d76d Variable is more explicite now $ok to $isOkStatus 2021-03-24T18:04:51+00:00 Alexandre Alapetite alexandre@alapetite.fr 2021-03-24T18:04:51+00:00 urn:sha1:de40f3ad56b99b6128e8d9d207f5c5304ae97393 2021-02-06T11:43:30+00:00 Alexandre Alapetite alexandre@alapetite.fr 2021-02-06T11:43:30+00:00 urn:sha1:4a87f34bcff6afe28e33692e40dcbfb1f663f75a #fix https://github.com/FreshRSS/FreshRSS/issues/3421 2020-06-13T17:36:24+00:00 Marien Fressinaud dev@marienfressinaud.fr 2020-06-13T17:36:24+00:00 urn:sha1:15505a03779326f9497644e9827477cdcc26c2d2 Even if the issue #3035 seemed pretty simple at a first glance, it was more complicated than I expected. Because we send CSP headers AFTER running the controller actions, it means we can't "echo" any content from the controller. It's in fact a good practice, but it was easier at the time we developed the feature. To fix that, the only thing I had to do was to move the `print()` and `readfile()` function into the view. The problem was that we needed to output the content from the CLI too. Then, things became more complicated. I decided to extract the export-related methods in a `FreshRSS_Export_Service` class, in order to use it from both the controller and the CLI. It was an opportunity to refactor the whole feature in order to make it a bit more linear and easy to read. Reference: https://github.com/FreshRSS/FreshRSS/issues/3035