Customized version of FreshRSS, a self-hosted RSS feed aggregator https://git.rdnlsmith.com/fresh-rss-custom/atom?h=1.24.1 2024-02-28T12:23:28+00:00 2024-02-28T12:23:28+00:00 Kasimir Cash kasimir.cash@outlook.com 2024-02-28T12:23:28+00:00 urn:sha1:4b29e666b06762b4b36438c9370c38bc43121f78 * Adds logic for validation * Adds validation to do-install * Adds help to do-install * Adds validation & help to reconfigure * Adds validation to check.translation * Adds validation to manipulate.translation * Small fixes to help texts * Refactors language option validation * Adds default options to validation * Fixes validation with regex * Refactors readAs functions * Updates to new regex validation format * Fixes typing around default values * Adds file extension validation * Restandardises validation & parsing typing around array of strings * Adds NotOneOf validation * Adds ArrayOfString read as * Refactors existing validation * Adds validation throughout cli * Removes unused file * Adds new CL parser with goal of wrapping CLI behaviour * Hides parsing and validation * Rewites CL parser to make better use of classes * Rolls out new parser across CL * Fixes error during unknown option check * Fixes misnamed property calls * Seperates validations into more appropriate locations * Adds common boolean forms to validation * Moves CommandLineParser and Option classes into their own files * Fixes error when validating Int type * Rewrites appendTypedValues -> appendTypedValidValues now filters invalid values from output * Renames -> for clarity * Adds some docs clarifying option defaults and value taking behaviour * Refactors getUsageMessage for readability * Minor formatting changes * Adds tests for CommandLineParser * Adds more tests * Adds minor fixs * Reconfigure now correctly updates config * More fixes to reconfigure * Fixes required files for CommandLineParserTest * Use .php extension for PHP file * PHPStan ignore instead of wrong typing * Refactors to support php 7.4 * Moves away from dynamic properties by adding 'Definintions' to all commands * Renames target to definition for clarity * Stops null from being returned as a valid value in a certain edge case * Adds PHPStan ignore instead of incorrect typing * Refactors tests to take account of new typing solution * Marks file as executable * Draft CLI rework * Finish rewrite as object-oriented * Fix PHPStan ignore and make more strongly typed * Rename class Option to CliOption * Light renaming + anonymous classes --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> 2024-01-17T07:42:43+00:00 Kasimir Cash kasimir.cash@outlook.com 2024-01-17T07:42:43+00:00 urn:sha1:6d14813840d163c76f6dc25395b0007a88b42e9d * Separates long & short options for parsing * Adds parsing for short options + doc rewrites * Fixes undefined constant in check.translation * Standardises CL option parsing * Refactors option parsing * Renames getLongOptions -> getOptions * Removes unused code * Converges on string typing for options * Updates docs & help files * Updates array syntax array( ) -> [ ] 2024-01-09T22:01:17+00:00 Kasimir Cash kasimir.cash@outlook.com 2024-01-09T22:01:17+00:00 urn:sha1:9a80dde238caf1338b803f67003cd459393efdc3 * Updates do-install params * Adds parseCliParams to _cli.php * Updates do-install to use parseCliParams * Updates reconfigure to use parseCliParams * Fixes bug mail_login => email * Update create-user to use parseCliParams * Minor refactor * Updates update-user to use parseCliParams * Fix no_default_feeds => no-default-feeds * Refactors arrays * Updates CLI Readme * Adds docblocks to _cli functions * Sets vars in _cli functions * Fixes indentation * Meeting coding standards around colons * Meeting PHPStan standards * Removes stray whitespace * Meeting PHPStan Next Level standards * More specific typing * Maintaining types * Typing around getopt() * Fixes typo * Fixes typo perameters -> parameters * Removes unused variable * Rewrites deprecation warning message 2023-12-18T16:59:16+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-12-18T16:59:16+00:00 urn:sha1:a80a5f48a16e7d232168a7aaa68e9a1804235ce1 * Pass PHPStan level 8 And prepare for PHPStan level 9 https://phpstan.org/user-guide/rule-levels * Revert wrong replace in comment * Fix PHPStan level 8 * Update PHPStan and other dev dependencies * Remove obsolete comment * noVariableVariables and towards bleedingEdge https://github.com/phpstan/phpstan-strict-rules https://phpstan.org/blog/what-is-bleeding-edge * More bleedingEdge * A bit more PHPStan level 9 * More PHPStan level 9 * Prepare for booleansInConditions Ignore int and null * Revert wrong line * More fixes * Fix keep_max_n_unread * Stricter attribute functions * Stricter callHooks and more PHPStan level 9 * More typing * A tiny more 2023-11-16T21:43:00+00:00 Luc SANCHEZ 4697568+ColonelMoutarde@users.noreply.github.com 2023-11-16T21:43:00+00:00 urn:sha1:30c7a61a9b410f023c56ef19b9389a61647d8768 * Little's optimisations and booleans in conditions * Apply strict type * Apply strict type * Apply strict type * Fix multiple bugs with PHP 8.2 and 8.3 * Many declares missing, more errors fixed * Apply strict type * Another approach * Stronger typing for Minz_Session * Fix case of SQLite --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> 2023-05-11T11:02:04+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-05-11T11:02:04+00:00 urn:sha1:6e2f2f1c1e98ecd86aa89c6547beb742d7385d18 A subset of https://github.com/phpstan/phpstan-strict-rules 2023-04-17T06:30:21+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-04-17T06:30:21+00:00 urn:sha1:f3760f138dcbaf7a2190336a0378cf1b2190c9f5 * Complete PHPStan Level 6 Fix https://github.com/FreshRSS/FreshRSS/issues/4112 And initiate PHPStan Level 7 * PHPStan Level 6 for tests * Use phpstan/phpstan-phpunit * Update to PHPStan version 1.10 * Fix mixed bug * Fix mixed return bug * Fix paginator bug * Fix FreshRSS_UserConfiguration * A couple more Minz_Configuration bug fixes * A few trivial PHPStan Level 7 fixes * A few more simple PHPStan Level 7 * More files passing PHPStan Level 7 Add interface to replace removed class from https://github.com/FreshRSS/FreshRSS/pull/5251 * A few more PHPStan Level 7 preparations * A few last details 2023-04-05T14:19:14+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-04-05T14:19:14+00:00 urn:sha1:3f1695db039101d44d611f0d1781d1ba034034dd * PHPStan 6 for CLI Except `./cli/i18n/` * Bool * One type forgotten 2023-04-04T08:23:26+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-04-04T08:23:26+00:00 urn:sha1:36aa0122e15b6c5a4bf923467b63a577cac5a539 * Fix extension freshrss_user_maintenance in actualize_script Follow-up of https://github.com/FreshRSS/FreshRSS/pull/3440 The hook was called before registering all the extensions for the current user * PHPStan Level 6 for extensions And remove 5-year old legacy format of enabled extensions < FreshRSS 1.11.1 * Fix multiple bugs in extensions * Minor typing * Don't change signature of methods supposed to be overridden * PHPStan Level 9 and compatibility Intelliphense * Set as final the methods not supposed to be overriden 2023-02-06T14:42:53+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-02-06T14:42:53+00:00 urn:sha1:e899e4edd97c296a29b2a8da2c2e3b598622c36e * More robust application of access permissions We were in particular missing directory traversal `+X` in our current recommendations. Extracted to own shell script so it can easily be invoked. Update access permissions in Docker to account to be more robust. #fix https://github.com/FreshRSS/FreshRSS/discussions/5037 * Minor simplification * Restrict mkdir permissions Default mkdir permissions are 0777, which is not good for security, so downgrade to 0770.