Customized version of FreshRSS, a self-hosted RSS feed aggregator https://git.rdnlsmith.com/fresh-rss-custom/atom?h=1.24.1 2024-05-15T06:57:58+00:00 2024-05-15T06:57:58+00:00 Alexandre Alapetite alexandre@alapetite.fr 2024-05-15T06:57:58+00:00 urn:sha1:2d17c020b6695d47debda065804db4e2d2f92e55 * PHPStan 1.11 + minor update dev dependencies https://github.com/phpstan/phpstan/releases/tag/1.11.0 * Comment style 2024-01-15T09:36:30+00:00 Alexandre Alapetite alexandre@alapetite.fr 2024-01-15T09:36:30+00:00 urn:sha1:314077a457f04cc2f0472e036af029e2676fbf02 Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. 2023-12-18T16:59:16+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-12-18T16:59:16+00:00 urn:sha1:a80a5f48a16e7d232168a7aaa68e9a1804235ce1 * Pass PHPStan level 8 And prepare for PHPStan level 9 https://phpstan.org/user-guide/rule-levels * Revert wrong replace in comment * Fix PHPStan level 8 * Update PHPStan and other dev dependencies * Remove obsolete comment * noVariableVariables and towards bleedingEdge https://github.com/phpstan/phpstan-strict-rules https://phpstan.org/blog/what-is-bleeding-edge * More bleedingEdge * A bit more PHPStan level 9 * More PHPStan level 9 * Prepare for booleansInConditions Ignore int and null * Revert wrong line * More fixes * Fix keep_max_n_unread * Stricter attribute functions * Stricter callHooks and more PHPStan level 9 * More typing * A tiny more 2023-11-16T21:43:00+00:00 Luc SANCHEZ 4697568+ColonelMoutarde@users.noreply.github.com 2023-11-16T21:43:00+00:00 urn:sha1:30c7a61a9b410f023c56ef19b9389a61647d8768 * Little's optimisations and booleans in conditions * Apply strict type * Apply strict type * Apply strict type * Fix multiple bugs with PHP 8.2 and 8.3 * Many declares missing, more errors fixed * Apply strict type * Another approach * Stronger typing for Minz_Session * Fix case of SQLite --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> 2023-10-30T19:47:27+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-10-30T19:47:27+00:00 urn:sha1:06d00995049db9c7b915f67cfd4a5708aace458f * Require PHP 7.4+ https://github.com/FreshRSS/FreshRSS/discussions/5474 * Update Docker oldest Alpine 3.13 with PHP 7.4.26 * Add missing packets to Docker oldest * Update to typed properties https://php.net/migration74.new-features#migration74.new-features.core.typed-properties * More types 2023-09-13T20:58:10+00:00 Sam Cohen samc1213@gmail.com 2023-09-13T20:58:10+00:00 urn:sha1:52d87c3eaa352b765e1be3c2c0b9a3ce0bfabdc8 * Allow configuration of Base URL via website * Fix alphabetization of CREDITS * Apply suggestions from code review * Add Automatic recommendation --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> 2023-05-22T18:55:59+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-05-22T18:55:59+00:00 urn:sha1:445cc23abdda5767b622d70cf7b5eb5310dcf908 * PHPStan Level 7 complete * Start PHPStan Level 8 * Forgot exclude .phtml 2023-04-28T12:01:11+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-04-28T12:01:11+00:00 urn:sha1:c72914bba2363e436574204b3d6093a6f3cfce89 * PHPStan Level 7 for more DAO PDO With new function to address common type and check problems * A bit more * PHPStan Level 7 for FreshRSS_Entry 2023-04-17T06:30:21+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-04-17T06:30:21+00:00 urn:sha1:f3760f138dcbaf7a2190336a0378cf1b2190c9f5 * Complete PHPStan Level 6 Fix https://github.com/FreshRSS/FreshRSS/issues/4112 And initiate PHPStan Level 7 * PHPStan Level 6 for tests * Use phpstan/phpstan-phpunit * Update to PHPStan version 1.10 * Fix mixed bug * Fix mixed return bug * Fix paginator bug * Fix FreshRSS_UserConfiguration * A couple more Minz_Configuration bug fixes * A few trivial PHPStan Level 7 fixes * A few more simple PHPStan Level 7 * More files passing PHPStan Level 7 Add interface to replace removed class from https://github.com/FreshRSS/FreshRSS/pull/5251 * A few more PHPStan Level 7 preparations * A few last details 2023-04-07T10:40:43+00:00 Alexandre Alapetite alexandre@alapetite.fr 2023-04-07T10:40:43+00:00 urn:sha1:dbbae15a8458679db0f4540dacdbdcff9c02ec8c This class has not been maintained for a while. Only a subset of our configuration properties are there, and some code is not relevant anymore. Furthermore, it is relying exclusively on dynamically invoked functions, making it challenging to maintain, in particular to find out what is used and what is not, what is handled and what is not. It is not well suited for changes in data formats, which have been handled in the Context class instead. It is also not able to handle configuration properties that are missing. It is the class with most errors for PHPStan level 6 (179 errors). It is also making intense use of is_callable and call_user_func_array, which are performance killers. Should the need arrise again to perform validation of our internal configuration files, I suggest an implementation with the opposite approach, namely driven by our code instead of driven by the data. In summary, at the moment, this class is costly, while not offering many guarantees.