Customized version of FreshRSS, a self-hosted RSS feed aggregator https://git.rdnlsmith.com/fresh-rss-custom/atom?h=1.19.0 2020-12-28T23:11:34+00:00 2020-12-28T23:11:34+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2020-12-28T23:11:34+00:00 urn:sha1:3f4c86f80f7cf7fd0ba9260d46eafc55d46fe9af Before, we had 5 classes in the ModelPdo file. It was bad for 2 reasons. The first reason is that it is considered bad practice to have multiple class in one file. This is especially true when using autoloading. On top of that it is less readable considering the size of the file. The second reason is that so far we were lucky. Everytime we needed to access the database, it was through the ModelPdo class which loads all the other classes. If we want to access directly the connection, it wont be loaded. On top of that, the system is configured to work on a single database, but as we have every connection definition in a single file, all classes were loaded at the same time. Thus using memory and processing time for nothing. Now, we have a file for each class. To work with autoloading, classes were slightly renamed to match autoloading rules. 2020-12-28T18:53:55+00:00 Alexandre Alapetite alexandre@alapetite.fr 2020-12-28T18:53:55+00:00 urn:sha1:0a2d9b3b54ee51a3965d79c68409ef045ad5834b This reverts commit e1ee58816ba76734e4115fc12898b13de665b220. 2020-12-28T15:44:08+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2020-12-28T15:44:08+00:00 urn:sha1:e1ee58816ba76734e4115fc12898b13de665b220 Before, we had 5 classes in the ModelPdo file. It was bad for 2 reasons. The first reason is that it is considered bad practice to have multiple class in one file. This is especially true when using autoloading. On top of that it is less readable considering the size of the file. The second reason is that so far we were lucky. Everytime we needed to access the database, it was through the ModelPdo class which loads all the other classes. If we want to access directly the connection, it wont be loaded. On top of that, the system is configured to work on a single database, but as we have every connection definition in a single file, all classes were loaded at the same time. Thus using memory and processing time for nothing. Now, we have a file for each class. To work with autoloading, classes were slightly renamed to match autoloading rules.