Customized version of FreshRSS, a self-hosted RSS feed aggregator https://git.rdnlsmith.com/fresh-rss-custom/atom?h=1.20.0 2022-01-07T09:05:09+00:00 2022-01-07T09:05:09+00:00 Luc SANCHEZ 4697568+ColonelMoutarde@users.noreply.github.com 2022-01-07T09:05:09+00:00 urn:sha1:ed19445f74c30854c60873cd1df1c38e15fc316b * - Fix typo, - remove unnecessary null in property, - remove unused property, - add phpDoc, - add ext PDO in composer.json, - use strict comparison, - indentation * Translate * Update lib/Minz/ModelPdo.php Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> * The code is more explicite * Fix phpstan * Fix phpstan expect one * Fix phpstan * Return in back... * make fix-all * Fix exception and more types * Fix more types * Remove ext- in composer.json Co-authored-by: Luc SANCHEZ <l.sanchez-ext@ubitransport.com> Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> 2021-12-31T16:00:51+00:00 Alexandre Alapetite alexandre@alapetite.fr 2021-12-31T16:00:51+00:00 urn:sha1:77e9877316fcfacb26799afdf32d94c8411da80e * Add PHPStan #fix https://github.com/FreshRSS/FreshRSS/issues/4016 https://phpstan.org/ ```sh composer run-script phpstan ``` * More fixes * Fix global variables * Add .phtml * Fix merge https://github.com/FreshRSS/FreshRSS/pull/4090 * Fix more warnings * Fix view errors and enable in CI * ReturnTypeWillChange * Dynamic view type * Fix Minz static/self bug 2020-12-28T23:11:34+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2020-12-28T23:11:34+00:00 urn:sha1:3f4c86f80f7cf7fd0ba9260d46eafc55d46fe9af Before, we had 5 classes in the ModelPdo file. It was bad for 2 reasons. The first reason is that it is considered bad practice to have multiple class in one file. This is especially true when using autoloading. On top of that it is less readable considering the size of the file. The second reason is that so far we were lucky. Everytime we needed to access the database, it was through the ModelPdo class which loads all the other classes. If we want to access directly the connection, it wont be loaded. On top of that, the system is configured to work on a single database, but as we have every connection definition in a single file, all classes were loaded at the same time. Thus using memory and processing time for nothing. Now, we have a file for each class. To work with autoloading, classes were slightly renamed to match autoloading rules. 2020-12-28T18:53:55+00:00 Alexandre Alapetite alexandre@alapetite.fr 2020-12-28T18:53:55+00:00 urn:sha1:0a2d9b3b54ee51a3965d79c68409ef045ad5834b This reverts commit e1ee58816ba76734e4115fc12898b13de665b220. 2020-12-28T15:44:08+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2020-12-28T15:44:08+00:00 urn:sha1:e1ee58816ba76734e4115fc12898b13de665b220 Before, we had 5 classes in the ModelPdo file. It was bad for 2 reasons. The first reason is that it is considered bad practice to have multiple class in one file. This is especially true when using autoloading. On top of that it is less readable considering the size of the file. The second reason is that so far we were lucky. Everytime we needed to access the database, it was through the ModelPdo class which loads all the other classes. If we want to access directly the connection, it wont be loaded. On top of that, the system is configured to work on a single database, but as we have every connection definition in a single file, all classes were loaded at the same time. Thus using memory and processing time for nothing. Now, we have a file for each class. To work with autoloading, classes were slightly renamed to match autoloading rules.