Customized version of FreshRSS, a self-hosted RSS feed aggregator https://git.rdnlsmith.com/fresh-rss-custom/atom?h=1.19.0 2021-12-02T22:25:07+00:00 2021-12-02T22:25:07+00:00 Alexandre Alapetite alexandre@alapetite.fr 2021-12-02T22:25:07+00:00 urn:sha1:a2ab9cf83aaead96497a70a1430ce0424c0d8316 Take advantage of PHP7+ null-coalescing operator `??` to make code more standard, shorter, and faster instead of custom function with no extra functionality. Allows code to be better tested and fix two PHPstan errors: ``` ------ ----------------------------------------- Line app/Controllers/configureController.php ------ ----------------------------------------- 410 Cannot unset offset 'rid' on string. ------ ----------------------------------------- ------ ------------------------------------ Line lib/Minz/FrontController.php ------ ------------------------------------ 70 Cannot unset offset 'c' on string. 71 Cannot unset offset 'a' on string. ------ ------------------------------------ ``` https://github.com/FreshRSS/FreshRSS/issues/4016 2021-12-01T22:24:39+00:00 Alexandre Alapetite alexandre@alapetite.fr 2021-12-01T22:24:39+00:00 urn:sha1:28cff8a0df3af23f7acf01840da43c098c779313 * Fix some PHP 8.1 warnings The proper fix will have to wait till be drop PHP7. #fix https://github.com/FreshRSS/FreshRSS/issues/4010 * Another PHP8.1 fix 2021-05-18T20:54:10+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2021-05-18T20:54:10+00:00 urn:sha1:235ff3863ddb359a7f0e9ec9402f8f49fecef074 2021-05-08T08:27:18+00:00 Alexandre Alapetite alexandre@alapetite.fr 2021-05-08T08:27:18+00:00 urn:sha1:607f7e725487ce0eb0339b288ce9e58036dad4a0 Mainly wrong `@return` types in comments 2021-01-02T23:59:57+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2021-01-02T23:59:57+00:00 urn:sha1:31cb07ac1acf7bad8c1bf6bbef45a17f4e0edbf3 Before, when clicking on the author link, the search was done on the main stream in the normal view. It's fine until the feed is not visible in the main stream. Now, the current context is used along with the search. See #3314 2020-10-06T21:19:45+00:00 Alexandre Alapetite alexandre@alapetite.fr 2020-10-06T21:19:45+00:00 urn:sha1:0319cc9d234e107109d988f36f2361b25f9f0777 * Minz allow parallel sessions #fix https://github.com/FreshRSS/FreshRSS/issues/3093 * Array optimisation * Array optimisation missing * Reduce direct access to $_SESSION except in install process * Fix session start headers warning * Use cookie only the first time the session is started: `PHP Warning: session_start(): Cannot start session when headers already sent in /var/www/FreshRSS/lib/Minz/Session.php on line 39` * New concept of volatile session for API calls Optimisation: do not use cookies or local storage at all for API calls without a Web session Fix warning: ``` PHP Warning: session_destroy(): Trying to destroy uninitialized session in Unknown on line 0 ``` * Only call Minz_Session::init once in our index It was called twice (once indirectly via FreshRSS->init()) * Whitespace * Mutex for notifications Implement mutex for notifications https://github.com/FreshRSS/FreshRSS/pull/3208#discussion_r499509809 * Typo * Install script is not ready for using Minz_Session 2020-10-05T17:03:33+00:00 Alexandre Alapetite alexandre@alapetite.fr 2020-10-05T17:03:33+00:00 urn:sha1:76523693592a58c7b15c2860ad95133f551d86a5 * Minz: Attach a notification to a request Notifications should be attached to a request, not to a global session. Fix https://github.com/FreshRSS/FreshRSS/pull/3096#issuecomment-654891906 Prepare https://github.com/FreshRSS/FreshRSS/pull/3096 * Rename array * Avoid string constants Implement https://github.com/FreshRSS/FreshRSS/pull/3208#issuecomment-703243863 * Improved logic * Simplify storage https://github.com/FreshRSS/FreshRSS/pull/3208#discussion_r499511213 * Fix notification bug in configuration/system 2020-06-05T08:10:46+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2020-06-05T08:10:46+00:00 urn:sha1:36bda2e715ed822cc495ff419ad565084e241f43 Before, when the user was not logged in, pages where translated with the '_' user language. Now, they are translated with the user preferred language if there is one supported by FreshRSS or with the system default language. 2020-01-04T22:35:42+00:00 Alexandre Alapetite alexandre@alapetite.fr 2020-01-04T22:35:42+00:00 urn:sha1:2aff347b2e942286292b21e0b20d93ab85220a17 * Fix wrong getHeader refactoring Fix regression introduced by https://github.com/FreshRSS/FreshRSS/pull/2373 The refactoring required a call to init() even for static functions, which is most of the time not done. Removed premature abstraction of `$_SERVER`, which was the root cause of the bug. https://github.com/FreshRSS/FreshRSS/issues/2748#issuecomment-569898931 * Refactoring: Move serverIsPublic to Minz_Request * Add mitigations for wrong configurations Due to the regression, we have some existing configurations with a bad base_url * Forgot one instance 2019-12-04T07:26:38+00:00 Alexis Degrugillier aledeg@users.noreply.github.com 2019-12-04T07:26:38+00:00 urn:sha1:de2b323847e0a91119625e4f506f51ec9d43872f I split the code into more manageable chunks to make it more readable. It's now easier to get a grasp on it. In the process, I tried to use the yoda style notation to avoid unintentional variable assignement. I also tried to exit early to avoid many "if" levels. I have also added a better way to handle headers and a way to extract languages from the request. It will be easier to choose which language to use for i18n.