summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Alexandre Alapetite <alexandre.alapetite@alexandra.dk> 2017-07-27 09:40:53 +0200
committerGravatar Alexandre Alapetite <alexandre.alapetite@alexandra.dk> 2017-07-27 09:40:53 +0200
commit03a99c2408ce5439c3a1402cf308eec557bfdaaf (patch)
tree7ca7fb0b6035d111430260b4219b17c69129dfb9
parent1138c8a63b1ff54eb96821d4f4ff829f5dc67a02 (diff)
parentda685f9390b8bfa1193c9d335d36f3648c17fe7e (diff)
Merge branch 'FreshRSS/dev' into cli_update_user
-rw-r--r--CHANGELOG.md3
-rw-r--r--app/install.php4
-rwxr-xr-xcli/create-user.php2
-rwxr-xr-xcli/do-install.php4
-rw-r--r--p/api/greader.php2
5 files changed, 9 insertions, 6 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index be38141d5..22c11be1e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,9 @@
* Korean [#1578](https://github.com/FreshRSS/FreshRSS/pull/1578)
* Bug fixing
* PHP 7.1 compatibility for the API [#1584](https://github.com/FreshRSS/FreshRSS/issues/1584), [#1594](https://github.com/FreshRSS/FreshRSS/pull/1594)
+ * Fix API compatibility bug between PostgreSQL and EasyRSS [#1603](https://github.com/FreshRSS/FreshRSS/pull/1603)
+* Misc.
+ * Allow longer database usernames [#1597](https://github.com/FreshRSS/FreshRSS/issues/1597)
## 2017-06-03 FreshRSS 1.7.0
diff --git a/app/install.php b/app/install.php
index 9e474ca73..cd276bb7b 100644
--- a/app/install.php
+++ b/app/install.php
@@ -124,7 +124,7 @@ function saveStep2() {
$_SESSION['title'] = $system_default_config->title;
$_SESSION['old_entries'] = param('old_entries', $user_default_config->old_entries);
$_SESSION['auth_type'] = param('auth_type', 'form');
- $_SESSION['default_user'] = substr(preg_replace('/[^a-zA-Z0-9]/', '', param('default_user', '')), 0, 16);
+ $_SESSION['default_user'] = substr(preg_replace('/[^0-9a-zA-Z_]/', '', param('default_user', '')), 0, 38);
$password_plain = param('passwordPlain', false);
if ($password_plain !== false && cryptAvailable()) {
@@ -631,7 +631,7 @@ function printStep3() {
<div class="form-group">
<label class="group-name" for="user"><?php echo _t('install.bdd.username'); ?></label>
<div class="group-controls">
- <input type="text" id="user" name="user" maxlength="16" pattern="[0-9A-Za-z_.-]{1,16}" value="<?php echo isset($_SESSION['bd_user']) ? $_SESSION['bd_user'] : ''; ?>" tabindex="3" />
+ <input type="text" id="user" name="user" maxlength="64" pattern="[0-9A-Za-z_.-]{1,64}" value="<?php echo isset($_SESSION['bd_user']) ? $_SESSION['bd_user'] : ''; ?>" tabindex="3" />
</div>
</div>
diff --git a/cli/create-user.php b/cli/create-user.php
index c3a45cad8..f710e8d66 100755
--- a/cli/create-user.php
+++ b/cli/create-user.php
@@ -18,7 +18,7 @@ if (empty($options['user'])) {
}
$username = $options['user'];
if (!FreshRSS_user_Controller::checkUsername($username)) {
- fail('FreshRSS error: invalid username “' . $username . '”');
+ fail('FreshRSS error: invalid username “' . $username . '”! Must be matching ' . FreshRSS_user_Controller::USERNAME_PATTERN);
}
$usernames = listUsers();
diff --git a/cli/do-install.php b/cli/do-install.php
index 143ca5c3e..54e3c3d4f 100755
--- a/cli/do-install.php
+++ b/cli/do-install.php
@@ -81,11 +81,11 @@ if ($requirements['all'] !== 'ok') {
}
if (!FreshRSS_user_Controller::checkUsername($options['default_user'])) {
- fail('FreshRSS invalid default username (must be ASCII alphanumeric): ' . $options['default_user']);
+ fail('FreshRSS error: invalid default username “' . $options['default_user'] . '”! Must be matching ' . FreshRSS_user_Controller::USERNAME_PATTERN);
}
if (isset($options['auth_type']) && !in_array($options['auth_type'], array('form', 'http_auth', 'none'))) {
- fail('FreshRSS invalid authentication method (auth_type must be one of { form, http_auth, none }: ' . $options['auth_type']);
+ fail('FreshRSS invalid authentication method (auth_type must be one of { form, http_auth, none }): ' . $options['auth_type']);
}
if (file_put_contents(join_path(DATA_PATH, 'config.php'), "<?php\n return " . var_export($config, true) . ";\n") === false) {
diff --git a/p/api/greader.php b/p/api/greader.php
index 6b9ea4526..7f6f0b04f 100644
--- a/p/api/greader.php
+++ b/p/api/greader.php
@@ -503,7 +503,7 @@ function streamContents($path, $include_target, $start_time, $count, $order, $ex
$item = array(
'id' => /*'tag:google.com,2005:reader/item/' .*/ dec2hex($entry->id()), //64-bit hexa http://code.google.com/p/google-reader-api/wiki/ItemId
'crawlTimeMsec' => substr($entry->id(), 0, -3),
- 'timestampUsec' => $entry->id(), //EasyRSS
+ 'timestampUsec' => '' . $entry->id(), //EasyRSS
'published' => $entry->date(true),
'title' => $entry->title(),
'summary' => array('content' => $entry->content()),