aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Alexandre Alapetite <alexandre@alapetite.fr> 2023-01-21 23:20:44 +0100
committerGravatar GitHub <noreply@github.com> 2023-01-21 23:20:44 +0100
commit1c434971d4148e752e749835bb9acdf252e8d501 (patch)
tree0dc79fd4f28283fea072243529908bbb1c20b0f0
parent2216940f008807f8335f66da18edbc5c32176e9f (diff)
statsController at phpStan level 9 (#5028)
Follow up of https://github.com/FreshRSS/FreshRSS/pull/5024 ``` vendor/bin/phpstan analyse --level 9 app/Controllers/statsController.php ``` Contributes to https://github.com/FreshRSS/FreshRSS/issues/4112
-rw-r--r--app/Controllers/statsController.php27
-rw-r--r--app/views/index/logs.phtml10
2 files changed, 8 insertions, 29 deletions
diff --git a/app/Controllers/statsController.php b/app/Controllers/statsController.php
index 0ab7df09b..16b09d702 100644
--- a/app/Controllers/statsController.php
+++ b/app/Controllers/statsController.php
@@ -32,27 +32,6 @@ class FreshRSS_stats_Controller extends FreshRSS_ActionController {
FreshRSS_View::prependTitle(_t('admin.stats.title') . ' ยท ');
}
- private function convertToSeries($data): array {
- $series = array();
-
- foreach ($data as $key => $value) {
- $series[] = array($key, $value);
- }
-
- return $series;
- }
-
- private function convertToPieSeries(array $data): array {
- $series = array();
-
- foreach ($data as $value) {
- $value['data'] = array(array(0, (int) $value['data']));
- $series[] = $value;
- }
-
- return $series;
- }
-
/**
* This action handles the statistic main page.
*
@@ -94,7 +73,7 @@ class FreshRSS_stats_Controller extends FreshRSS_ActionController {
$last30DaysLabels = [];
for ($i = 0; $i < 30; $i++) {
- $last30DaysLabels[$i] = date('d.m.Y', strtotime((-30 + $i) . ' days'));
+ $last30DaysLabels[$i] = date('d.m.Y', strtotime((-30 + $i) . ' days') ?: null);
}
$this->view->last30DaysLabels = $last30DaysLabels;
@@ -107,8 +86,8 @@ class FreshRSS_stats_Controller extends FreshRSS_ActionController {
* but shows the stats idle page
*/
public function feedAction(): void {
- $id = Minz_Request::param('id');
- $ajax = Minz_Request::param('ajax');
+ $id = '' . Minz_Request::param('id', '');
+ $ajax = '' . Minz_Request::param('ajax', '');
if ($ajax) {
$url_redirect = array('c' => 'subscription', 'a' => 'feed', 'params' => array('id' => $id, 'from' => 'stats', 'ajax' => $ajax));
} else {
diff --git a/app/views/index/logs.phtml b/app/views/index/logs.phtml
index f6a76b922..896a19765 100644
--- a/app/views/index/logs.phtml
+++ b/app/views/index/logs.phtml
@@ -6,7 +6,7 @@
</div>
<h1><?= _t('index.log') ?></h1>
-
+
<?php
/** @var array<FreshRSS_Log> $items */
@@ -29,8 +29,8 @@
<?= _i($log->level()) ?>
</td>
<td class="log-date">
- <time datetime="<?= @date('Y-m-d H:i:s', @strtotime($log->date())) ?>">
- <?= @date('Y-m-d H:i:s', @strtotime($log->date())) ?>
+ <time datetime="<?= date('Y-m-d H:i:s', @strtotime($log->date()) ?: 0) ?>">
+ <?= date('Y-m-d H:i:s', @strtotime($log->date()) ?: 0) ?>
</time>
</td>
<td class="log-message">
@@ -42,7 +42,7 @@
</table>
</div>
<?php $this->logsPaginator->render('logs_pagination.phtml', 'page'); ?>
-
+
<form method="post" action="<?= _url('index', 'logs') ?>">
@@ -58,5 +58,5 @@
<?php } else { ?>
<p class="alert alert-warn"><?= _t('index.log.empty') ?></p>
<?php } ?>
-
+
</main>