summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Michael Meier <mmeier1986@googlemail.com> 2026-01-03 18:43:15 +0100
committerGravatar GitHub <noreply@github.com> 2026-01-03 18:43:15 +0100
commitb07ec816b023c911f76c4149d00a2ffbdcab1d16 (patch)
tree0c1f2835fbe159280608dd0479fbedb7f3e71dc4
parent26c1102567c095b051b5e1a0aedb45b78713c283 (diff)
Switch to using CURLOPT_ACCEPT_ENCODING instead of the deprecated CURLOPT_ENCODING (#8376)
* Replace deprecated CURLOPT_ENCODING The CURLOPT_ENCODING setting has been deprecated in favor of CURLOPT_ACCEPT_ENCODING. Signed-off-by: Michael Meier <mmeier1986@gmail.com> * Sync with our SimplePie fork PR https://github.com/FreshRSS/simplepie/pull/67 https://github.com/simplepie/simplepie/pull/960 https://github.com/simplepie/simplepie/pull/962 * Our SimplePie PR merged --------- Signed-off-by: Michael Meier <mmeier1986@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
-rw-r--r--app/Models/Feed.php2
-rw-r--r--app/Utils/httpUtil.php2
-rwxr-xr-xcli/health.php2
-rw-r--r--lib/composer.json2
-rw-r--r--lib/simplepie/simplepie/src/File.php10
5 files changed, 12 insertions, 6 deletions
diff --git a/app/Models/Feed.php b/app/Models/Feed.php
index 19ff4fa81..511bdc54a 100644
--- a/app/Models/Feed.php
+++ b/app/Models/Feed.php
@@ -1415,7 +1415,7 @@ class FreshRSS_Feed extends Minz_Model {
CURLOPT_USERAGENT => FRESHRSS_USERAGENT,
CURLOPT_MAXREDIRS => 10,
CURLOPT_FOLLOWLOCATION => true,
- CURLOPT_ENCODING => '', //Enable all encodings
+ CURLOPT_ACCEPT_ENCODING => '', //Enable all encodings
//CURLOPT_VERBOSE => 1, // To debug sent HTTP headers
]);
$response = curl_exec($ch);
diff --git a/app/Utils/httpUtil.php b/app/Utils/httpUtil.php
index ba63f0dde..5b652b5f2 100644
--- a/app/Utils/httpUtil.php
+++ b/app/Utils/httpUtil.php
@@ -339,7 +339,7 @@ final class FreshRSS_http_Util {
CURLOPT_MAXREDIRS => 4,
CURLOPT_RETURNTRANSFER => true,
CURLOPT_FOLLOWLOCATION => true,
- CURLOPT_ENCODING => '', //Enable all encodings
+ CURLOPT_ACCEPT_ENCODING => '', //Enable all encodings
//CURLOPT_VERBOSE => 1, // To debug sent HTTP headers
]);
diff --git a/cli/health.php b/cli/health.php
index c6a9c38b7..2e0687f0c 100755
--- a/cli/health.php
+++ b/cli/health.php
@@ -17,7 +17,7 @@ if ($ch === false) {
curl_setopt_array($ch, [
CURLOPT_CONNECTTIMEOUT => is_numeric($options['connect_timeout'] ?? null) ? (int)$options['connect_timeout'] : 3,
CURLOPT_TIMEOUT => is_numeric($options['timeout'] ?? null) ? (int)$options['timeout'] : 5,
- CURLOPT_ENCODING => '', //Enable all encodings
+ CURLOPT_ACCEPT_ENCODING => '', //Enable all encodings
CURLOPT_HTTPHEADER => [
'Connection: close',
],
diff --git a/lib/composer.json b/lib/composer.json
index a68d768f2..727982e8b 100644
--- a/lib/composer.json
+++ b/lib/composer.json
@@ -14,7 +14,7 @@
"marienfressinaud/lib_opml": "0.5.1",
"phpgt/cssxpath": "v1.4.0",
"phpmailer/phpmailer": "7.0.1",
- "simplepie/simplepie": "dev-freshrss#e7b26b4f01d377dc8174d5d4aee961604534d065"
+ "simplepie/simplepie": "dev-freshrss#02d08ffe43b7e93239f90f7d700475891cefcef8"
},
"config": {
"sort-packages": true,
diff --git a/lib/simplepie/simplepie/src/File.php b/lib/simplepie/simplepie/src/File.php
index 0981ebf96..a5396e576 100644
--- a/lib/simplepie/simplepie/src/File.php
+++ b/lib/simplepie/simplepie/src/File.php
@@ -121,7 +121,9 @@ class File implements Response
}
unset($curl_options[CURLOPT_HTTPHEADER]);
}
- if (version_compare(\SimplePie\Misc::get_curl_version(), '7.10.5', '>=')) {
+ if (version_compare(\SimplePie\Misc::get_curl_version(), '7.21.6', '>=')) {
+ curl_setopt($fp, CURLOPT_ACCEPT_ENCODING, '');
+ } elseif (version_compare(\SimplePie\Misc::get_curl_version(), '7.10.5', '>=')) {
curl_setopt($fp, CURLOPT_ENCODING, '');
}
curl_setopt($fp, CURLOPT_URL, $url);
@@ -147,7 +149,11 @@ class File implements Response
$this->error = 'cURL error ' . curl_errno($fp) . ': ' . curl_error($fp); // FreshRSS
$this->on_http_response($responseBody === false ? false : $responseHeaders . $responseBody, $curl_options);
$this->error = null; // FreshRSS
- curl_setopt($fp, CURLOPT_ENCODING, 'none');
+ if (version_compare(\SimplePie\Misc::get_curl_version(), '7.21.6', '>=')) {
+ curl_setopt($fp, CURLOPT_ACCEPT_ENCODING, null);
+ } else {
+ curl_setopt($fp, CURLOPT_ENCODING, null);
+ }
$responseHeaders = '';
$responseBody = curl_exec($fp);
$responseHeaders .= "\r\n";