Use HTML5 hidden (#6910)

https://html.spec.whatwg.org/multipage/interaction.html#the-hidden-attribute
Remove remains of `aria-hidden` mostly not used anymore in our logic.
fix https://github.com/FreshRSS/FreshRSS/issues/6909

5 files changed, 5 insertions, 21 deletions

diff --git a/app/views/index/normal.phtml b/app/views/index/normal.phtml
index 816089eb2..e2c3c9c56 100644
--- a/app/views/index/normal.phtml
+++ b/app/views/index/normal.phtml
@@ -38,7 +38,7 @@ $today = @strtotime('today');
 
 <main id="stream" class="normal<?= FreshRSS_Context::userConf()->display_posts ? '' : ' hide_posts' ?>">
 	<h1 class="title_hidden"><?= _t('conf.reading.view.normal') ?></h1>
-	<div id="new-article">
+	<div id="new-article" hidden="hidden">
 		<a href="<?= Minz_Url::display(Minz_Request::currentRequest()) ?>"><?= _t('gen.js.new_article'); /* TODO: move string in JS*/ ?></a>
 	</div><?php
 	$lastEntry = null;
@@ -198,7 +198,7 @@ $today = @strtotime('today');
 		ob_end_clean();	//Discard the articles headers, as we have no articles
 ?>
 <main id="stream" class="normal">
-	<div id="new-article">
+	<div id="new-article" hidden="hidden">
 		<a href="<?= Minz_Url::display(Minz_Request::currentRequest()) ?>"><?= _t('gen.js.new_article'); /* TODO: move string in JS*/ ?></a>
 	</div>
 	<div class="prompt alert alert-warn">
diff --git a/app/views/index/reader.phtml b/app/views/index/reader.phtml
index ccca9e50c..ae576c2e5 100644
--- a/app/views/index/reader.phtml
+++ b/app/views/index/reader.phtml
@@ -12,7 +12,7 @@ $lazyload = FreshRSS_Context::userConf()->lazyload;
 ?>
 <main id="stream" class="reader">
 	<h1 class="title_hidden"><?= _t('conf.reading.view.reader') ?></h1>
-	<div id="new-article">
+	<div id="new-article" hidden="hidden">
 		<a href="<?= Minz_Url::display(Minz_Request::currentRequest()) ?>"><?= _t('gen.js.new_article'); /* TODO: move string in JS*/ ?></a>
 	</div><?php
 	$lastEntry = null;
@@ -43,7 +43,7 @@ $lazyload = FreshRSS_Context::userConf()->lazyload;
 		ob_end_clean();	//Discard the articles headers, as we have no articles
 ?>
 <main id="stream" class="reader">
-	<div id="new-article">
+	<div id="new-article" hidden="hidden">
 		<a href="<?= Minz_Url::display(Minz_Request::currentRequest()) ?>"><?= _t('gen.js.new_article'); /* TODO: move string in JS*/ ?></a>
 	</div>
 	<div class="prompt alert alert-warn">
diff --git a/p/scripts/main.js b/p/scripts/main.js
index e11c35205..9e243a519 100644
--- a/p/scripts/main.js
+++ b/p/scripts/main.js
@@ -1779,7 +1779,7 @@ function refreshUnreads() {
 			if ((incUnreadsFeed(null, feed_id, nbUnreads - feed_unreads) || isAll) &&	// Update of current view?
 					(nbUnreads - feed_unreads > 0)) {
 				const newArticle = document.getElementById('new-article');
-				newArticle.setAttribute('aria-hidden', 'false');
+				newArticle.removeAttribute('hidden');
 				newArticle.style.display = 'block';
 				new_articles = true;
 			}
diff --git a/p/themes/base-theme/frss.css b/p/themes/base-theme/frss.css
index 18e10ce3b..eef26fb0c 100644
--- a/p/themes/base-theme/frss.css
+++ b/p/themes/base-theme/frss.css
@@ -408,10 +408,6 @@ td.numeric {
 }
 
 /*=== COMPONENTS */
-/*===============*/
-[aria-hidden="true"] {
-	display: none !important;
-}
 
 /* prompt: login + register form + alert message banner */
 .prompt {
@@ -1279,10 +1275,6 @@ input[type="search"] {
 }
 
 /*=== New article notification */
-#new-article {
-	display: none;
-}
-
 #new-article > a {
 	padding: calc(0.25rem + var(--frss-padding-top-bottom)) 1rem;
 	display: block;
diff --git a/p/themes/base-theme/frss.rtl.css b/p/themes/base-theme/frss.rtl.css
index 1d638eae3..a4e75c30c 100644
--- a/p/themes/base-theme/frss.rtl.css
+++ b/p/themes/base-theme/frss.rtl.css
@@ -408,10 +408,6 @@ td.numeric {
 }
 
 /*=== COMPONENTS */
-/*===============*/
-[aria-hidden="true"] {
-	display: none !important;
-}
 
 /* prompt: login + register form + alert message banner */
 .prompt {
@@ -1279,10 +1275,6 @@ input[type="search"] {
 }
 
 /*=== New article notification */
-#new-article {
-	display: none;
-}
-
 #new-article > a {
 	padding: calc(0.25rem + var(--frss-padding-top-bottom)) 1rem;
 	display: block;