diff options
| author | 2021-12-02 23:25:07 +0100 | |
|---|---|---|
| committer | 2021-12-02 23:25:07 +0100 | |
| commit | a2ab9cf83aaead96497a70a1430ce0424c0d8316 (patch) | |
| tree | 015985aac14f6bd6800ec8cbeb5166e5f9479ea5 /app/Controllers/configureController.php | |
| parent | 4e00c2d3373af223380b9f8f168007bb8e42b6b9 (diff) | |
Minz request avoid custom methods (#4020)
Take advantage of PHP7+ null-coalescing operator `??` to make code more standard, shorter, and faster instead of custom function with no extra functionality.
Allows code to be better tested and fix two PHPstan errors:
```
------ -----------------------------------------
Line app/Controllers/configureController.php
------ -----------------------------------------
410 Cannot unset offset 'rid' on string.
------ -----------------------------------------
------ ------------------------------------
Line lib/Minz/FrontController.php
------ ------------------------------------
70 Cannot unset offset 'c' on string.
71 Cannot unset offset 'a' on string.
------ ------------------------------------
```
https://github.com/FreshRSS/FreshRSS/issues/4016
Diffstat (limited to 'app/Controllers/configureController.php')
| -rwxr-xr-x | app/Controllers/configureController.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/Controllers/configureController.php b/app/Controllers/configureController.php index 79ddf8e17..e8d8fb546 100755 --- a/app/Controllers/configureController.php +++ b/app/Controllers/configureController.php @@ -152,7 +152,7 @@ class FreshRSS_configure_Controller extends Minz_ActionController { Minz_View::appendScript(Minz_Url::display('/scripts/draggable.js?' . @filemtime(PUBLIC_PATH . '/scripts/draggable.js'))); if (Minz_Request::isPost()) { - $params = Minz_Request::fetchPOST(); + $params = $_POST; FreshRSS_Context::$user_conf->sharing = $params['share']; FreshRSS_Context::$user_conf->save(); invalidateHttpCache(); @@ -406,7 +406,7 @@ class FreshRSS_configure_Controller extends Minz_ActionController { foreach (FreshRSS_Context::$user_conf->queries as $key => $query) { $queries[$key] = new FreshRSS_UserQuery($query, $feed_dao, $category_dao, $tag_dao); } - $params = Minz_Request::fetchGET(); + $params = $_GET; unset($params['rid']); $params['url'] = Minz_Url::display(array('params' => $params)); $params['name'] = _t('conf.query.number', count($queries) + 1); |
