diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2023-04-17 08:30:21 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-04-17 08:30:21 +0200 |
| commit | f3760f138dcbaf7a2190336a0378cf1b2190c9f5 (patch) | |
| tree | 6fac8fbf9efd7aa74a8e3970ab70ccf85287b2cd /app/Controllers/importExportController.php | |
| parent | 41fa4e746df8c2e2399ed753b4994ca85cb21358 (diff) | |
Complete PHPStan Level 6 (#5305)
* Complete PHPStan Level 6
Fix https://github.com/FreshRSS/FreshRSS/issues/4112
And initiate PHPStan Level 7
* PHPStan Level 6 for tests
* Use phpstan/phpstan-phpunit
* Update to PHPStan version 1.10
* Fix mixed bug
* Fix mixed return bug
* Fix paginator bug
* Fix FreshRSS_UserConfiguration
* A couple more Minz_Configuration bug fixes
* A few trivial PHPStan Level 7 fixes
* A few more simple PHPStan Level 7
* More files passing PHPStan Level 7
Add interface to replace removed class from https://github.com/FreshRSS/FreshRSS/pull/5251
* A few more PHPStan Level 7 preparations
* A few last details
Diffstat (limited to 'app/Controllers/importExportController.php')
| -rw-r--r-- | app/Controllers/importExportController.php | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/app/Controllers/importExportController.php b/app/Controllers/importExportController.php index 2df185398..4939a0748 100644 --- a/app/Controllers/importExportController.php +++ b/app/Controllers/importExportController.php @@ -226,7 +226,7 @@ class FreshRSS_importExport_Controller extends FreshRSS_ActionController { unset($table['article']); for ($i = count($table['items']) - 1; $i >= 0; $i--) { $item = (array)($table['items'][$i]); - $item = array_filter($item, function ($v) { + $item = array_filter($item, static function ($v) { // Filter out empty properties, potentially reported as empty objects return (is_string($v) && trim($v) !== '') || !empty($v); }); @@ -267,7 +267,7 @@ class FreshRSS_importExport_Controller extends FreshRSS_ActionController { * * $article_file the JSON file content. * true if articles from the file must be starred. - * @return boolean false if an error occurred, true otherwise. + * @return bool false if an error occurred, true otherwise. */ private function importJson(string $article_file, bool $starred = false): bool { $article_object = json_decode($article_file, true); @@ -575,10 +575,8 @@ class FreshRSS_importExport_Controller extends FreshRSS_ActionController { * - export_starred (default: false) * - export_labelled (default: false) * - export_feeds (default: array()) a list of feed ids - * - * @return void|null */ - public function exportAction() { + public function exportAction(): void { if (!Minz_Request::isPost()) { Minz_Request::forward(['c' => 'importExport', 'a' => 'index'], true); return; @@ -654,7 +652,7 @@ class FreshRSS_importExport_Controller extends FreshRSS_ActionController { header('Content-Type: ' . $content_type); header('Content-disposition: attachment; filename="' . $filename . '"'); - $this->view->_layout(false); + $this->view->_layout(null); $this->view->content = $content; } |