diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2023-05-11 13:02:04 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-05-11 13:02:04 +0200 |
| commit | 6e2f2f1c1e98ecd86aa89c6547beb742d7385d18 (patch) | |
| tree | 7ba9f5aebb01d12045b9067a86b5060ba13dca18 /app/Controllers/statsController.php | |
| parent | fe7d9bbcd68660a59b813346c236b61b25a51c80 (diff) | |
A few additional PHPStan rules (#5388)
A subset of
https://github.com/phpstan/phpstan-strict-rules
Diffstat (limited to 'app/Controllers/statsController.php')
| -rw-r--r-- | app/Controllers/statsController.php | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/app/Controllers/statsController.php b/app/Controllers/statsController.php index d9c4fe5f4..3ce42dd2c 100644 --- a/app/Controllers/statsController.php +++ b/app/Controllers/statsController.php @@ -5,7 +5,10 @@ */ class FreshRSS_stats_Controller extends FreshRSS_ActionController { - /** @var FreshRSS_ViewStats */ + /** + * @var FreshRSS_ViewStats + * @phpstan-ignore-next-line + */ protected $view; public function __construct() { @@ -57,7 +60,7 @@ class FreshRSS_stats_Controller extends FreshRSS_ActionController { $this->view->repartitions = $statsDAO->calculateEntryRepartition(); $entryCount = $statsDAO->calculateEntryCount(); - if (is_array($entryCount) && count($entryCount) > 0) { + if (count($entryCount) > 0) { $this->view->entryCount = $entryCount; $this->view->average = round(array_sum(array_values($entryCount)) / count($entryCount), 2); } else { @@ -67,21 +70,17 @@ class FreshRSS_stats_Controller extends FreshRSS_ActionController { $feedByCategory = []; $feedByCategory_calculated = $statsDAO->calculateFeedByCategory(); - if (is_array($feedByCategory_calculated)) { - for ($i = 0; $i < count($feedByCategory_calculated); $i++) { - $feedByCategory['label'][$i] = $feedByCategory_calculated[$i]['label']; - $feedByCategory['data'][$i] = $feedByCategory_calculated[$i]['data']; - } + for ($i = 0; $i < count($feedByCategory_calculated); $i++) { + $feedByCategory['label'][$i] = $feedByCategory_calculated[$i]['label']; + $feedByCategory['data'][$i] = $feedByCategory_calculated[$i]['data']; } $this->view->feedByCategory = $feedByCategory; $entryByCategory = []; $entryByCategory_calculated = $statsDAO->calculateEntryByCategory(); - if (is_array($entryByCategory_calculated)) { - for ($i = 0; $i < count($entryByCategory_calculated); $i++) { - $entryByCategory['label'][$i] = $entryByCategory_calculated[$i]['label']; - $entryByCategory['data'][$i] = $entryByCategory_calculated[$i]['data']; - } + for ($i = 0; $i < count($entryByCategory_calculated); $i++) { + $entryByCategory['label'][$i] = $entryByCategory_calculated[$i]['label']; + $entryByCategory['data'][$i] = $entryByCategory_calculated[$i]['data']; } $this->view->entryByCategory = $entryByCategory; |