diff options
| author | 2019-12-23 11:00:22 +0100 | |
|---|---|---|
| committer | 2019-12-23 11:00:22 +0100 | |
| commit | 8f5d8af72f91e3fa1d47717379570964fe970069 (patch) | |
| tree | ed089f75bfc7070ac1192f6e235387a70f0d0258 /app/Models/Category.php | |
| parent | 61fb6f8b86a3fc395dcfa16abab2c94ad3be5b27 (diff) | |
tec: Fix test suite (#2721)
* Rework the travis file to enable PHPUnit
I realized that unit tests weren't executed on Travis. While working on
this file to enable these tests, I started to think we could simplify
it.
I separated jobs so:
- PHP linter and tests are only performed on PHP 7.3
- Translations are tested separatly so they can fail (it was already the
case but it was hard to understand the way it was done)
- PHP 5.6 only checks syntax issues
- the last job checks css, js, etc. (it didn't change)
PHPUnit is not executed on 5.6 because only the version 5 is available
while the latest version is the 8 (https://phpunit.de/supported-versions.html).
I think it's easier to read (each job is more explicit) but I'm not a
Travis expert so maybe there's some room for improvements.
* Fix failing tests
The category `_name` regression was introduced in commit b323ed084.
I wasn't able to understand when and why Search tests was wrong.
The rest is about upgrade of PHPUnit.
Diffstat (limited to 'app/Models/Category.php')
| -rw-r--r-- | app/Models/Category.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/Models/Category.php b/app/Models/Category.php index a195c88b3..6956029ad 100644 --- a/app/Models/Category.php +++ b/app/Models/Category.php @@ -84,7 +84,7 @@ class FreshRSS_Category extends Minz_Model { } } public function _name($value) { - $this->name = trim($value); + $this->name = mb_strcut(trim($value), 0, 255, 'UTF-8'); } public function _isDefault($value) { $this->isDefault = $value; |
