diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2024-09-11 17:14:53 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-09-11 17:14:53 +0200 |
| commit | dfac9f5813df7d4c7c812c381364c8898333f559 (patch) | |
| tree | 978496d0a8d8b0d6b5dbe836c6829296133b337c /app/Models/EntryDAOSQLite.php | |
| parent | 31c8846791d4b5316fbc790202f79545c012f9c2 (diff) | |
PHPStan booleansInConditions (#6793)
* PHPStan booleansInConditions
* Uniformisation
Diffstat (limited to 'app/Models/EntryDAOSQLite.php')
| -rw-r--r-- | app/Models/EntryDAOSQLite.php | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/app/Models/EntryDAOSQLite.php b/app/Models/EntryDAOSQLite.php index 6d604f25a..7cf6eb202 100644 --- a/app/Models/EntryDAOSQLite.php +++ b/app/Models/EntryDAOSQLite.php @@ -52,7 +52,7 @@ class FreshRSS_EntryDAOSQLite extends FreshRSS_EntryDAO { /** @param array<string|int> $errorInfo */ #[\Override] protected function autoUpdateDb(array $errorInfo): bool { - if ($tableInfo = $this->pdo->query("PRAGMA table_info('entry')")) { + if (($tableInfo = $this->pdo->query("PRAGMA table_info('entry')")) !== false) { $columns = $tableInfo->fetchAll(PDO::FETCH_COLUMN, 1) ?: []; foreach (['attributes'] as $column) { if (!in_array($column, $columns, true)) { @@ -117,8 +117,8 @@ SQL; $sql = 'UPDATE `_entry` SET is_read=? WHERE id=? AND is_read=?'; $values = [$is_read ? 1 : 0, $ids, $is_read ? 0 : 1]; $stm = $this->pdo->prepare($sql); - if (!($stm && $stm->execute($values))) { - $info = $stm == null ? $this->pdo->errorInfo() : $stm->errorInfo(); + if ($stm === false || !$stm->execute($values)) { + $info = $stm === false ? $this->pdo->errorInfo() : $stm->errorInfo(); Minz_Log::error('SQL error ' . __METHOD__ . ' A ' . json_encode($info)); $this->pdo->rollBack(); return false; @@ -129,8 +129,8 @@ SQL; . 'WHERE id=(SELECT e.id_feed FROM `_entry` e WHERE e.id=?)'; $values = [$ids]; $stm = $this->pdo->prepare($sql); - if (!($stm && $stm->execute($values))) { - $info = $stm == null ? $this->pdo->errorInfo() : $stm->errorInfo(); + if ($stm === false || !$stm->execute($values)) { + $info = $stm === false ? $this->pdo->errorInfo() : $stm->errorInfo(); Minz_Log::error('SQL error ' . __METHOD__ . ' B ' . json_encode($info)); $this->pdo->rollBack(); return false; @@ -167,8 +167,8 @@ SQL; [$searchValues, $search] = $this->sqlListEntriesWhere('e.', $filters, $state); $stm = $this->pdo->prepare($sql . $search); - if (!($stm && $stm->execute(array_merge($values, $searchValues)))) { - $info = $stm == null ? $this->pdo->errorInfo() : $stm->errorInfo(); + if ($stm === false || !$stm->execute(array_merge($values, $searchValues))) { + $info = $stm === false ? $this->pdo->errorInfo() : $stm->errorInfo(); Minz_Log::error('SQL error ' . __METHOD__ . json_encode($info)); return false; } |