diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2022-01-04 13:59:09 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-01-04 13:59:09 +0100 |
| commit | 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef (patch) | |
| tree | ed6a8d17cef0581e5b0402dc8dfedd42fabfe9c7 /app/Models/Feed.php | |
| parent | 0988b0c2be911133f883313bc3a858670192cc69 (diff) | |
PHPStan level 5 (#4110)
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
* PHPStan level 3
* PHPStand level 4
* Update default to PHPStan level 4
* Towards level 5
* Fix level 4 regression
* Towards level 5
* Pass PHPStan level 5
* Towards level 6
* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
Diffstat (limited to 'app/Models/Feed.php')
| -rw-r--r-- | app/Models/Feed.php | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/app/Models/Feed.php b/app/Models/Feed.php index 3dc965b32..972983384 100644 --- a/app/Models/Feed.php +++ b/app/Models/Feed.php @@ -259,6 +259,7 @@ class FreshRSS_Feed extends Minz_Model { public function load($loadDetails = false, $noCache = false) { if ($this->url !== null) { + // @phpstan-ignore-next-line if (CACHE_PATH === false) { throw new Minz_FileNotExistException( 'CACHE_PATH', @@ -462,10 +463,10 @@ class FreshRSS_Feed extends Minz_Model { $entry = new FreshRSS_Entry( $this->id(), $hasBadGuids ? '' : $guid, - $title === null ? '' : $title, + $title == '' ? '' : $title, $author_names, - $content === null ? '' : $content, - $link === null ? '' : $link, + $content == '' ? '' : $content, + $link == '' ? '' : $link, $date ? $date : time() ); $entry->_tags($tags); |