diff options
| author | 2025-11-26 16:47:40 +0100 | |
|---|---|---|
| committer | 2025-11-26 16:47:40 +0100 | |
| commit | b3cfc387b8f0583eb652a9d61691dbc6119771ea (patch) | |
| tree | 3db57add5ce115445b6259ddbae4cb493d353920 /app/Models/FeedDAOPGSQL.php | |
| parent | fbfc5eacadc1fada6a538690e2949ad3c49bde4f (diff) | |
Fix MariaDB for updates (#8254)
fix https://github.com/FreshRSS/FreshRSS/issues/8252
regression from https://github.com/FreshRSS/FreshRSS/pull/6957
The current code works with MySQL 8+ (as well as PostgreSQL and SQLite), but not with MariaDB, because MariaDB does not support CTE (Common Table Expression) fully (which I was not aware of)...
Diffstat (limited to 'app/Models/FeedDAOPGSQL.php')
| -rw-r--r-- | app/Models/FeedDAOPGSQL.php | 42 |
1 files changed, 42 insertions, 0 deletions
diff --git a/app/Models/FeedDAOPGSQL.php b/app/Models/FeedDAOPGSQL.php index f436a2ec4..d09d2e1c9 100644 --- a/app/Models/FeedDAOPGSQL.php +++ b/app/Models/FeedDAOPGSQL.php @@ -10,4 +10,46 @@ SELECT setval('`_feed_id_seq`', COALESCE(MAX(id), 0) + 1, false) FROM `_feed` SQL; return $this->pdo->exec($sql) !== false; } + + #[\Override] + public function updateCachedValues(int ...$feedIds): int|false { + if (empty($feedIds)) { + $whereFeedIds = 'true'; + $whereEntryIdFeeds = 'true'; + } else { + $whereFeedIds = 'id IN (' . str_repeat('?,', count($feedIds) - 1) . '?)'; + $whereEntryIdFeeds = 'id_feed IN (' . str_repeat('?,', count($feedIds) - 1) . '?)'; + } + $sql = <<<SQL + WITH entry_counts AS ( + SELECT + id_feed, + COUNT(*) AS total_entries, + SUM(CASE WHEN is_read = 0 THEN 1 ELSE 0 END) AS unread_entries + FROM `_entry` + WHERE $whereEntryIdFeeds + GROUP BY id_feed + ) + UPDATE `_feed` + SET `cache_nbEntries` = COALESCE(( + SELECT c.total_entries + FROM entry_counts AS c + WHERE c.id_feed = `_feed`.id + ), 0), + `cache_nbUnreads` = COALESCE(( + SELECT c.unread_entries + FROM entry_counts AS c + WHERE c.id_feed = `_feed`.id + ), 0) + WHERE $whereFeedIds + SQL; + $stm = $this->pdo->prepare($sql); + if ($stm !== false && $stm->execute(array_merge($feedIds, $feedIds))) { + return $stm->rowCount(); + } else { + $info = $stm === false ? $this->pdo->errorInfo() : $stm->errorInfo(); + Minz_Log::error('SQL error ' . __METHOD__ . json_encode($info)); + return false; + } + } } |
