Improve configuration checks (#8334)

Add a distinction between recommended and required extensions.
Add check for recommended php-intl extension as follow-up of https://github.com/FreshRSS/FreshRSS/pull/8329#issuecomment-3677686581
Improve related checks such as ZIP.
Reduce duplicated translations and tests.

2 files changed, 34 insertions, 96 deletions

diff --git a/app/i18n/en/admin.php b/app/i18n/en/admin.php
index 20e8e355a..f905a2030 100644
--- a/app/i18n/en/admin.php
+++ b/app/i18n/en/admin.php
@@ -23,92 +23,6 @@ return array(
 		'token_help' => 'Allows access to all RSS outputs of the user as well as refreshing feeds without authentication:',
 		'type' => 'Authentication method',
 	),
-	'check_install' => array(
-		'cache' => array(
-			'nok' => 'Check permissions on <em>./data/cache</em> directory. HTTP server must have write permission.',
-			'ok' => 'Permissions on the cache directory are good.',
-		),
-		'categories' => array(
-			'nok' => 'Category table is improperly configured.',
-			'ok' => 'Category table is okay.',
-		),
-		'connection' => array(
-			'nok' => 'Connection to the database cannot be established.',
-			'ok' => 'Connection to the database is okay.',
-		),
-		'ctype' => array(
-			'nok' => 'Cannot find a required library for character type checking (php-ctype).',
-			'ok' => 'You have the required library for character type checking (ctype).',
-		),
-		'curl' => array(
-			'nok' => 'Cannot find the cURL library (php-curl package).',
-			'ok' => 'You have the cURL library.',
-		),
-		'data' => array(
-			'nok' => 'Check permissions on <em>./data</em> directory. HTTP server must have write permission.',
-			'ok' => 'Permissions on the data directory are good.',
-		),
-		'database' => 'Database installation',
-		'dom' => array(
-			'nok' => 'Cannot find a required library to browse the DOM (php-xml package).',
-			'ok' => 'You have the required library to browse the DOM.',
-		),
-		'entries' => array(
-			'nok' => 'Entry table is improperly configured.',
-			'ok' => 'Entry table is okay.',
-		),
-		'favicons' => array(
-			'nok' => 'Check permissions on <em>./data/favicons</em> directory. HTTP server must have write permission.',
-			'ok' => 'Permissions on the favicons directory are good.',
-		),
-		'feeds' => array(
-			'nok' => 'Feed table is improperly configured.',
-			'ok' => 'Feed table is okay.',
-		),
-		'fileinfo' => array(
-			'nok' => 'Cannot find the PHP fileinfo library (fileinfo package).',
-			'ok' => 'You have the fileinfo library.',
-		),
-		'files' => 'File installation',
-		'json' => array(
-			'nok' => 'Cannot find JSON (php-json package).',
-			'ok' => 'You have the JSON extension.',
-		),
-		'mbstring' => array(
-			'nok' => 'Cannot find the recommended mbstring library for Unicode.',
-			'ok' => 'You have the recommended mbstring library for Unicode.',
-		),
-		'pcre' => array(
-			'nok' => 'Cannot find a required library for regular expressions (php-pcre).',
-			'ok' => 'You have the required library for regular expressions (PCRE).',
-		),
-		'pdo' => array(
-			'nok' => 'Cannot find PDO or one of the supported drivers (pdo_mysql, pdo_sqlite, pdo_pgsql).',
-			'ok' => 'You have PDO and at least one of the supported drivers (pdo_mysql, pdo_sqlite, pdo_pgsql).',
-		),
-		'php' => array(
-			'_' => 'PHP installation',
-			'nok' => 'Your PHP version is %s but FreshRSS requires at least version %s.',
-			'ok' => 'Your PHP version (%s) is compatible with FreshRSS.',
-		),
-		'tables' => array(
-			'nok' => 'There are one or more missing tables in the database.',
-			'ok' => 'The appropriate tables exist in the database.',
-		),
-		'title' => 'Installation check',
-		'tokens' => array(
-			'nok' => 'Check permissions on <em>./data/tokens</em> directory. HTTP server must have write permission',
-			'ok' => 'Permissions on the tokens directory are good.',
-		),
-		'users' => array(
-			'nok' => 'Check permissions on <em>./data/users</em> directory. HTTP server must have write permission',
-			'ok' => 'Permissions on the users directory are good.',
-		),
-		'zip' => array(
-			'nok' => 'Cannot find the ZIP extension (php-zip package).',
-			'ok' => 'You have the ZIP extension.',
-		),
-	),
 	'extensions' => array(
 		'author' => 'Author',
 		'community' => 'Available community extensions',
diff --git a/app/i18n/en/install.php b/app/i18n/en/install.php
index 2d4b1a882..9a4189160 100644
--- a/app/i18n/en/install.php
+++ b/app/i18n/en/install.php
@@ -43,8 +43,8 @@ return array(
 			'ok' => 'You have the required library for character type checking (ctype).',
 		),
 		'curl' => array(
-			'nok' => 'Cannot find the cURL library (php-curl package).',
-			'ok' => 'You have the cURL library.',
+			'nok' => 'Cannot find the required cURL library (php-curl package).',
+			'ok' => 'You have the required cURL library.',
 		),
 		'data' => array(
 			'nok' => 'Check permissions on the <em>%1$s</em> directory for <em>%2$s</em> user. The HTTP server must have write permission.',
@@ -59,12 +59,17 @@ return array(
 			'ok' => 'Permissions on the favicons directory are good.',
 		),
 		'fileinfo' => array(
-			'nok' => 'Cannot find the PHP fileinfo library (fileinfo package).',
-			'ok' => 'You have the fileinfo library.',
+			'nok' => 'Cannot find the recommended PHP fileinfo library (fileinfo package).',
+			'ok' => 'You have the recommended PHP fileinfo library (fileinfo package).',
+		),
+		'files' => 'File installation',
+		'intl' => array(
+			'nok' => 'Cannot find the recommended library php-intl for internationalisation.',
+			'ok' => 'You have the recommended library php-intl for internationalisation.',
 		),
 		'json' => array(
-			'nok' => 'Cannot find the recommended library to parse JSON.',
-			'ok' => 'You have the recommended library to parse JSON.',
+			'nok' => 'Cannot find the required library to parse JSON.',
+			'ok' => 'You have the required library to parse JSON.',
 		),
 		'mbstring' => array(
 			'nok' => 'Cannot find the recommended library mbstring for Unicode.',
@@ -74,19 +79,34 @@ return array(
 			'nok' => 'Cannot find the required library for regular expressions (php-pcre).',
 			'ok' => 'You have the required library for regular expressions (PCRE).',
 		),
+		'pdo-mysql' => array(
+			'nok' => 'Cannot find the required PDO driver for MySQL/MariaDB.',
+		),
+		'pdo-pgsql' => array(
+			'nok' => 'Cannot find the required PDO driver for PostgreSQL.',
+		),
+		'pdo-sqlite' => array(
+			'nok' => 'Cannot find the PDO driver for SQLite.',
+			'ok' => 'You have the PDO driver for SQLite',
+		),
 		'pdo' => array(
-			'nok' => 'Cannot find PDO or one of the supported drivers (pdo_mysql, pdo_sqlite, pdo_pgsql).',
-			'ok' => 'You have PDO and at least one of the supported drivers (pdo_mysql, pdo_sqlite, pdo_pgsql).',
+			'nok' => 'Cannot find PDO or one of the supported drivers (pdo_sqlite, pdo_pgsql, pdo_mysql).',
+			'ok' => 'You have PDO and at least one of the supported drivers (pdo_sqlite, pdo_pgsql, pdo_mysql).',
 		),
 		'php' => array(
-			'nok' => 'Your PHP version is %s, but FreshRSS requires at least version %s.',
-			'ok' => 'Your PHP version, %s, is compatible with FreshRSS.',
+			'_' => 'PHP installation',
+			'nok' => 'Your PHP version is %s but FreshRSS requires at least version %s.',
+			'ok' => 'Your PHP version (%s) is compatible with FreshRSS.',
 		),
 		'reload' => 'Check again',
 		'tmp' => array(
 			'nok' => 'Check permissions on the <em>%1$s</em> directory for <em>%2$s</em> user. The HTTP server must have write permissions.',
 			'ok' => 'Permissions on the temp directory are good.',
 		),
+		'tokens' => array(
+			'nok' => 'Check permissions on <em>./data/tokens</em> directory. HTTP server must have write permission',
+			'ok' => 'Permissions on the tokens directory are good.',
+		),
 		'unknown_process_username' => 'unknown',
 		'users' => array(
 			'nok' => 'Check permissions on the <em>%1$s</em> directory for <em>%2$s</em> user. The HTTP server must have write permissions.',
@@ -96,6 +116,10 @@ return array(
 			'nok' => 'Cannot find the required library to parse XML.',
 			'ok' => 'You have the required library to parse XML.',
 		),
+		'zip' => array(
+			'nok' => 'Cannot find the recommended extension for ZIP (php-zip package).',
+			'ok' => 'You have the recommended extension for ZIP (php-zip package).',
+		),
 	),
 	'conf' => array(
 		'_' => 'General configuration',