aboutsummaryrefslogtreecommitdiff
path: root/app/install.php
diff options
context:
space:
mode:
authorGravatar Alexandre Alapetite <alexandre@alapetite.fr> 2017-03-26 00:01:11 +0100
committerGravatar Alexandre Alapetite <alexandre@alapetite.fr> 2017-03-26 00:01:11 +0100
commit22b41f3bfcbd5a54d59789c2cebfda6dc23b7dde (patch)
tree791c68ecdf3b5fb6816ab82eaed5ce454a81e4dc /app/install.php
parenta513ca9030314dec0f01b3cc147ceaf0c9b14d88 (diff)
Candidate implementation of defered insertion
https://github.com/FreshRSS/FreshRSS/issues/530
Diffstat (limited to 'app/install.php')
-rw-r--r--app/install.php36
1 files changed, 10 insertions, 26 deletions
diff --git a/app/install.php b/app/install.php
index 9a88e0f37..17037c384 100644
--- a/app/install.php
+++ b/app/install.php
@@ -342,35 +342,19 @@ function checkDbUser(&$dbOptions) {
$driver_options = $dbOptions['options'];
try {
$c = new PDO($str, $dbOptions['user'], $dbOptions['password'], $driver_options);
-
if (defined('SQL_CREATE_TABLES')) {
- $sql = sprintf(SQL_CREATE_TABLES, $dbOptions['prefix_user'], _t('gen.short.default_category'));
- $stm = $c->prepare($sql);
- $ok = $stm->execute();
- } else {
- global $SQL_CREATE_TABLES;
- if (is_array($SQL_CREATE_TABLES)) {
- $ok = true;
- foreach ($SQL_CREATE_TABLES as $instruction) {
- $sql = sprintf($instruction, $dbOptions['prefix_user'], _t('gen.short.default_category'));
- $stm = $c->prepare($sql);
- $ok &= $stm->execute();
- }
- }
- }
-
- if (defined('SQL_INSERT_FEEDS')) {
- $sql = sprintf(SQL_INSERT_FEEDS, $dbOptions['prefix_user']);
+ $sql = sprintf(SQL_CREATE_TABLES . SQL_CREATE_TABLE_ENTRYTMP . SQL_INSERT_FEEDS,
+ $dbOptions['prefix_user'], _t('gen.short.default_category'));
$stm = $c->prepare($sql);
- $ok &= $stm->execute();
+ $ok = $stm && $stm->execute();
} else {
- global $SQL_INSERT_FEEDS;
- if (is_array($SQL_INSERT_FEEDS)) {
- foreach ($SQL_INSERT_FEEDS as $instruction) {
- $sql = sprintf($instruction, $dbOptions['prefix_user']);
- $stm = $c->prepare($sql);
- $ok &= $stm->execute();
- }
+ global $SQL_CREATE_TABLES, $SQL_CREATE_TABLE_ENTRYTMP, $SQL_INSERT_FEEDS;
+ $instructions = array_merge($SQL_CREATE_TABLES, $SQL_CREATE_TABLE_ENTRYTMP, $SQL_INSERT_FEEDS);
+ $ok = !empty($instructions);
+ foreach ($instructions as $instruction) {
+ $sql = sprintf($instruction, $dbOptions['prefix_user'], _t('gen.short.default_category'));
+ $stm = $c->prepare($sql);
+ $ok &= $stm && $stm->execute();
}
}
} catch (PDOException $e) {