diff options
| author |  maTh <1645099+math-GH@users.noreply.github.com>
| 2025-01-31 13:58:57 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2025-01-31 13:58:57 +0100 |
| commit | f72f5e95238a866c39535932c803720d7644a276 (patch) | |
| tree | 3e8069c5fba45068a6d4f3f99eb3a0d5ba8eb9e5 /app/layout | |
| parent | d1eb85e374c064146c0519d4bf6ca7e936a8014c (diff) | |
Improve notification banner (#7268)
* a -> button
* i18n: Close
* a.close -> .close
* themes
* Apply suggestions from code review
Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
* Update app/i18n/fr/gen.php
---------
Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Diffstat (limited to 'app/layout')
| -rw-r--r-- | app/layout/layout.phtml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/app/layout/layout.phtml b/app/layout/layout.phtml index 217239f01..6d4668cd5 100644 --- a/app/layout/layout.phtml +++ b/app/layout/layout.phtml @@ -91,9 +91,9 @@ invalidateHttpCache(); } ?> -<div id="notification" class="notification <?= $status ?>"> - <span class="msg"><?= $msg ?></span> - <a class="close" href=""><?= _i('close') ?></a> +<div role="dialog" id="notification" class="notification <?= $status ?>" aria-describedby="dialogMsg"> + <span class="msg" id="dialogMsg"><?= $msg ?></span> + <button class="close" title="<?= _t('gen.action.close') ?>"><?= _i('close') ?></button> </div> </body> </html> |