diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2022-01-04 13:59:09 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-01-04 13:59:09 +0100 |
| commit | 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef (patch) | |
| tree | ed6a8d17cef0581e5b0402dc8dfedd42fabfe9c7 /app/views/helpers | |
| parent | 0988b0c2be911133f883313bc3a858670192cc69 (diff) | |
PHPStan level 5 (#4110)
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
* PHPStan level 3
* PHPStand level 4
* Update default to PHPStan level 4
* Towards level 5
* Fix level 4 regression
* Towards level 5
* Pass PHPStan level 5
* Towards level 6
* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
Diffstat (limited to 'app/views/helpers')
| -rw-r--r-- | app/views/helpers/index/normal/entry_bottom.phtml | 1 | ||||
| -rwxr-xr-x | app/views/helpers/pagination.phtml | 6 |
2 files changed, 4 insertions, 3 deletions
diff --git a/app/views/helpers/index/normal/entry_bottom.phtml b/app/views/helpers/index/normal/entry_bottom.phtml index 07e68ed92..5f105c6c9 100644 --- a/app/views/helpers/index/normal/entry_bottom.phtml +++ b/app/views/helpers/index/normal/entry_bottom.phtml @@ -35,6 +35,7 @@ ?></li><?php } } + // @phpstan-ignore-next-line if ($bottomline_labels) { ?><li class="item"> <div class="dropdown dynamictags"> diff --git a/app/views/helpers/pagination.phtml b/app/views/helpers/pagination.phtml index 9b249762c..eed4f5dc2 100755 --- a/app/views/helpers/pagination.phtml +++ b/app/views/helpers/pagination.phtml @@ -20,7 +20,7 @@ <?php $hasAccess = FreshRSS_Auth::hasAccess(); -if ($url_mark_read && $hasAccess) { ?> +if ($hasAccess) { ?> <form id="mark-read-pagination" method="post"> <input type="hidden" name="_csrf" value="<?= FreshRSS_Auth::csrfToken() ?>" /> <?php } else { ?> @@ -32,7 +32,7 @@ if ($url_mark_read && $hasAccess) { ?> <a id="load_more" href="<?= Minz_Url::display($url_next) ?>"> <?= _t('gen.pagination.load_more') ?> </a> - <?php } elseif ($url_mark_read && $hasAccess) { ?> + <?php } elseif ($hasAccess) { ?> <button id="bigMarkAsRead" class="as-link <?= FreshRSS_Context::$user_conf->reading_confirm ? 'confirm" disabled="disabled' : '' ?>" form="mark-read-pagination" @@ -49,7 +49,7 @@ if ($url_mark_read && $hasAccess) { ?> <?php } ?> </li> </ul> -<?php if ($url_mark_read && $hasAccess) { ?> +<?php if ($hasAccess) { ?> </form> <?php } else {?> </div> |