diff options
| author |  berumuron <dev@marienfressinaud.fr>
| 2021-03-13 18:55:43 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-03-13 18:55:43 +0100 |
| commit | 2c4f169f0a22d3665caa37d64628d5b84359bb45 (patch) | |
| tree | cbde7758486aa9e5429a454863eaaa4b17e94d7d /app/views/subscription | |
| parent | b455b29c8cbb530b312e0a6cc2724d3c8b436580 (diff) | |
Hide advanced options in new feed form (#3516)
* Hide new feed advanced options in a details tag
The form was huge and hard to process for beginners. Most of the fields
are optional 99% of time, there is no need to have them so proeminently.
* Remove sub.feed.auth.configuration i18n key
* Sync RTL css files
* Fix stylelint
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* Fix "for" attributes in add feed form
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Diffstat (limited to 'app/views/subscription')
| -rw-r--r-- | app/views/subscription/add.phtml | 104 |
1 files changed, 54 insertions, 50 deletions
diff --git a/app/views/subscription/add.phtml b/app/views/subscription/add.phtml index 8d1dc6d2d..9e652f702 100644 --- a/app/views/subscription/add.phtml +++ b/app/views/subscription/add.phtml @@ -44,69 +44,73 @@ </div> </div> - <legend><?= _t('sub.feed.auth.configuration') ?></legend> - <div class="form-group"> - <label class="group-name" for="http_user"><?= _t('sub.feed.auth.username') ?></label> - <div class="group-controls"> - <input id="http_user" name="http_user" type="text" autocomplete="off"/> + <details class="form-advanced"> + <summary class="form-advanced-title"> + <?= _t('sub.feed.advanced') ?> + </summary> + + <div class="form-group"> + <label class="group-name" for="http_user"><?= _t('sub.feed.auth.username') ?></label> + <div class="group-controls"> + <input id="http_user" name="http_user" type="text" autocomplete="off"/> + </div> </div> - </div> - <div class="form-group"> - <label class="group-name" for="http_pass"><?= _t('sub.feed.auth.password') ?></label> - <div class="group-controls"> - <input id="http_pass" name="http_pass" type="text" value=" " autocomplete="new-password"/> + <div class="form-group"> + <label class="group-name" for="http_pass"><?= _t('sub.feed.auth.password') ?></label> + <div class="group-controls"> + <input id="http_pass" name="http_pass" type="text" value=" " autocomplete="new-password"/> + </div> </div> - </div> - <legend><?= _t('sub.feed.advanced') ?></legend> - <div class="form-group"> - <label class="group-name" for="path_entries"><?= _t('sub.feed.useragent') ?></label> - <div class="group-controls"> - <div class="stick"> - <input type="text" name="curl_params_useragent" id="curl_params_useragent" class="extend" value="" placeholder="<?= _t('gen.short.blank_to_disable') ?>" /> + <div class="form-group"> + <label class="group-name" for="curl_params_useragent"><?= _t('sub.feed.useragent') ?></label> + <div class="group-controls"> + <div class="stick"> + <input type="text" name="curl_params_useragent" id="curl_params_useragent" class="extend" value="" placeholder="<?= _t('gen.short.blank_to_disable') ?>" /> + </div> + <p class="help"><?= _i('help') ?> <?= _t('sub.feed.useragent_help') ?></p> </div> - <p class="help"><?= _i('help') ?> <?= _t('sub.feed.useragent_help') ?></p> </div> - </div> - <div class="form-group"> - <label class="group-name" for="path_entries"><?= _t('sub.feed.proxy') ?></label> - <div class="group-controls"> - <select class="number" name="proxy_type" id="proxy_type"><?php - foreach(['' => '', 3 => 'NONE', 0 => 'HTTP', 2 => 'HTTPS', 4 => 'SOCKS4', 6 => 'SOCKS4A', 5 => 'SOCKS5', 7 => 'SOCKS5H'] as $k => $v) { - echo '<option value="' . $k . '">' . $v . '</option>'; - } - ?> - </select> - <div class="stick"> - <input type="text" name="curl_params" id="curl_params" class="extend" value="" placeholder="<?= _t('gen.short.blank_to_disable') ?>" /> + <div class="form-group"> + <label class="group-name" for="proxy_type"><?= _t('sub.feed.proxy') ?></label> + <div class="group-controls"> + <select class="number" name="proxy_type" id="proxy_type"><?php + foreach(['' => '', 3 => 'NONE', 0 => 'HTTP', 2 => 'HTTPS', 4 => 'SOCKS4', 6 => 'SOCKS4A', 5 => 'SOCKS5', 7 => 'SOCKS5H'] as $k => $v) { + echo '<option value="' . $k . '">' . $v . '</option>'; + } + ?> + </select> + <div class="stick"> + <input type="text" name="curl_params" id="curl_params" class="extend" value="" placeholder="<?= _t('gen.short.blank_to_disable') ?>" /> + </div> + <p class="help"><?= _i('help') ?> <?= _t('sub.feed.proxy_help') ?></p> </div> - <p class="help"><?= _i('help') ?> <?= _t('sub.feed.proxy_help') ?></p> </div> - </div> - <?php if (FreshRSS_Auth::hasAccess('admin')) { ?> - <div class="form-group"> - <label class="group-name" for="timeout"><?= _t('sub.feed.timeout') ?></label> - <div class="group-controls"> - <input type="number" name="timeout" id="timeout" min="3" max="120" value="" placeholder="<?= _t('gen.short.by_default') ?>" /> + <?php if (FreshRSS_Auth::hasAccess('admin')) { ?> + <div class="form-group"> + <label class="group-name" for="timeout"><?= _t('sub.feed.timeout') ?></label> + <div class="group-controls"> + <input type="number" name="timeout" id="timeout" min="3" max="120" value="" placeholder="<?= _t('gen.short.by_default') ?>" /> + </div> </div> - </div> - <div class="form-group"> - <label class="group-name" for="ssl_verify"><?= _t('sub.feed.ssl_verify') ?></label> - <div class="group-controls"> - <label class="checkbox" for="ssl_verify"> - <select name="ssl_verify" id="ssl_verify"> - <option value=""><?= _t('gen.short.by_default') ?></option> - <option value="0"><?= _t('gen.short.no') ?></option> - <option value="1"><?= _t('gen.short.yes') ?></option> - </select> - </label> + <div class="form-group"> + <label class="group-name" for="ssl_verify"><?= _t('sub.feed.ssl_verify') ?></label> + <div class="group-controls"> + <label class="checkbox" for="ssl_verify"> + <select name="ssl_verify" id="ssl_verify"> + <option value=""><?= _t('gen.short.by_default') ?></option> + <option value="0"><?= _t('gen.short.no') ?></option> + <option value="1"><?= _t('gen.short.yes') ?></option> + </select> + </label> + </div> </div> - </div> - <?php } ?> + <?php } ?> + </details> <div class="form-group form-actions"> <div class="group-controls"> |