diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2021-12-02 23:25:07 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-12-02 23:25:07 +0100 |
| commit | a2ab9cf83aaead96497a70a1430ce0424c0d8316 (patch) | |
| tree | 015985aac14f6bd6800ec8cbeb5166e5f9479ea5 /app/views | |
| parent | 4e00c2d3373af223380b9f8f168007bb8e42b6b9 (diff) | |
Minz request avoid custom methods (#4020)
Take advantage of PHP7+ null-coalescing operator `??` to make code more standard, shorter, and faster instead of custom function with no extra functionality.
Allows code to be better tested and fix two PHPstan errors:
```
------ -----------------------------------------
Line app/Controllers/configureController.php
------ -----------------------------------------
410 Cannot unset offset 'rid' on string.
------ -----------------------------------------
------ ------------------------------------
Line lib/Minz/FrontController.php
------ ------------------------------------
70 Cannot unset offset 'c' on string.
71 Cannot unset offset 'a' on string.
------ ------------------------------------
```
https://github.com/FreshRSS/FreshRSS/issues/4016
Diffstat (limited to 'app/views')
| -rwxr-xr-x | app/views/entry/bookmark.phtml | 2 | ||||
| -rwxr-xr-x | app/views/helpers/logs_pagination.phtml | 2 | ||||
| -rw-r--r-- | app/views/index/global.phtml | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/app/views/entry/bookmark.phtml b/app/views/entry/bookmark.phtml index d85706669..e842f7465 100755 --- a/app/views/entry/bookmark.phtml +++ b/app/views/entry/bookmark.phtml @@ -4,7 +4,7 @@ header('Content-Type: application/json; charset=UTF-8'); $url = array( 'c' => Minz_Request::controllerName(), 'a' => Minz_Request::actionName(), - 'params' => Minz_Request::fetchGET(), + 'params' => $_GET, ); $url['params']['is_favorite'] = Minz_Request::param('is_favorite', true) ? '0' : '1'; diff --git a/app/views/helpers/logs_pagination.phtml b/app/views/helpers/logs_pagination.phtml index e74074173..fa69d0b44 100755 --- a/app/views/helpers/logs_pagination.phtml +++ b/app/views/helpers/logs_pagination.phtml @@ -1,7 +1,7 @@ <?php $c = Minz_Request::controllerName(); $a = Minz_Request::actionName(); - $params = Minz_Request::fetchGET(); + $params = $_GET; ?> <?php if ($this->nbPage > 1) { ?> diff --git a/app/views/index/global.phtml b/app/views/index/global.phtml index 4323e3849..5b7e886e8 100644 --- a/app/views/index/global.phtml +++ b/app/views/index/global.phtml @@ -11,7 +11,7 @@ <main id="stream" class="global<?= $class ?>"> <?php - $params = Minz_Request::fetchGET(); + $params = $_GET; unset($params['c']); unset($params['a']); $url_base = array( |