diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2023-03-26 23:19:41 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-03-26 23:19:41 +0200 |
| commit | f3af3f0f3d4da8023c5e918545d47a51afc4b6c1 (patch) | |
| tree | 4d2f4e92b45c3f627949f390d9ab0f48adceff71 /app | |
| parent | 05e10f0e757bcb381e84ad3b2dccd2738e29ff08 (diff) | |
Automated test towards PHPStan level 6 (#5230)
* Automated test towards PHPStan level 6
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4112
With this automated tests, files that are passing Level 6 are tested to avoid regressions towards Level 5 (which is the current baseline for the whole code-base)
It is included when calling `make test-all` or can be called specifically by `composer run-script phpstan-next`
* Test and example with 3 new passing files
Diffstat (limited to 'app')
| -rw-r--r-- | app/Models/SystemConfiguration.php | 2 | ||||
| -rw-r--r-- | app/Models/UserConfiguration.php | 3 | ||||
| -rwxr-xr-x | app/actualize_script.php | 2 | ||||
| -rw-r--r-- | app/views/helpers/export/opml.phtml | 3 |
4 files changed, 6 insertions, 4 deletions
diff --git a/app/Models/SystemConfiguration.php b/app/Models/SystemConfiguration.php index 9fc79969d..2eed1f02a 100644 --- a/app/Models/SystemConfiguration.php +++ b/app/Models/SystemConfiguration.php @@ -27,7 +27,7 @@ */ final class FreshRSS_SystemConfiguration extends Minz_Configuration { - public static function init($config_filename, $default_filename = null): FreshRSS_SystemConfiguration { + public static function init(string $config_filename, ?string $default_filename = null): FreshRSS_SystemConfiguration { parent::register('system', $config_filename, $default_filename); return parent::get('system'); } diff --git a/app/Models/UserConfiguration.php b/app/Models/UserConfiguration.php index f539268ae..77e1d2821 100644 --- a/app/Models/UserConfiguration.php +++ b/app/Models/UserConfiguration.php @@ -71,7 +71,8 @@ */ final class FreshRSS_UserConfiguration extends Minz_Configuration { - public static function init($config_filename, $default_filename = null, $configuration_setter = null): FreshRSS_UserConfiguration { + public static function init(string $config_filename, ?string $default_filename = null, + ?FreshRSS_ConfigurationSetter $configuration_setter = null): FreshRSS_UserConfiguration { parent::register('user', $config_filename, $default_filename, $configuration_setter); return parent::get('user'); } diff --git a/app/actualize_script.php b/app/actualize_script.php index bad466e64..8e445b1e7 100755 --- a/app/actualize_script.php +++ b/app/actualize_script.php @@ -25,7 +25,7 @@ define('SIMPLEPIE_SYSLOG_ENABLED', FreshRSS_Context::$system_conf->simplepie_sys * Writes to FreshRSS admin log, and if it is not already done by default, * writes to syslog (only if simplepie_syslog_enabled in FreshRSS configuration) and to STDOUT */ -function notice($message) { +function notice(string $message): void { Minz_Log::notice($message, ADMIN_LOG); // @phpstan-ignore-next-line if (!COPY_LOG_TO_SYSLOG && SIMPLEPIE_SYSLOG_ENABLED) { diff --git a/app/views/helpers/export/opml.phtml b/app/views/helpers/export/opml.phtml index 64c83c960..64dc18eba 100644 --- a/app/views/helpers/export/opml.phtml +++ b/app/views/helpers/export/opml.phtml @@ -2,8 +2,9 @@ /** * @param array<FreshRSS_Feed> $feeds + * @return array<array<string,string|null>> */ -function feedsToOutlines($feeds, $excludeMutedFeeds = false): array { +function feedsToOutlines($feeds, bool $excludeMutedFeeds = false): array { $outlines = []; foreach ($feeds as $feed) { if ($feed->mute() && $excludeMutedFeeds) { |