diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2024-07-09 15:57:26 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-07-09 15:57:26 +0200 |
| commit | 0f395dad43bb0ab7c2e7ac5751776e9aeeb42036 (patch) | |
| tree | 273a62050a1aca5125d607b7add9674a86cf3b85 /cli/CliOptionsParser.php | |
| parent | d56d791bafa5cdbe23067d01b92cd690e7ccb6cf (diff) | |
Initial support for PHP 8.4 (#6615)
* Initial support for PHP 8.4
Sole fix needed so far seems to be related to https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
See also upstream PR https://github.com/PhpGt/CssXPath/pull/227
We are also hitting was seems to be a PHP bug https://github.com/php/php-src/issues/14873
* Fix return type
* Disable OPCache while waiting for PHP fix
Diffstat (limited to 'cli/CliOptionsParser.php')
| -rw-r--r-- | cli/CliOptionsParser.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cli/CliOptionsParser.php b/cli/CliOptionsParser.php index f75f6c19a..9fb50a4ff 100644 --- a/cli/CliOptionsParser.php +++ b/cli/CliOptionsParser.php @@ -43,7 +43,7 @@ abstract class CliOptionsParser { * @param string $defaultInput If not null this value is received as input in all cases where no * user input is present. e.g. set this if you want an option to always return a value. */ - protected function addOption(string $name, CliOption $option, string $defaultInput = null): void { + protected function addOption(string $name, CliOption $option, ?string $defaultInput = null): void { $this->inputs[$name] = [ 'defaultInput' => is_string($defaultInput) ? [$defaultInput] : $defaultInput, 'required' => null, |