diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2022-01-04 13:59:09 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-01-04 13:59:09 +0100 |
| commit | 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef (patch) | |
| tree | ed6a8d17cef0581e5b0402dc8dfedd42fabfe9c7 /cli/i18n | |
| parent | 0988b0c2be911133f883313bc3a858670192cc69 (diff) | |
PHPStan level 5 (#4110)
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
* PHPStan level 3
* PHPStand level 4
* Update default to PHPStan level 4
* Towards level 5
* Fix level 4 regression
* Towards level 5
* Pass PHPStan level 5
* Towards level 6
* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
Diffstat (limited to 'cli/i18n')
| -rw-r--r-- | cli/i18n/I18nCompletionValidator.php | 3 | ||||
| -rw-r--r-- | cli/i18n/I18nData.php | 2 | ||||
| -rw-r--r-- | cli/i18n/I18nValidatorInterface.php | 2 |
3 files changed, 5 insertions, 2 deletions
diff --git a/cli/i18n/I18nCompletionValidator.php b/cli/i18n/I18nCompletionValidator.php index 2cb71acd5..3287a2500 100644 --- a/cli/i18n/I18nCompletionValidator.php +++ b/cli/i18n/I18nCompletionValidator.php @@ -23,6 +23,9 @@ class I18nCompletionValidator implements I18nValidatorInterface { return $this->result; } + /** + * @param array<string>|null $ignore + */ public function validate($ignore) { foreach ($this->reference as $file => $data) { foreach ($data as $key => $value) { diff --git a/cli/i18n/I18nData.php b/cli/i18n/I18nData.php index 7e17c6c3c..2e5e373f8 100644 --- a/cli/i18n/I18nData.php +++ b/cli/i18n/I18nData.php @@ -130,7 +130,7 @@ class I18nData { if (array_key_exists($language, $this->data)) { throw new Exception('The selected language already exist.'); } - if (!is_string($reference) && !array_key_exists($reference, $this->data)) { + if (!is_string($reference) || !array_key_exists($reference, $this->data)) { $reference = static::REFERENCE_LANGUAGE; } $this->data[$language] = $this->data[$reference]; diff --git a/cli/i18n/I18nValidatorInterface.php b/cli/i18n/I18nValidatorInterface.php index edfe7aac0..80fcb22ad 100644 --- a/cli/i18n/I18nValidatorInterface.php +++ b/cli/i18n/I18nValidatorInterface.php @@ -19,7 +19,7 @@ interface I18nValidatorInterface { /** * Display the validation report. * - * @return array + * @return string */ public function displayReport(); |