diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2024-01-15 10:36:30 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2024-01-15 10:36:30 +0100 |
| commit | 314077a457f04cc2f0472e036af029e2676fbf02 (patch) | |
| tree | 1f38bb78761a56b8ee2034caba0dbda3912ef7c1 /lib/Minz/Url.php | |
| parent | 52f6c8399b41e0c8be49dd56c89f451843189791 (diff) | |
PHPStan prepare exceptions (#6037)
Take advantage of
https://phpstan.org/blog/bring-your-exceptions-under-control
Minimum changes to pass `tooWideThrowType` and `implicitThrows`.
Revert some mistakes from:
https://github.com/FreshRSS/FreshRSS/pull/5504
Preparation needed before new PRs of the same type:
https://github.com/FreshRSS/FreshRSS/pull/5962
Fix several wrong PHPDocs and catches:
> Method ... has ...Exception in PHPDoc @throws tag but it's not thrown.
> Dead catch - ...Exception is never thrown in the try block.
Diffstat (limited to 'lib/Minz/Url.php')
| -rw-r--r-- | lib/Minz/Url.php | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/lib/Minz/Url.php b/lib/Minz/Url.php index 2104759cd..67b927f05 100644 --- a/lib/Minz/Url.php +++ b/lib/Minz/Url.php @@ -15,6 +15,7 @@ class Minz_Url { * @param string $encoding how to encode & (& ou & pour html) * @param bool|string $absolute * @return string Formatted URL + * @throws Minz_ConfigurationException */ public static function display($url = [], string $encoding = 'html', $absolute = false): string { $isArray = is_array($url); @@ -140,13 +141,9 @@ class Minz_Url { * @return array<string,string|array<string,string>> */ public static function unserialize(string $url = ''): array { - try { - $result = json_decode(base64_decode($url, true) ?: '', true, JSON_THROW_ON_ERROR) ?? []; - /** @var array{'c'?:string,'a'?:string,'params'?:array<string,mixed>} $result */ - return $result; - } catch (\Throwable $exception) { - return []; - } + $result = json_decode(base64_decode($url, true) ?: '', true, JSON_THROW_ON_ERROR) ?? []; + /** @var array{'c'?:string,'a'?:string,'params'?:array<string,mixed>} $result */ + return $result; } /** |