aboutsummaryrefslogtreecommitdiff
path: root/lib/favicons.php
diff options
context:
space:
mode:
authorGravatar Luc SANCHEZ <4697568+ColonelMoutarde@users.noreply.github.com> 2023-11-16 22:43:00 +0100
committerGravatar GitHub <noreply@github.com> 2023-11-16 22:43:00 +0100
commit30c7a61a9b410f023c56ef19b9389a61647d8768 (patch)
treebb58408980ce5b86f1d2b4a9be29d55b2d46dbb1 /lib/favicons.php
parentee99e7e2cc228500efc1b539954c0ca6cd4c146d (diff)
Use strict_types (#5830)
* Little's optimisations and booleans in conditions * Apply strict type * Apply strict type * Apply strict type * Fix multiple bugs with PHP 8.2 and 8.3 * Many declares missing, more errors fixed * Apply strict type * Another approach * Stronger typing for Minz_Session * Fix case of SQLite --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Diffstat (limited to 'lib/favicons.php')
-rw-r--r--lib/favicons.php8
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/favicons.php b/lib/favicons.php
index b161215b2..5cf4295f5 100644
--- a/lib/favicons.php
+++ b/lib/favicons.php
@@ -1,4 +1,6 @@
<?php
+declare(strict_types=1);
+
const FAVICONS_DIR = DATA_PATH . '/favicons/';
const DEFAULT_FAVICON = PUBLIC_PATH . '/themes/icons/default_favicon.ico';
@@ -99,8 +101,12 @@ function searchFavicon(string &$url): string {
}
$href = SimplePie_IRI::absolutize($baseUrl, $href);
+ if ($href == false) {
+ return '';
+ }
- $favicon = downloadHttp($href, array(CURLOPT_REFERER => $url));
+ $iri = $href->get_iri();
+ $favicon = downloadHttp($iri, array(CURLOPT_REFERER => $url));
if (isImgMime($favicon)) {
return $favicon;
}