diff options
| author | 2024-01-15 10:36:30 +0100 | |
|---|---|---|
| committer | 2024-01-15 10:36:30 +0100 | |
| commit | 314077a457f04cc2f0472e036af029e2676fbf02 (patch) | |
| tree | 1f38bb78761a56b8ee2034caba0dbda3912ef7c1 /lib/favicons.php | |
| parent | 52f6c8399b41e0c8be49dd56c89f451843189791 (diff) | |
PHPStan prepare exceptions (#6037)
Take advantage of
https://phpstan.org/blog/bring-your-exceptions-under-control
Minimum changes to pass `tooWideThrowType` and `implicitThrows`.
Revert some mistakes from:
https://github.com/FreshRSS/FreshRSS/pull/5504
Preparation needed before new PRs of the same type:
https://github.com/FreshRSS/FreshRSS/pull/5962
Fix several wrong PHPDocs and catches:
> Method ... has ...Exception in PHPDoc @throws tag but it's not thrown.
> Dead catch - ...Exception is never thrown in the try block.
Diffstat (limited to 'lib/favicons.php')
| -rw-r--r-- | lib/favicons.php | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/lib/favicons.php b/lib/favicons.php index df893b309..48b649c28 100644 --- a/lib/favicons.php +++ b/lib/favicons.php @@ -13,16 +13,12 @@ function isImgMime(string $content): bool { return true; } $isImage = true; - try { - /** @var finfo $fInfo */ - $fInfo = finfo_open(FILEINFO_MIME_TYPE); - /** @var string $content */ - $content = finfo_buffer($fInfo, $content); - $isImage = strpos($content, 'image') !== false; - finfo_close($fInfo); - } catch (Exception $e) { - syslog(LOG_WARNING, 'FreshRSS favicon error: ' . $e->getMessage()); - } + /** @var finfo $fInfo */ + $fInfo = finfo_open(FILEINFO_MIME_TYPE); + /** @var string $content */ + $content = finfo_buffer($fInfo, $content); + $isImage = strpos($content, 'image') !== false; + finfo_close($fInfo); return $isImage; } |
