diff options
| author |  Alexandre Alapetite <alexandre@alapetite.fr>
| 2022-01-04 13:59:09 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2022-01-04 13:59:09 +0100 |
| commit | 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef (patch) | |
| tree | ed6a8d17cef0581e5b0402dc8dfedd42fabfe9c7 /lib/http-conditional.php | |
| parent | 0988b0c2be911133f883313bc3a858670192cc69 (diff) | |
PHPStan level 5 (#4110)
* Fix most PHPDocs errors
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
https://phpstan.org/writing-php-code/phpdoc-types
* Avoid func_get_args
Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list
And avoid dynamic functions names when possible to more easily identify calls and unused functions.
Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103
* PHPStan level 3
* PHPStand level 4
* Update default to PHPStan level 4
* Towards level 5
* Fix level 4 regression
* Towards level 5
* Pass PHPStan level 5
* Towards level 6
* Remove erronenous regression from changelog
https://github.com/FreshRSS/FreshRSS/pull/4116
Diffstat (limited to 'lib/http-conditional.php')
| -rw-r--r-- | lib/http-conditional.php | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/http-conditional.php b/lib/http-conditional.php index 6d3a0a97f..ad920455d 100644 --- a/lib/http-conditional.php +++ b/lib/http-conditional.php @@ -93,12 +93,14 @@ function httpConditional($UnixTimeStamp,$cacheSeconds=0,$cachePrivacy=0,$feedMod } $etagServer='"'.md5($scriptName.$myQuery.'#'.$dateLastModif).'"'; + // @phpstan-ignore-next-line if ((!$is412)&&isset($_SERVER['HTTP_IF_MATCH'])) {//rfc2616-sec14.html#sec14.24 $etagsClient=stripslashes($_SERVER['HTTP_IF_MATCH']); $etagsClient=str_ireplace('-gzip','',$etagsClient); $is412=(($etagsClient!=='*')&&(strpos($etagsClient,$etagServer)===false)); } + // @phpstan-ignore-next-line if ($is304&&isset($_SERVER['HTTP_IF_MODIFIED_SINCE'])) {//rfc2616-sec14.html#sec14.25 //rfc1945.txt $nbCond++; |