Pass PHPStan level 9 (#6544)

* More PHPStan

* More, passing

* 4 more files

* Update to PHPStan 1.11.4
Needed for fixed bug: Consider numeric-string types after string concat
https://github.com/phpstan/phpstan/releases/tag/1.11.4

* Pass PHPStan level 9
Start tracking booleansInConditions

* Fix mark as read

* Fix doctype

* ctype_digit

1 files changed, 6 insertions, 1 deletions

diff --git a/p/api/fever.php b/p/api/fever.php
index 9f4766c9e..ec5af189f 100644
--- a/p/api/fever.php
+++ b/p/api/fever.php
@@ -407,7 +407,7 @@ final class FeverAPI
 	}
 
 	/**
-	 * @param array<string> $ids
+	 * @param array<numeric-string> $ids
 	 */
 	private function entriesToIdList(array $ids = []): string {
 		return implode(',', array_values($ids));
@@ -424,6 +424,7 @@ final class FeverAPI
 	}
 
 	/**
+	 * @param numeric-string $id
 	 * @return int|false
 	 */
 	private function setItemAsRead(string $id) {
@@ -431,6 +432,7 @@ final class FeverAPI
 	}
 
 	/**
+	 * @param numeric-string $id
 	 * @return int|false
 	 */
 	private function setItemAsUnread(string $id) {
@@ -438,6 +440,7 @@ final class FeverAPI
 	}
 
 	/**
+	 * @param numeric-string $id
 	 * @return int|false
 	 */
 	private function setItemAsSaved(string $id) {
@@ -445,6 +448,7 @@ final class FeverAPI
 	}
 
 	/**
+	 * @param numeric-string $id
 	 * @return int|false
 	 */
 	private function setItemAsUnsaved(string $id) {
@@ -527,6 +531,7 @@ final class FeverAPI
 
 	/**
 	 * TODO replace by a dynamic fetch for id <= $before timestamp
+	 * @return numeric-string
 	 */
 	private function convertBeforeToId(int $beforeTimestamp): string {
 		return $beforeTimestamp == 0 ? '0' : $beforeTimestamp . '000000';