diff options
| author | 2023-05-11 13:02:04 +0200 | |
|---|---|---|
| committer | 2023-05-11 13:02:04 +0200 | |
| commit | 6e2f2f1c1e98ecd86aa89c6547beb742d7385d18 (patch) | |
| tree | 7ba9f5aebb01d12045b9067a86b5060ba13dca18 /tests/cli | |
| parent | fe7d9bbcd68660a59b813346c236b61b25a51c80 (diff) | |
A few additional PHPStan rules (#5388)
A subset of
https://github.com/phpstan/phpstan-strict-rules
Diffstat (limited to 'tests/cli')
| -rw-r--r-- | tests/cli/i18n/I18nCompletionValidatorTest.php | 38 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nDataTest.php | 132 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nFileTest.php | 4 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nUsageValidatorTest.php | 32 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nValueTest.php | 60 |
5 files changed, 133 insertions, 133 deletions
diff --git a/tests/cli/i18n/I18nCompletionValidatorTest.php b/tests/cli/i18n/I18nCompletionValidatorTest.php index 1a361823d..3c6fc99eb 100644 --- a/tests/cli/i18n/I18nCompletionValidatorTest.php +++ b/tests/cli/i18n/I18nCompletionValidatorTest.php @@ -16,23 +16,23 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { public function testDisplayReport(): void { $validator = new I18nCompletionValidator([], []); - $this->assertEquals("There is no data.\n", $validator->displayReport()); + self::assertEquals("There is no data.\n", $validator->displayReport()); $reflectionTotalEntries = new ReflectionProperty(I18nCompletionValidator::class, 'totalEntries'); $reflectionTotalEntries->setAccessible(true); $reflectionTotalEntries->setValue($validator, 100); - $this->assertEquals("Translation is 0.0% complete.\n", $validator->displayReport()); + self::assertEquals("Translation is 0.0% complete.\n", $validator->displayReport()); $reflectionPassEntries = new ReflectionProperty(I18nCompletionValidator::class, 'passEntries'); $reflectionPassEntries->setAccessible(true); $reflectionPassEntries->setValue($validator, 25); - $this->assertEquals("Translation is 25.0% complete.\n", $validator->displayReport()); + self::assertEquals("Translation is 25.0% complete.\n", $validator->displayReport()); $reflectionPassEntries->setValue($validator, 100); - $this->assertEquals("Translation is 100.0% complete.\n", $validator->displayReport()); + self::assertEquals("Translation is 100.0% complete.\n", $validator->displayReport()); $reflectionPassEntries->setValue($validator, 200); @@ -43,8 +43,8 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { public function testValidateWhenNoData(): void { $validator = new I18nCompletionValidator([], []); - $this->assertTrue($validator->validate()); - $this->assertEquals('', $validator->displayResult()); + self::assertTrue($validator->validate()); + self::assertEquals('', $validator->displayResult()); } public function testValidateWhenKeyIsMissing(): void { @@ -57,12 +57,12 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ], ], []); - $this->assertFalse($validator->validate()); - $this->assertEquals("Missing key file1.l1.l2.k1\nMissing key file2.l1.l2.k1\n", $validator->displayResult()); + self::assertFalse($validator->validate()); + self::assertEquals("Missing key file1.l1.l2.k1\nMissing key file2.l1.l2.k1\n", $validator->displayResult()); } public function testValidateWhenKeyIsIgnored(): void { - $this->value->expects($this->exactly(2)) + $this->value->expects(self::exactly(2)) ->method('isIgnore') ->willReturn(true); @@ -82,15 +82,15 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ], ]); - $this->assertTrue($validator->validate()); - $this->assertEquals('', $validator->displayResult()); + self::assertTrue($validator->validate()); + self::assertEquals('', $validator->displayResult()); } public function testValidateWhenValueIsEqual(): void { - $this->value->expects($this->exactly(2)) + $this->value->expects(self::exactly(2)) ->method('isIgnore') ->willReturn(false); - $this->value->expects($this->exactly(2)) + $this->value->expects(self::exactly(2)) ->method('equal') ->willReturn(true); @@ -110,15 +110,15 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ], ]); - $this->assertFalse($validator->validate()); - $this->assertEquals("Untranslated key file1.l1.l2.k1 - \nUntranslated key file2.l1.l2.k1 - \n", $validator->displayResult()); + self::assertFalse($validator->validate()); + self::assertEquals("Untranslated key file1.l1.l2.k1 - \nUntranslated key file2.l1.l2.k1 - \n", $validator->displayResult()); } public function testValidateWhenValueIsDifferent(): void { - $this->value->expects($this->exactly(2)) + $this->value->expects(self::exactly(2)) ->method('isIgnore') ->willReturn(false); - $this->value->expects($this->exactly(2)) + $this->value->expects(self::exactly(2)) ->method('equal') ->willReturn(false); @@ -138,7 +138,7 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ], ]); - $this->assertTrue($validator->validate()); - $this->assertEquals('', $validator->displayResult()); + self::assertTrue($validator->validate()); + self::assertEquals('', $validator->displayResult()); } } diff --git a/tests/cli/i18n/I18nDataTest.php b/tests/cli/i18n/I18nDataTest.php index 37811c193..fda4a4734 100644 --- a/tests/cli/i18n/I18nDataTest.php +++ b/tests/cli/i18n/I18nDataTest.php @@ -35,7 +35,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testConstructWhenReferenceOnly(): void { $data = new I18nData($this->referenceData); - $this->assertEquals($this->referenceData, $data->getData()); + self::assertEquals($this->referenceData, $data->getData()); } public function testConstructorWhenLanguageIsMissingFile(): void { @@ -47,7 +47,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ], ]); $data = new I18nData($rawData); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -93,7 +93,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ], ]); $data = new I18nData($rawData); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -147,7 +147,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ], ]); $data = new I18nData($rawData); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -185,12 +185,12 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $value = $this->getMockBuilder(I18nValue::class) ->disableOriginalConstructor() ->getMock(); - $value->expects($this->exactly(2)) + $value->expects(self::exactly(2)) ->method('isIgnore') ->willReturn(true); - $value->expects($this->never()) + $value->expects(self::never()) ->method('markAsTodo'); - $value->expects($this->exactly(3)) + $value->expects(self::exactly(3)) ->method('equal') ->with($value) ->willReturn(true); @@ -210,12 +210,12 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $value = $this->getMockBuilder(I18nValue::class) ->disableOriginalConstructor() ->getMock(); - $value->expects($this->exactly(2)) + $value->expects(self::exactly(2)) ->method('isIgnore') ->willReturn(false); - $value->expects($this->exactly(2)) + $value->expects(self::exactly(2)) ->method('markAsTodo'); - $value->expects($this->exactly(2)) + $value->expects(self::exactly(2)) ->method('equal') ->with($value) ->willReturn(true); @@ -235,10 +235,10 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $value = $this->getMockBuilder(I18nValue::class) ->disableOriginalConstructor() ->getMock(); - $value->expects($this->once()) + $value->expects(self::once()) ->method('isTodo') ->willReturn(true); - $value->expects($this->once()) + $value->expects(self::once()) ->method('markAsDirty'); $rawData = array_merge($this->referenceData, [ @@ -255,10 +255,10 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $value = $this->getMockBuilder(I18nValue::class) ->disableOriginalConstructor() ->getMock(); - $value->expects($this->once()) + $value->expects(self::once()) ->method('isTodo') ->willReturn(false); - $value->expects($this->never()) + $value->expects(self::never()) ->method('markAsDirty'); $rawData = array_merge($this->referenceData, [ @@ -277,7 +277,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'nl' => [], ]); $data = new I18nData($rawData); - $this->assertEquals([ + self::assertEquals([ 'en', 'fr', 'nl', @@ -291,7 +291,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'de' => [], ]); $data = new I18nData($rawData); - $this->assertEquals([ + self::assertEquals([ 'de', 'en', 'fr', @@ -309,7 +309,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testAddLanguageWhenNoReferenceProvided(): void { $data = new I18nData($this->referenceData); $data->addLanguage('fr'); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -346,7 +346,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testAddLanguageWhenUnknownReferenceProvided(): void { $data = new I18nData($this->referenceData); $data->addLanguage('fr', 'unknown'); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -383,7 +383,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testAddLanguageWhenKnownReferenceProvided(): void { $data = new I18nData($this->referenceData); $data->addLanguage('fr', 'en'); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -419,12 +419,12 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testIsKnownWhenKeyExists(): void { $data = new I18nData($this->referenceData); - $this->assertTrue($data->isKnown('file2.l1.l2.k2')); + self::assertTrue($data->isKnown('file2.l1.l2.k2')); } public function testIsKnownWhenKeyDoesNotExist(): void { $data = new I18nData($this->referenceData); - $this->assertFalse($data->isKnown('file2.l1.l2.k3')); + self::assertFalse($data->isKnown('file2.l1.l2.k3')); } public function testAddKeyWhenKeyExists(): void { @@ -440,13 +440,13 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ]); $data = new I18nData($rawData); - $this->assertTrue($data->isKnown('file2.l1.l2.k1')); - $this->assertFalse($data->isKnown('file2.l1.l2.k1._')); - $this->assertFalse($data->isKnown('file2.l1.l2.k1.sk1')); + self::assertTrue($data->isKnown('file2.l1.l2.k1')); + self::assertFalse($data->isKnown('file2.l1.l2.k1._')); + self::assertFalse($data->isKnown('file2.l1.l2.k1.sk1')); $data->addKey('file2.l1.l2.k1.sk1', 'value'); - $this->assertFalse($data->isKnown('file2.l1.l2.k1')); - $this->assertTrue($data->isKnown('file2.l1.l2.k1._')); - $this->assertTrue($data->isKnown('file2.l1.l2.k1.sk1')); + self::assertFalse($data->isKnown('file2.l1.l2.k1')); + self::assertTrue($data->isKnown('file2.l1.l2.k1._')); + self::assertTrue($data->isKnown('file2.l1.l2.k1.sk1')); } public function testAddKeyWhenKeyIsParent(): void { @@ -455,13 +455,13 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ]); $data = new I18nData($rawData); - $this->assertFalse($data->isKnown('file1.l1.l2._')); - $this->assertTrue($data->isKnown('file1.l1.l2.k1')); - $this->assertTrue($data->isKnown('file1.l1.l2.k2')); + self::assertFalse($data->isKnown('file1.l1.l2._')); + self::assertTrue($data->isKnown('file1.l1.l2.k1')); + self::assertTrue($data->isKnown('file1.l1.l2.k2')); $data->addKey('file1.l1.l2', 'value'); - $this->assertTrue($data->isKnown('file1.l1.l2._')); - $this->assertTrue($data->isKnown('file1.l1.l2.k1')); - $this->assertTrue($data->isKnown('file1.l1.l2.k2')); + self::assertTrue($data->isKnown('file1.l1.l2._')); + self::assertTrue($data->isKnown('file1.l1.l2.k1')); + self::assertTrue($data->isKnown('file1.l1.l2.k2')); } public function testAddKey(): void { @@ -474,16 +474,16 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ]); $data = new I18nData($rawData); - $this->assertFalse($data->isKnown('file2.l1.l2.k3')); + self::assertFalse($data->isKnown('file2.l1.l2.k3')); $data->addKey('file2.l1.l2.k3', 'value'); - $this->assertTrue($data->isKnown('file2.l1.l2.k3')); + self::assertTrue($data->isKnown('file2.l1.l2.k3')); $enValue = $getTargetedValue($data, 'en'); $frValue = $getTargetedValue($data, 'fr'); - $this->assertInstanceOf(I18nValue::class, $enValue); - $this->assertEquals('value', $enValue->getValue()); - $this->assertTrue($enValue->isTodo()); - $this->assertEquals($frValue, $enValue); + self::assertInstanceOf(I18nValue::class, $enValue); + self::assertEquals('value', $enValue->getValue()); + self::assertTrue($enValue->isTodo()); + self::assertEquals($frValue, $enValue); } public function testAddValueWhenLanguageDoesNotExist(): void { @@ -505,7 +505,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { return $data->getData()[$language]['file2.php']['file2.l1.l2.k2']; }; - $this->value->expects($this->atLeast(2)) + $this->value->expects(self::atLeast(2)) ->method('equal') ->with($this->value) ->willReturn(true); @@ -520,12 +520,12 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $afterEnValue = $getTargetedValue($data, 'en'); $afterFrValue = $getTargetedValue($data, 'fr'); - $this->assertEquals($this->value, $beforeEnValue); - $this->assertEquals($this->value, $beforeFrValue); - $this->assertInstanceOf(I18nValue::class, $afterEnValue); - $this->assertEquals('new value', $afterEnValue->getValue()); - $this->assertInstanceOf(I18nValue::class, $afterFrValue); - $this->assertEquals('new value', $afterFrValue->getValue()); + self::assertEquals($this->value, $beforeEnValue); + self::assertEquals($this->value, $beforeFrValue); + self::assertInstanceOf(I18nValue::class, $afterEnValue); + self::assertEquals('new value', $afterEnValue->getValue()); + self::assertInstanceOf(I18nValue::class, $afterFrValue); + self::assertEquals('new value', $afterFrValue->getValue()); } public function testAddValueWhenLanguageIsReferenceAndValueInOtherLanguageHasChange(): void { @@ -533,7 +533,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { return $data->getData()[$language]['file2.php']['file2.l1.l2.k2']; }; - $this->value->expects($this->any()) + $this->value->expects(self::any()) ->method('equal') ->with($this->value) ->willReturn(true); @@ -556,11 +556,11 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $afterEnValue = $getTargetedValue($data, 'en'); $afterFrValue = $getTargetedValue($data, 'fr'); - $this->assertEquals($this->value, $beforeEnValue); - $this->assertEquals($value, $beforeFrValue); - $this->assertInstanceOf(I18nValue::class, $afterEnValue); - $this->assertEquals('new value', $afterEnValue->getValue()); - $this->assertEquals($value, $afterFrValue); + self::assertEquals($this->value, $beforeEnValue); + self::assertEquals($value, $beforeFrValue); + self::assertInstanceOf(I18nValue::class, $afterEnValue); + self::assertEquals('new value', $afterEnValue->getValue()); + self::assertEquals($value, $afterFrValue); } public function testAddValueWhenLanguageIsNotReference(): void { @@ -578,11 +578,11 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $afterEnValue = $getTargetedValue($data, 'en'); $afterFrValue = $getTargetedValue($data, 'fr'); - $this->assertEquals($this->value, $beforeEnValue); - $this->assertEquals($this->value, $beforeFrValue); - $this->assertEquals($this->value, $afterEnValue); - $this->assertInstanceOf(I18nValue::class, $afterFrValue); - $this->assertEquals('new value', $afterFrValue->getValue()); + self::assertEquals($this->value, $beforeEnValue); + self::assertEquals($this->value, $beforeFrValue); + self::assertEquals($this->value, $afterEnValue); + self::assertInstanceOf(I18nValue::class, $afterFrValue); + self::assertEquals('new value', $afterFrValue->getValue()); } public function testRemoveKeyWhenKeyDoesNotExist(): void { @@ -605,7 +605,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ]); $data = new I18nData($rawData); $data->removeKey('file2.l1.l2'); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -643,7 +643,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { ]); $data = new I18nData($rawData); $data->removeKey('file3.l1.l2.k1'); - $this->assertEquals([ + self::assertEquals([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -679,9 +679,9 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $value = $this->getMockBuilder(I18nValue::class) ->disableOriginalConstructor() ->getMock(); - $value->expects($this->exactly(2)) + $value->expects(self::exactly(2)) ->method('unmarkAsIgnore'); - $value->expects($this->once()) + $value->expects(self::once()) ->method('markAsIgnore'); $rawData = array_merge($this->referenceData, [ @@ -701,12 +701,12 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $value = $this->getMockBuilder(I18nValue::class) ->disableOriginalConstructor() ->getMock(); - $value->expects($this->exactly(2)) + $value->expects(self::exactly(2)) ->method('unmarkAsIgnore'); - $value->expects($this->once()) + $value->expects(self::once()) ->method('markAsIgnore'); - $this->value->expects($this->atLeast(2)) + $this->value->expects(self::atLeast(2)) ->method('equal') ->with($value) ->willReturn(true); @@ -730,7 +730,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'nl' => [], ]); $data = new I18nData($rawData); - $this->assertEquals($this->referenceData['en'], $data->getLanguage('en')); + self::assertEquals($this->referenceData['en'], $data->getLanguage('en')); } public function testGetReferenceLanguage(): void { @@ -739,6 +739,6 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'nl' => [], ]); $data = new I18nData($rawData); - $this->assertEquals($this->referenceData['en'], $data->getReferenceLanguage()); + self::assertEquals($this->referenceData['en'], $data->getReferenceLanguage()); } } diff --git a/tests/cli/i18n/I18nFileTest.php b/tests/cli/i18n/I18nFileTest.php index d584fdd22..47464c2e2 100644 --- a/tests/cli/i18n/I18nFileTest.php +++ b/tests/cli/i18n/I18nFileTest.php @@ -12,7 +12,7 @@ class I18nFileTest extends PHPUnit\Framework\TestCase { $after = $this->computeFilesHash(); - $this->assertEquals($before, $after); + self::assertEquals($before, $after); } /** @return array<string,string|false> */ @@ -30,7 +30,7 @@ class I18nFileTest extends PHPUnit\Framework\TestCase { continue; } - $hashes[$file->getPathName()] = sha1_file($file->getPathName()); + $hashes[$file->getPathname()] = sha1_file($file->getPathname()); } } diff --git a/tests/cli/i18n/I18nUsageValidatorTest.php b/tests/cli/i18n/I18nUsageValidatorTest.php index fdd75bf64..163c0ce82 100644 --- a/tests/cli/i18n/I18nUsageValidatorTest.php +++ b/tests/cli/i18n/I18nUsageValidatorTest.php @@ -16,23 +16,23 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { public function testDisplayReport(): void { $validator = new I18nUsageValidator([], []); - $this->assertEquals("There is no data.\n", $validator->displayReport()); + self::assertEquals("There is no data.\n", $validator->displayReport()); $reflectionTotalEntries = new ReflectionProperty(I18nUsageValidator::class, 'totalEntries'); $reflectionTotalEntries->setAccessible(true); $reflectionTotalEntries->setValue($validator, 100); - $this->assertEquals(" 0.0% of translation keys are unused.\n", $validator->displayReport()); + self::assertEquals(" 0.0% of translation keys are unused.\n", $validator->displayReport()); $reflectionFailedEntries = new ReflectionProperty(I18nUsageValidator::class, 'failedEntries'); $reflectionFailedEntries->setAccessible(true); $reflectionFailedEntries->setValue($validator, 25); - $this->assertEquals(" 25.0% of translation keys are unused.\n", $validator->displayReport()); + self::assertEquals(" 25.0% of translation keys are unused.\n", $validator->displayReport()); $reflectionFailedEntries->setValue($validator, 100); - $this->assertEquals("100.0% of translation keys are unused.\n", $validator->displayReport()); + self::assertEquals("100.0% of translation keys are unused.\n", $validator->displayReport()); $reflectionFailedEntries->setValue($validator, 200); @@ -43,8 +43,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { public function testValidateWhenNoData(): void { $validator = new I18nUsageValidator([], []); - $this->assertTrue($validator->validate()); - $this->assertEquals('', $validator->displayResult()); + self::assertTrue($validator->validate()); + self::assertEquals('', $validator->displayResult()); } public function testValidateWhenParentKeyExistsWithoutTransformation(): void { @@ -59,8 +59,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file1.l1.l2._', 'file2.l1.l2._', ]); - $this->assertTrue($validator->validate()); - $this->assertEquals('', $validator->displayResult()); + self::assertTrue($validator->validate()); + self::assertEquals('', $validator->displayResult()); } public function testValidateWhenParentKeyExistsWithTransformation(): void { @@ -75,8 +75,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file1.l1.l2', 'file2.l1.l2', ]); - $this->assertTrue($validator->validate()); - $this->assertEquals('', $validator->displayResult()); + self::assertTrue($validator->validate()); + self::assertEquals('', $validator->displayResult()); } public function testValidateWhenParentKeyDoesNotExist(): void { @@ -88,8 +88,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file2.l1.l2._' => $this->value, ], ], []); - $this->assertFalse($validator->validate()); - $this->assertEquals("Unused key file1.l1.l2._ - \nUnused key file2.l1.l2._ - \n", $validator->displayResult()); + self::assertFalse($validator->validate()); + self::assertEquals("Unused key file1.l1.l2._ - \nUnused key file2.l1.l2._ - \n", $validator->displayResult()); } public function testValidateWhenChildKeyExists(): void { @@ -104,8 +104,8 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file1.l1.l2.k1', 'file2.l1.l2.k1', ]); - $this->assertTrue($validator->validate()); - $this->assertEquals('', $validator->displayResult()); + self::assertTrue($validator->validate()); + self::assertEquals('', $validator->displayResult()); } public function testValidateWhenChildKeyDoesNotExist(): void { @@ -117,7 +117,7 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file2.l1.l2.k1' => $this->value, ], ], []); - $this->assertFalse($validator->validate()); - $this->assertEquals("Unused key file1.l1.l2.k1 - \nUnused key file2.l1.l2.k1 - \n", $validator->displayResult()); + self::assertFalse($validator->validate()); + self::assertEquals("Unused key file1.l1.l2.k1 - \nUnused key file2.l1.l2.k1 - \n", $validator->displayResult()); } } diff --git a/tests/cli/i18n/I18nValueTest.php b/tests/cli/i18n/I18nValueTest.php index 7a1109a20..4454ea073 100644 --- a/tests/cli/i18n/I18nValueTest.php +++ b/tests/cli/i18n/I18nValueTest.php @@ -5,55 +5,55 @@ require_once __DIR__ . '/../../../cli/i18n/I18nValue.php'; class I18nValueTest extends PHPUnit\Framework\TestCase { public function testConstructorWithoutState(): void { $value = new I18nValue('some value'); - $this->assertEquals('some value', $value->getValue()); - $this->assertFalse($value->isIgnore()); - $this->assertFalse($value->isTodo()); + self::assertEquals('some value', $value->getValue()); + self::assertFalse($value->isIgnore()); + self::assertFalse($value->isTodo()); } public function testConstructorWithUnknownState(): void { $value = new I18nValue('some value -> unknown'); - $this->assertEquals('some value', $value->getValue()); - $this->assertFalse($value->isIgnore()); - $this->assertFalse($value->isTodo()); + self::assertEquals('some value', $value->getValue()); + self::assertFalse($value->isIgnore()); + self::assertFalse($value->isTodo()); } public function testConstructorWithTodoState(): void { $value = new I18nValue('some value -> todo'); - $this->assertEquals('some value', $value->getValue()); - $this->assertFalse($value->isIgnore()); - $this->assertTrue($value->isTodo()); + self::assertEquals('some value', $value->getValue()); + self::assertFalse($value->isIgnore()); + self::assertTrue($value->isTodo()); } public function testConstructorWithIgnoreState(): void { $value = new I18nValue('some value -> ignore'); - $this->assertEquals('some value', $value->getValue()); - $this->assertTrue($value->isIgnore()); - $this->assertFalse($value->isTodo()); + self::assertEquals('some value', $value->getValue()); + self::assertTrue($value->isIgnore()); + self::assertFalse($value->isTodo()); } public function testClone(): void { $value = new I18nValue('some value'); $clonedValue = clone $value; - $this->assertEquals('some value', $value->getValue()); - $this->assertEquals('some value', $clonedValue->getValue()); - $this->assertFalse($value->isIgnore()); - $this->assertFalse($clonedValue->isIgnore()); - $this->assertFalse($value->isTodo()); - $this->assertTrue($clonedValue->isTodo()); + self::assertEquals('some value', $value->getValue()); + self::assertEquals('some value', $clonedValue->getValue()); + self::assertFalse($value->isIgnore()); + self::assertFalse($clonedValue->isIgnore()); + self::assertFalse($value->isTodo()); + self::assertTrue($clonedValue->isTodo()); } public function testEqualWhenValueIsIdentical(): void { $value = new I18nValue('some value'); $clonedValue = clone $value; - $this->assertTrue($value->equal($clonedValue)); - $this->assertTrue($clonedValue->equal($value)); + self::assertTrue($value->equal($clonedValue)); + self::assertTrue($clonedValue->equal($value)); } public function testEqualWhenValueIsDifferent(): void { $value = new I18nValue('some value'); $otherValue = new I18nValue('some other value'); - $this->assertFalse($value->equal($otherValue)); - $this->assertFalse($otherValue->equal($value)); + self::assertFalse($value->equal($otherValue)); + self::assertFalse($otherValue->equal($value)); } public function testStates(): void { @@ -61,23 +61,23 @@ class I18nValueTest extends PHPUnit\Framework\TestCase { $reflectionProperty->setAccessible(true); $value = new I18nValue('some value'); - $this->assertNull($reflectionProperty->getValue($value)); + self::assertNull($reflectionProperty->getValue($value)); $value->markAsDirty(); - $this->assertEquals('dirty', $reflectionProperty->getValue($value)); + self::assertEquals('dirty', $reflectionProperty->getValue($value)); $value->unmarkAsIgnore(); - $this->assertEquals('dirty', $reflectionProperty->getValue($value)); + self::assertEquals('dirty', $reflectionProperty->getValue($value)); $value->markAsIgnore(); - $this->assertEquals('ignore', $reflectionProperty->getValue($value)); + self::assertEquals('ignore', $reflectionProperty->getValue($value)); $value->unmarkAsIgnore(); - $this->assertNull($reflectionProperty->getValue($value)); + self::assertNull($reflectionProperty->getValue($value)); $value->markAsTodo(); - $this->assertEquals('todo', $reflectionProperty->getValue($value)); + self::assertEquals('todo', $reflectionProperty->getValue($value)); } public function testToString(): void { $value = new I18nValue('some value'); - $this->assertEquals('some value', $value->__toString()); + self::assertEquals('some value', $value->__toString()); $value->markAsTodo(); - $this->assertEquals('some value -> todo', $value->__toString()); + self::assertEquals('some value -> todo', $value->__toString()); } } |
