diff options
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/app/Models/CategoryTest.php | 22 | ||||
| -rw-r--r-- | tests/app/Models/FeedDAOTest.php | 4 | ||||
| -rw-r--r-- | tests/app/Models/LogDAOTest.php | 9 | ||||
| -rw-r--r-- | tests/app/Models/SearchTest.php | 104 | ||||
| -rw-r--r-- | tests/app/Models/UserQueryTest.php | 22 | ||||
| -rw-r--r-- | tests/app/Utils/dotNotationUtilTest.php | 2 | ||||
| -rw-r--r-- | tests/cli/CliOptionsParserTest.php | 56 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nCompletionValidatorTest.php | 18 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nDataTest.php | 28 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nFileTest.php | 2 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nUsageValidatorTest.php | 20 | ||||
| -rw-r--r-- | tests/cli/i18n/I18nValueTest.php | 24 |
12 files changed, 155 insertions, 156 deletions
diff --git a/tests/app/Models/CategoryTest.php b/tests/app/Models/CategoryTest.php index f9aa1a280..70bed7477 100644 --- a/tests/app/Models/CategoryTest.php +++ b/tests/app/Models/CategoryTest.php @@ -7,17 +7,17 @@ class CategoryTest extends PHPUnit\Framework\TestCase { public static function test__construct_whenNoParameters_createsObjectWithDefaultValues(): void { $category = new FreshRSS_Category(); - self::assertEquals(0, $category->id()); - self::assertEquals('', $category->name()); + self::assertSame(0, $category->id()); + self::assertSame('', $category->name()); } #[DataProvider('provideValidNames')] public static function test_name_whenValidValue_storesModifiedValue(string $input, string $expected): void { $category = new FreshRSS_Category($input); - self::assertEquals($expected, $category->name()); + self::assertSame($expected, $category->name()); } - /** @return array<array{string,string}> */ + /** @return list<array{string,string}> */ public static function provideValidNames(): array { return [ ['', ''], @@ -60,11 +60,11 @@ class CategoryTest extends PHPUnit\Framework\TestCase { self::assertCount(3, $feeds); $feed = reset($feeds) ?: FreshRSS_Feed::default(); - self::assertEquals('AAA', $feed->name()); + self::assertSame('AAA', $feed->name()); $feed = next($feeds) ?: FreshRSS_Feed::default(); - self::assertEquals('lll', $feed->name()); + self::assertSame('lll', $feed->name()); $feed = next($feeds) ?: FreshRSS_Feed::default(); - self::assertEquals('ZZZ', $feed->name()); + self::assertSame('ZZZ', $feed->name()); /** @var FreshRSS_Feed&PHPUnit\Framework\MockObject\MockObject */ $feed_4 = $this->getMockBuilder(FreshRSS_Feed::class) @@ -79,12 +79,12 @@ class CategoryTest extends PHPUnit\Framework\TestCase { self::assertCount(4, $feeds); $feed = reset($feeds) ?: FreshRSS_Feed::default(); - self::assertEquals('AAA', $feed->name()); + self::assertSame('AAA', $feed->name()); $feed = next($feeds) ?: FreshRSS_Feed::default(); - self::assertEquals('BBB', $feed->name()); + self::assertSame('BBB', $feed->name()); $feed = next($feeds) ?: FreshRSS_Feed::default(); - self::assertEquals('lll', $feed->name()); + self::assertSame('lll', $feed->name()); $feed = next($feeds) ?: FreshRSS_Feed::default(); - self::assertEquals('ZZZ', $feed->name()); + self::assertSame('ZZZ', $feed->name()); } } diff --git a/tests/app/Models/FeedDAOTest.php b/tests/app/Models/FeedDAOTest.php index 31cfc57f9..2c7f6488f 100644 --- a/tests/app/Models/FeedDAOTest.php +++ b/tests/app/Models/FeedDAOTest.php @@ -5,7 +5,7 @@ class FeedDAOTest extends PHPUnit\Framework\TestCase { public static function test_ttl_min(): void { $feed = new FreshRSS_Feed('https://example.net/', false); $feed->_ttl(-5); - self::assertEquals(-5, $feed->ttl(true)); - self::assertEquals(true, $feed->mute()); + self::assertSame(-5, $feed->ttl(true)); + self::assertTrue($feed->mute()); } } diff --git a/tests/app/Models/LogDAOTest.php b/tests/app/Models/LogDAOTest.php index 90261ae55..1950a12c8 100644 --- a/tests/app/Models/LogDAOTest.php +++ b/tests/app/Models/LogDAOTest.php @@ -22,15 +22,14 @@ class LogDAOTest extends TestCase { } public function test_lines_is_array_and_truncate_function_work(): void { - self::assertEquals(USERS_PATH . '/' . Minz_User::INTERNAL_USER . '/' . self::LOG_FILE_TEST, $this->logPath); + self::assertSame(USERS_PATH . '/' . Minz_User::INTERNAL_USER . '/' . self::LOG_FILE_TEST, $this->logPath); $line = $this->logDAO::lines(self::LOG_FILE_TEST); self::assertCount(1, $line); - self::assertInstanceOf(FreshRSS_Log::class, $line[0]); - self::assertEquals('Wed, 08 Feb 2023 15:35:05 +0000', $line[0]->date()); - self::assertEquals('notice', $line[0]->level()); - self::assertEquals("Migration 2019_12_22_FooBar: OK", $line[0]->info()); + self::assertSame('Wed, 08 Feb 2023 15:35:05 +0000', $line[0]->date()); + self::assertSame('notice', $line[0]->level()); + self::assertSame("Migration 2019_12_22_FooBar: OK", $line[0]->info()); $this->logDAO::truncate(self::LOG_FILE_TEST); diff --git a/tests/app/Models/SearchTest.php b/tests/app/Models/SearchTest.php index 04da65d3a..81b4ac1fb 100644 --- a/tests/app/Models/SearchTest.php +++ b/tests/app/Models/SearchTest.php @@ -10,7 +10,7 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideEmptyInput')] public static function test__construct_whenInputIsEmpty_getsOnlyNullValues(string $input): void { $search = new FreshRSS_Search($input); - self::assertEquals('', $search->getRawInput()); + self::assertSame('', $search->getRawInput()); self::assertNull($search->getIntitle()); self::assertNull($search->getMinDate()); self::assertNull($search->getMaxDate()); @@ -40,12 +40,12 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideIntitleSearch')] public static function test__construct_whenInputContainsIntitle_setsIntitleProperty(string $input, ?array $intitle_value, ?array $search_value): void { $search = new FreshRSS_Search($input); - self::assertEquals($intitle_value, $search->getIntitle()); - self::assertEquals($search_value, $search->getSearch()); + self::assertSame($intitle_value, $search->getIntitle()); + self::assertSame($search_value, $search->getSearch()); } /** - * @return array<array<mixed>> + * @return list<list<mixed>> */ public static function provideIntitleSearch(): array { return [ @@ -77,12 +77,12 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideAuthorSearch')] public static function test__construct_whenInputContainsAuthor_setsAuthorValue(string $input, ?array $author_value, ?array $search_value): void { $search = new FreshRSS_Search($input); - self::assertEquals($author_value, $search->getAuthor()); - self::assertEquals($search_value, $search->getSearch()); + self::assertSame($author_value, $search->getAuthor()); + self::assertSame($search_value, $search->getSearch()); } /** - * @return array<array<mixed>> + * @return list<list<mixed>> */ public static function provideAuthorSearch(): array { return [ @@ -114,12 +114,12 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideInurlSearch')] public static function test__construct_whenInputContainsInurl_setsInurlValue(string $input, ?array $inurl_value, ?array $search_value): void { $search = new FreshRSS_Search($input); - self::assertEquals($inurl_value, $search->getInurl()); - self::assertEquals($search_value, $search->getSearch()); + self::assertSame($inurl_value, $search->getInurl()); + self::assertSame($search_value, $search->getSearch()); } /** - * @return array<array<mixed>> + * @return list<list<mixed>> */ public static function provideInurlSearch(): array { return [ @@ -137,12 +137,12 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideDateSearch')] public static function test__construct_whenInputContainsDate_setsDateValues(string $input, ?int $min_date_value, ?int $max_date_value): void { $search = new FreshRSS_Search($input); - self::assertEquals($min_date_value, $search->getMinDate()); - self::assertEquals($max_date_value, $search->getMaxDate()); + self::assertSame($min_date_value, $search->getMinDate()); + self::assertSame($max_date_value, $search->getMaxDate()); } /** - * @return array<array<mixed>> + * @return list<list<mixed>> */ public static function provideDateSearch(): array { return [ @@ -158,12 +158,12 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('providePubdateSearch')] public static function test__construct_whenInputContainsPubdate_setsPubdateValues(string $input, ?int $min_pubdate_value, ?int $max_pubdate_value): void { $search = new FreshRSS_Search($input); - self::assertEquals($min_pubdate_value, $search->getMinPubdate()); - self::assertEquals($max_pubdate_value, $search->getMaxPubdate()); + self::assertSame($min_pubdate_value, $search->getMinPubdate()); + self::assertSame($max_pubdate_value, $search->getMaxPubdate()); } /** - * @return array<array<mixed>> + * @return list<list<mixed>> */ public static function providePubdateSearch(): array { return [ @@ -183,12 +183,12 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideTagsSearch')] public static function test__construct_whenInputContainsTags_setsTagsValue(string $input, ?array $tags_value, ?array $search_value): void { $search = new FreshRSS_Search($input); - self::assertEquals($tags_value, $search->getTags()); - self::assertEquals($search_value, $search->getSearch()); + self::assertSame($tags_value, $search->getTags()); + self::assertSame($search_value, $search->getSearch()); } /** - * @return array<array<string|array<string>|null>> + * @return list<list<string|list<string>|null>> */ public static function provideTagsSearch(): array { return [ @@ -215,19 +215,19 @@ class SearchTest extends PHPUnit\Framework\TestCase { ?int $max_date_value, ?array $intitle_value, ?array $inurl_value, ?int $min_pubdate_value, ?int $max_pubdate_value, ?array $tags_value, ?array $search_value): void { $search = new FreshRSS_Search($input); - self::assertEquals($author_value, $search->getAuthor()); - self::assertEquals($min_date_value, $search->getMinDate()); - self::assertEquals($max_date_value, $search->getMaxDate()); - self::assertEquals($intitle_value, $search->getIntitle()); - self::assertEquals($inurl_value, $search->getInurl()); - self::assertEquals($min_pubdate_value, $search->getMinPubdate()); - self::assertEquals($max_pubdate_value, $search->getMaxPubdate()); - self::assertEquals($tags_value, $search->getTags()); - self::assertEquals($search_value, $search->getSearch()); - self::assertEquals($input, $search->getRawInput()); + self::assertSame($author_value, $search->getAuthor()); + self::assertSame($min_date_value, $search->getMinDate()); + self::assertSame($max_date_value, $search->getMaxDate()); + self::assertSame($intitle_value, $search->getIntitle()); + self::assertSame($inurl_value, $search->getInurl()); + self::assertSame($min_pubdate_value, $search->getMinPubdate()); + self::assertSame($max_pubdate_value, $search->getMaxPubdate()); + self::assertSame($tags_value, $search->getTags()); + self::assertSame($search_value, $search->getSearch()); + self::assertSame($input, $search->getRawInput()); } - /** @return array<array<mixed>> */ + /** @return list<list<mixed>> */ public static function provideMultipleSearch(): array { return [ [ @@ -283,10 +283,10 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideAddOrParentheses')] public static function test__addOrParentheses(string $input, string $output): void { - self::assertEquals($output, FreshRSS_BooleanSearch::addOrParentheses($input)); + self::assertSame($output, FreshRSS_BooleanSearch::addOrParentheses($input)); } - /** @return array<array{string,string}> */ + /** @return list<list{string,string}> */ public static function provideAddOrParentheses(): array { return [ ['ab', 'ab'], @@ -302,10 +302,10 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideconsistentOrParentheses')] public static function test__consistentOrParentheses(string $input, string $output): void { - self::assertEquals($output, FreshRSS_BooleanSearch::consistentOrParentheses($input)); + self::assertSame($output, FreshRSS_BooleanSearch::consistentOrParentheses($input)); } - /** @return array<array{string,string}> */ + /** @return list<list{string,string}> */ public static function provideconsistentOrParentheses(): array { return [ ['ab cd ef', 'ab cd ef'], @@ -332,24 +332,24 @@ class SearchTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideParentheses')] public function test__parentheses(string $input, string $sql, array $values): void { [$filterValues, $filterSearch] = FreshRSS_EntryDAOPGSQL::sqlBooleanSearch('e.', new FreshRSS_BooleanSearch($input)); - self::assertEquals(trim($sql), trim($filterSearch)); - self::assertEquals($values, $filterValues); + self::assertSame(trim($sql), trim($filterSearch)); + self::assertSame($values, $filterValues); } - /** @return array<array<mixed>> */ + /** @return list<list<mixed>> */ public static function provideParentheses(): array { return [ [ 'f:1 (f:2 OR f:3 OR f:4) (f:5 OR (f:6 OR f:7))', ' ((e.id_feed IN (?) )) AND ((e.id_feed IN (?) ) OR (e.id_feed IN (?) ) OR (e.id_feed IN (?) )) AND' . ' (((e.id_feed IN (?) )) OR ((e.id_feed IN (?) ) OR (e.id_feed IN (?) ))) ', - ['1', '2', '3', '4', '5', '6', '7'] + [1, 2, 3, 4, 5, 6, 7] ], [ '#tag Hello OR (author:Alice inurl:example) OR (f:3 intitle:World) OR L:12', " ((TRIM(e.tags) || ' #' LIKE ? AND (e.title LIKE ? OR e.content LIKE ?) )) OR ((e.author LIKE ? AND e.link LIKE ? )) OR" . ' ((e.id_feed IN (?) AND e.title LIKE ? )) OR ((e.id IN (SELECT et.id_entry FROM `_entrytag` et WHERE et.id_tag IN (?)) )) ', - ['%tag #%', '%Hello%', '%Hello%', '%Alice%', '%example%', '3', '%World%', '12'] + ['%tag #%', '%Hello%', '%Hello%', '%Alice%', '%example%', 3, '%World%', 12] ], [ '#tag Hello (author:Alice inurl:example) (f:3 intitle:World) label:Bleu', @@ -357,7 +357,7 @@ class SearchTest extends PHPUnit\Framework\TestCase { ' ((e.author LIKE ? AND e.link LIKE ? )) AND' . ' ((e.id_feed IN (?) AND e.title LIKE ? )) AND' . ' ((e.id IN (SELECT et.id_entry FROM `_entrytag` et, `_tag` t WHERE et.id_tag = t.id AND t.name IN (?)) )) ', - ['%tag #%', '%Hello%', '%Hello%', '%Alice%', '%example%', '3', '%World%', 'Bleu'] + ['%tag #%', '%Hello%', '%Hello%', '%Alice%', '%example%', 3, '%World%', 'Bleu'] ], [ '!((author:Alice intitle:hello) OR (author:Bob intitle:world))', @@ -478,11 +478,11 @@ class SearchTest extends PHPUnit\Framework\TestCase { */ public function test__regex_postgresql(string $input, string $sql, array $values): void { [$filterValues, $filterSearch] = FreshRSS_EntryDAOPGSQL::sqlBooleanSearch('e.', new FreshRSS_BooleanSearch($input)); - self::assertEquals(trim($sql), trim($filterSearch)); - self::assertEquals($values, $filterValues); + self::assertSame(trim($sql), trim($filterSearch)); + self::assertSame($values, $filterValues); } - /** @return array<array<mixed>> */ + /** @return list<list<mixed>> */ public static function provideRegexPostreSQL(): array { return [ [ @@ -551,11 +551,11 @@ class SearchTest extends PHPUnit\Framework\TestCase { FreshRSS_DatabaseDAO::$dummyConnection = true; FreshRSS_DatabaseDAO::setStaticVersion('11.4.3-MariaDB-ubu2404'); [$filterValues, $filterSearch] = FreshRSS_EntryDAO::sqlBooleanSearch('e.', new FreshRSS_BooleanSearch($input)); - self::assertEquals(trim($sql), trim($filterSearch)); - self::assertEquals($values, $filterValues); + self::assertSame(trim($sql), trim($filterSearch)); + self::assertSame($values, $filterValues); } - /** @return array<array<mixed>> */ + /** @return list<list<mixed>> */ public static function provideRegexMariaDB(): array { return [ [ @@ -584,11 +584,11 @@ class SearchTest extends PHPUnit\Framework\TestCase { FreshRSS_DatabaseDAO::$dummyConnection = true; FreshRSS_DatabaseDAO::setStaticVersion('9.0.1'); [$filterValues, $filterSearch] = FreshRSS_EntryDAO::sqlBooleanSearch('e.', new FreshRSS_BooleanSearch($input)); - self::assertEquals(trim($sql), trim($filterSearch)); - self::assertEquals($values, $filterValues); + self::assertSame(trim($sql), trim($filterSearch)); + self::assertSame($values, $filterValues); } - /** @return array<array<mixed>> */ + /** @return list<list<mixed>> */ public static function provideRegexMySQL(): array { return [ [ @@ -615,11 +615,11 @@ class SearchTest extends PHPUnit\Framework\TestCase { */ public function test__regex_sqlite(string $input, string $sql, array $values): void { [$filterValues, $filterSearch] = FreshRSS_EntryDAOSQLite::sqlBooleanSearch('e.', new FreshRSS_BooleanSearch($input)); - self::assertEquals(trim($sql), trim($filterSearch)); - self::assertEquals($values, $filterValues); + self::assertSame(trim($sql), trim($filterSearch)); + self::assertSame($values, $filterValues); } - /** @return array<array<mixed>> */ + /** @return list<list<mixed>> */ public static function provideRegexSQLite(): array { return [ [ diff --git a/tests/app/Models/UserQueryTest.php b/tests/app/Models/UserQueryTest.php index 70483aed1..04fb74fd0 100644 --- a/tests/app/Models/UserQueryTest.php +++ b/tests/app/Models/UserQueryTest.php @@ -10,13 +10,13 @@ class UserQueryTest extends TestCase { public static function test__construct_whenAllQuery_storesAllParameters(): void { $query = ['get' => 'a']; $user_query = new FreshRSS_UserQuery($query, [], []); - self::assertEquals('all', $user_query->getGetType()); + self::assertSame('all', $user_query->getGetType()); } public static function test__construct_whenFavoriteQuery_storesFavoriteParameters(): void { $query = ['get' => 's']; $user_query = new FreshRSS_UserQuery($query, [], []); - self::assertEquals('favorite', $user_query->getGetType()); + self::assertSame('favorite', $user_query->getGetType()); } public function test__construct_whenCategoryQuery_storesCategoryParameters(): void { @@ -29,8 +29,8 @@ class UserQueryTest extends TestCase { ->willReturn($category_name); $query = ['get' => 'c_1']; $user_query = new FreshRSS_UserQuery($query, [1 => $cat], []); - self::assertEquals($category_name, $user_query->getGetName()); - self::assertEquals('category', $user_query->getGetType()); + self::assertSame($category_name, $user_query->getGetName()); + self::assertSame('category', $user_query->getGetType()); } public function test__construct_whenFeedQuery_storesFeedParameters(): void { @@ -53,8 +53,8 @@ class UserQueryTest extends TestCase { ->willReturn([1 => $feed]); $query = ['get' => 'f_1']; $user_query = new FreshRSS_UserQuery($query, [1 => $cat], []); - self::assertEquals($feed_name, $user_query->getGetName()); - self::assertEquals('feed', $user_query->getGetType()); + self::assertSame($feed_name, $user_query->getGetName()); + self::assertSame('feed', $user_query->getGetType()); } public static function test__construct_whenUnknownQuery_doesStoreParameters(): void { @@ -68,28 +68,28 @@ class UserQueryTest extends TestCase { $name = 'some name'; $query = ['name' => $name]; $user_query = new FreshRSS_UserQuery($query, [], []); - self::assertEquals($name, $user_query->getName()); + self::assertSame($name, $user_query->getName()); } public static function test__construct_whenOrder_storesOrder(): void { $order = 'some order'; $query = ['order' => $order]; $user_query = new FreshRSS_UserQuery($query, [], []); - self::assertEquals($order, $user_query->getOrder()); + self::assertSame($order, $user_query->getOrder()); } public static function test__construct_whenState_storesState(): void { $state = FreshRSS_Entry::STATE_NOT_READ | FreshRSS_Entry::STATE_FAVORITE; $query = ['state' => $state]; $user_query = new FreshRSS_UserQuery($query, [], []); - self::assertEquals($state, $user_query->getState()); + self::assertSame($state, $user_query->getState()); } public static function test__construct_whenUrl_storesUrl(): void { $url = 'some url'; $query = ['url' => $url]; $user_query = new FreshRSS_UserQuery($query, [], []); - self::assertEquals($url, $user_query->getUrl()); + self::assertSame($url, $user_query->getUrl()); } public static function testToArray_whenNoData_returnsEmptyArray(): void { @@ -108,7 +108,7 @@ class UserQueryTest extends TestCase { ]; $user_query = new FreshRSS_UserQuery($query, [], []); self::assertCount(6, $user_query->toArray()); - self::assertEquals($query, $user_query->toArray()); + self::assertSame($query, $user_query->toArray()); } public static function testHasSearch_whenSearch_returnsTrue(): void { diff --git a/tests/app/Utils/dotNotationUtilTest.php b/tests/app/Utils/dotNotationUtilTest.php index e49220d30..20d4726af 100644 --- a/tests/app/Utils/dotNotationUtilTest.php +++ b/tests/app/Utils/dotNotationUtilTest.php @@ -41,6 +41,6 @@ class dotNotationUtilTest extends PHPUnit\Framework\TestCase { #[DataProvider('provideJsonDots')] public static function testJsonDots(array $array, string $key, string $expected): void { $value = FreshRSS_dotNotation_Util::get($array, $key); - self::assertEquals($expected, $value); + self::assertSame($expected, $value); } } diff --git a/tests/cli/CliOptionsParserTest.php b/tests/cli/CliOptionsParserTest.php index 046617721..7aa9cdac3 100644 --- a/tests/cli/CliOptionsParserTest.php +++ b/tests/cli/CliOptionsParserTest.php @@ -54,131 +54,131 @@ class CliOptionsParserTest extends TestCase { public static function testInvalidOptionSetWithValueReturnsError(): void { $result = self::runOptionalOptions('--invalid=invalid'); - self::assertEquals(['invalid' => 'unknown option: invalid'], $result->errors); + self::assertSame(['invalid' => 'unknown option: invalid'], $result->errors); } public static function testInvalidOptionSetWithoutValueReturnsError(): void { $result = self::runOptionalOptions('--invalid'); - self::assertEquals(['invalid' => 'unknown option: invalid'], $result->errors); + self::assertSame(['invalid' => 'unknown option: invalid'], $result->errors); } public static function testValidOptionSetWithValidValueAndInvalidOptionSetWithValueReturnsValueForValidOptionAndErrorForInvalidOption(): void { $result = self::runOptionalOptions('--string=string --invalid=invalid'); - self::assertEquals('string', $result->string); - self::assertEquals(['invalid' => 'unknown option: invalid'], $result->errors); + self::assertSame('string', $result->string); + self::assertSame(['invalid' => 'unknown option: invalid'], $result->errors); } public static function testOptionWithValueTypeOfStringSetOnceWithValidValueReturnsValueAsString(): void { $result = self::runOptionalOptions('--string=string'); - self::assertEquals('string', $result->string); + self::assertSame('string', $result->string); } public static function testOptionWithRequiredValueTypeOfIntSetOnceWithValidValueReturnsValueAsInt(): void { $result = self::runOptionalOptions('--int=111'); - self::assertEquals(111, $result->int); + self::assertSame(111, $result->int); } public static function testOptionWithRequiredValueTypeOfBoolSetOnceWithValidValueReturnsValueAsBool(): void { $result = self::runOptionalOptions('--bool=on'); - self::assertEquals(true, $result->bool); + self::assertTrue($result->bool); } public static function testOptionWithValueTypeOfArrayOfStringSetOnceWithValidValueReturnsValueAsArrayOfString(): void { $result = self::runOptionalOptions('--array-of-string=string'); - self::assertEquals(['string'], $result->arrayOfString); + self::assertSame(['string'], $result->arrayOfString); } public static function testOptionWithValueTypeOfStringSetMultipleTimesWithValidValueReturnsLastValueSetAsString(): void { $result = self::runOptionalOptions('--string=first --string=second'); - self::assertEquals('second', $result->string); + self::assertSame('second', $result->string); } public static function testOptionWithValueTypeOfIntSetMultipleTimesWithValidValueReturnsLastValueSetAsInt(): void { $result = self::runOptionalOptions('--int=111 --int=222'); - self::assertEquals(222, $result->int); + self::assertSame(222, $result->int); } public static function testOptionWithValueTypeOfBoolSetMultipleTimesWithValidValueReturnsLastValueSetAsBool(): void { $result = self::runOptionalOptions('--bool=on --bool=off'); - self::assertEquals(false, $result->bool); + self::assertFalse($result->bool); } public static function testOptionWithValueTypeOfArrayOfStringSetMultipleTimesWithValidValueReturnsAllSetValuesAsArrayOfString(): void { $result = self::runOptionalOptions('--array-of-string=first --array-of-string=second'); - self::assertEquals(['first', 'second'], $result->arrayOfString); + self::assertSame(['first', 'second'], $result->arrayOfString); } public static function testOptionWithValueTypeOfIntSetWithInvalidValueReturnsAnError(): void { $result = self::runOptionalOptions('--int=one'); - self::assertEquals(['int' => 'invalid input: int must be an integer'], $result->errors); + self::assertSame(['int' => 'invalid input: int must be an integer'], $result->errors); } public static function testOptionWithValueTypeOfBoolSetWithInvalidValuesReturnsAnError(): void { $result = self::runOptionalOptions('--bool=bad'); - self::assertEquals(['bool' => 'invalid input: bool must be a boolean'], $result->errors); + self::assertSame(['bool' => 'invalid input: bool must be a boolean'], $result->errors); } public static function testOptionWithValueTypeOfIntSetMultipleTimesWithValidAndInvalidValuesReturnsLastValidValueSetAsIntAndError(): void { $result = self::runOptionalOptions('--int=111 --int=one --int=222 --int=two'); - self::assertEquals(222, $result->int); - self::assertEquals(['int' => 'invalid input: int must be an integer'], $result->errors); + self::assertSame(222, $result->int); + self::assertSame(['int' => 'invalid input: int must be an integer'], $result->errors); } public static function testOptionWithValueTypeOfBoolSetMultipleTimesWithWithValidAndInvalidValuesReturnsLastValidValueSetAsBoolAndError(): void { $result = self::runOptionalOptions('--bool=on --bool=good --bool=off --bool=bad'); - self::assertEquals(false, $result->bool); - self::assertEquals(['bool' => 'invalid input: bool must be a boolean'], $result->errors); + self::assertFalse($result->bool); + self::assertSame(['bool' => 'invalid input: bool must be a boolean'], $result->errors); } public static function testNotSetOptionWithDefaultInputReturnsDefaultInput(): void { $result = self::runOptionalOptions(''); - self::assertEquals('default', $result->defaultInput); + self::assertSame('default', $result->defaultInput); } public static function testOptionWithDefaultInputSetWithValidValueReturnsCorrectlyTypedValue(): void { $result = self::runOptionalOptions('--default-input=input'); - self::assertEquals('input', $result->defaultInput); + self::assertSame('input', $result->defaultInput); } public static function testOptionWithOptionalValueSetWithoutValueReturnsEmptyString(): void { $result = self::runOptionalOptions('--optional-value'); - self::assertEquals('', $result->optionalValue); + self::assertSame('', $result->optionalValue); } public static function testOptionWithOptionalValueDefaultSetWithoutValueReturnsOptionalValueDefault(): void { $result = self::runOptionalOptions('--optional-value-with-default'); - self::assertEquals(true, $result->optionalValueWithDefault); + self::assertTrue($result->optionalValueWithDefault); } public static function testNotSetOptionWithOptionalValueDefaultAndDefaultInputReturnsDefaultInput(): void { $result = self::runOptionalOptions(''); - self::assertEquals('default', $result->defaultInputAndOptionalValueWithDefault); + self::assertSame('default', $result->defaultInputAndOptionalValueWithDefault); } public static function testOptionWithOptionalValueDefaultAndDefaultInputSetWithoutValueReturnsOptionalValueDefault(): void { $result = self::runOptionalOptions('--default-input-and-optional-value-with-default'); - self::assertEquals('optional', $result->defaultInputAndOptionalValueWithDefault); + self::assertSame('optional', $result->defaultInputAndOptionalValueWithDefault); } public static function testRequiredOptionNotSetReturnsError(): void { $result = self::runOptionalAndRequiredOptions(''); - self::assertEquals(['required' => 'invalid input: required cannot be empty'], $result->errors); + self::assertSame(['required' => 'invalid input: required cannot be empty'], $result->errors); } public static function testOptionSetWithDeprecatedAliasGeneratesDeprecationWarningAndReturnsValue(): void { $result = self::runCommandReadingStandardError('--deprecated-string=string'); - self::assertEquals('FreshRSS deprecation warning: the CLI option(s): deprecated-string are deprecated ' . + self::assertSame('FreshRSS deprecation warning: the CLI option(s): deprecated-string are deprecated ' . 'and will be removed in a future release. Use: string instead', $result ); $result = self::runOptionalOptions('--deprecated-string=string'); - self::assertEquals('string', $result->string); + self::assertSame('string', $result->string); } public static function testAlwaysReturnUsageMessageWithUsageInfoForAllOptions(): void { $result = self::runOptionalAndRequiredOptions(''); - self::assertEquals('Usage: cli-parser-test.php --required=<required> [-s --string=<string>] [-i --int=<int>] [-b --bool=<bool>] [-f --flag]', + self::assertSame('Usage: cli-parser-test.php --required=<required> [-s --string=<string>] [-i --int=<int>] [-b --bool=<bool>] [-f --flag]', $result->usage, ); } diff --git a/tests/cli/i18n/I18nCompletionValidatorTest.php b/tests/cli/i18n/I18nCompletionValidatorTest.php index f16285005..f66d9e04f 100644 --- a/tests/cli/i18n/I18nCompletionValidatorTest.php +++ b/tests/cli/i18n/I18nCompletionValidatorTest.php @@ -17,23 +17,23 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { public function testDisplayReport(): void { $validator = new I18nCompletionValidator([], []); - self::assertEquals("There is no data.\n", $validator->displayReport()); + self::assertSame("There is no data.\n", $validator->displayReport()); $reflectionTotalEntries = new ReflectionProperty(I18nCompletionValidator::class, 'totalEntries'); $reflectionTotalEntries->setAccessible(true); $reflectionTotalEntries->setValue($validator, 100); - self::assertEquals("Translation is 0.0% complete.\n", $validator->displayReport()); + self::assertSame("Translation is 0.0% complete.\n", $validator->displayReport()); $reflectionPassEntries = new ReflectionProperty(I18nCompletionValidator::class, 'passEntries'); $reflectionPassEntries->setAccessible(true); $reflectionPassEntries->setValue($validator, 25); - self::assertEquals("Translation is 25.0% complete.\n", $validator->displayReport()); + self::assertSame("Translation is 25.0% complete.\n", $validator->displayReport()); $reflectionPassEntries->setValue($validator, 100); - self::assertEquals("Translation is 100.0% complete.\n", $validator->displayReport()); + self::assertSame("Translation is 100.0% complete.\n", $validator->displayReport()); $reflectionPassEntries->setValue($validator, 200); @@ -45,7 +45,7 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { public static function testValidateWhenNoData(): void { $validator = new I18nCompletionValidator([], []); self::assertTrue($validator->validate()); - self::assertEquals('', $validator->displayResult()); + self::assertSame('', $validator->displayResult()); } public function testValidateWhenKeyIsMissing(): void { @@ -59,7 +59,7 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ], []); self::assertFalse($validator->validate()); - self::assertEquals("Missing key file1.l1.l2.k1\nMissing key file2.l1.l2.k1\n", $validator->displayResult()); + self::assertSame("Missing key file1.l1.l2.k1\nMissing key file2.l1.l2.k1\n", $validator->displayResult()); } public function testValidateWhenKeyIsIgnored(): void { @@ -84,7 +84,7 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ]); self::assertTrue($validator->validate()); - self::assertEquals('', $validator->displayResult()); + self::assertSame('', $validator->displayResult()); } public function testValidateWhenValueIsEqual(): void { @@ -112,7 +112,7 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ]); self::assertFalse($validator->validate()); - self::assertEquals("Untranslated key file1.l1.l2.k1 - \nUntranslated key file2.l1.l2.k1 - \n", $validator->displayResult()); + self::assertSame("Untranslated key file1.l1.l2.k1 - \nUntranslated key file2.l1.l2.k1 - \n", $validator->displayResult()); } public function testValidateWhenValueIsDifferent(): void { @@ -140,6 +140,6 @@ class I18nCompletionValidatorTest extends PHPUnit\Framework\TestCase { ]); self::assertTrue($validator->validate()); - self::assertEquals('', $validator->displayResult()); + self::assertSame('', $validator->displayResult()); } } diff --git a/tests/cli/i18n/I18nDataTest.php b/tests/cli/i18n/I18nDataTest.php index 29ee14802..afdaacf1e 100644 --- a/tests/cli/i18n/I18nDataTest.php +++ b/tests/cli/i18n/I18nDataTest.php @@ -36,7 +36,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testConstructWhenReferenceOnly(): void { $data = new I18nData($this->referenceData); - self::assertEquals($this->referenceData, $data->getData()); + self::assertSame($this->referenceData, $data->getData()); } public function testConstructorWhenLanguageIsMissingFile(): void { @@ -278,7 +278,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'nl' => [], ]); $data = new I18nData($rawData); - self::assertEquals([ + self::assertSame([ 'en', 'fr', 'nl', @@ -292,7 +292,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'de' => [], ]); $data = new I18nData($rawData); - self::assertEquals([ + self::assertSame([ 'de', 'en', 'fr', @@ -310,7 +310,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testAddLanguageWhenNoReferenceProvided(): void { $data = new I18nData($this->referenceData); $data->addLanguage('fr'); - self::assertEquals([ + self::assertSame([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -347,7 +347,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testAddLanguageWhenUnknownReferenceProvided(): void { $data = new I18nData($this->referenceData); $data->addLanguage('fr', 'unknown'); - self::assertEquals([ + self::assertSame([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -384,7 +384,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { public function testAddLanguageWhenKnownReferenceProvided(): void { $data = new I18nData($this->referenceData); $data->addLanguage('fr', 'en'); - self::assertEquals([ + self::assertSame([ 'en' => [ 'file1.php' => [ 'file1.l1.l2.k1' => $this->value, @@ -480,9 +480,9 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { $enValue = $getTargetedValue($data, 'en'); $frValue = $getTargetedValue($data, 'fr'); self::assertInstanceOf(I18nValue::class, $enValue); - self::assertEquals('value', $enValue->getValue()); + self::assertSame('value', $enValue->getValue()); self::assertTrue($enValue->isTodo()); - self::assertEquals($frValue, $enValue); + self::assertSame($frValue, $enValue); } public function testAddValueWhenLanguageDoesNotExist(): void { @@ -520,9 +520,9 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { self::assertEquals($this->value, $beforeEnValue); self::assertEquals($this->value, $beforeFrValue); self::assertInstanceOf(I18nValue::class, $afterEnValue); - self::assertEquals('new value', $afterEnValue->getValue()); + self::assertSame('new value', $afterEnValue->getValue()); self::assertInstanceOf(I18nValue::class, $afterFrValue); - self::assertEquals('new value', $afterFrValue->getValue()); + self::assertSame('new value', $afterFrValue->getValue()); } public function testAddValueWhenLanguageIsReferenceAndValueInOtherLanguageHasChange(): void { @@ -554,7 +554,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { self::assertEquals($this->value, $beforeEnValue); self::assertEquals($value, $beforeFrValue); self::assertInstanceOf(I18nValue::class, $afterEnValue); - self::assertEquals('new value', $afterEnValue->getValue()); + self::assertSame('new value', $afterEnValue->getValue()); self::assertEquals($value, $afterFrValue); } @@ -575,7 +575,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { self::assertEquals($this->value, $beforeFrValue); self::assertEquals($this->value, $afterEnValue); self::assertInstanceOf(I18nValue::class, $afterFrValue); - self::assertEquals('new value', $afterFrValue->getValue()); + self::assertSame('new value', $afterFrValue->getValue()); } public function testRemoveKeyWhenKeyDoesNotExist(): void { @@ -723,7 +723,7 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'nl' => [], ]); $data = new I18nData($rawData); - self::assertEquals($this->referenceData['en'], $data->getLanguage('en')); + self::assertSame($this->referenceData['en'], $data->getLanguage('en')); } public function testGetReferenceLanguage(): void { @@ -732,6 +732,6 @@ class I18nDataTest extends PHPUnit\Framework\TestCase { 'nl' => [], ]); $data = new I18nData($rawData); - self::assertEquals($this->referenceData['en'], $data->getReferenceLanguage()); + self::assertSame($this->referenceData['en'], $data->getReferenceLanguage()); } } diff --git a/tests/cli/i18n/I18nFileTest.php b/tests/cli/i18n/I18nFileTest.php index 755ea12f2..34abdb9a3 100644 --- a/tests/cli/i18n/I18nFileTest.php +++ b/tests/cli/i18n/I18nFileTest.php @@ -12,7 +12,7 @@ class I18nFileTest extends PHPUnit\Framework\TestCase { $after = $this->computeFilesHash(); - self::assertEquals($before, $after); + self::assertSame($before, $after); } /** @return array<string,string|false> */ diff --git a/tests/cli/i18n/I18nUsageValidatorTest.php b/tests/cli/i18n/I18nUsageValidatorTest.php index 1c604390f..5a2268141 100644 --- a/tests/cli/i18n/I18nUsageValidatorTest.php +++ b/tests/cli/i18n/I18nUsageValidatorTest.php @@ -17,23 +17,23 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { public function testDisplayReport(): void { $validator = new I18nUsageValidator([], []); - self::assertEquals("There is no data.\n", $validator->displayReport()); + self::assertSame("There is no data.\n", $validator->displayReport()); $reflectionTotalEntries = new ReflectionProperty(I18nUsageValidator::class, 'totalEntries'); $reflectionTotalEntries->setAccessible(true); $reflectionTotalEntries->setValue($validator, 100); - self::assertEquals(" 0.0% of translation keys are unused.\n", $validator->displayReport()); + self::assertSame(" 0.0% of translation keys are unused.\n", $validator->displayReport()); $reflectionFailedEntries = new ReflectionProperty(I18nUsageValidator::class, 'failedEntries'); $reflectionFailedEntries->setAccessible(true); $reflectionFailedEntries->setValue($validator, 25); - self::assertEquals(" 25.0% of translation keys are unused.\n", $validator->displayReport()); + self::assertSame(" 25.0% of translation keys are unused.\n", $validator->displayReport()); $reflectionFailedEntries->setValue($validator, 100); - self::assertEquals("100.0% of translation keys are unused.\n", $validator->displayReport()); + self::assertSame("100.0% of translation keys are unused.\n", $validator->displayReport()); $reflectionFailedEntries->setValue($validator, 200); @@ -45,7 +45,7 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { public static function testValidateWhenNoData(): void { $validator = new I18nUsageValidator([], []); self::assertTrue($validator->validate()); - self::assertEquals('', $validator->displayResult()); + self::assertSame('', $validator->displayResult()); } public function testValidateWhenParentKeyExistsWithoutTransformation(): void { @@ -61,7 +61,7 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file2.l1.l2._', ]); self::assertTrue($validator->validate()); - self::assertEquals('', $validator->displayResult()); + self::assertSame('', $validator->displayResult()); } public function testValidateWhenParentKeyExistsWithTransformation(): void { @@ -77,7 +77,7 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file2.l1.l2', ]); self::assertTrue($validator->validate()); - self::assertEquals('', $validator->displayResult()); + self::assertSame('', $validator->displayResult()); } public function testValidateWhenParentKeyDoesNotExist(): void { @@ -90,7 +90,7 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { ], ], []); self::assertFalse($validator->validate()); - self::assertEquals("Unused key file1.l1.l2._ - \nUnused key file2.l1.l2._ - \n", $validator->displayResult()); + self::assertSame("Unused key file1.l1.l2._ - \nUnused key file2.l1.l2._ - \n", $validator->displayResult()); } public function testValidateWhenChildKeyExists(): void { @@ -106,7 +106,7 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { 'file2.l1.l2.k1', ]); self::assertTrue($validator->validate()); - self::assertEquals('', $validator->displayResult()); + self::assertSame('', $validator->displayResult()); } public function testValidateWhenChildKeyDoesNotExist(): void { @@ -119,6 +119,6 @@ class I18nUsageValidatorTest extends PHPUnit\Framework\TestCase { ], ], []); self::assertFalse($validator->validate()); - self::assertEquals("Unused key file1.l1.l2.k1 - \nUnused key file2.l1.l2.k1 - \n", $validator->displayResult()); + self::assertSame("Unused key file1.l1.l2.k1 - \nUnused key file2.l1.l2.k1 - \n", $validator->displayResult()); } } diff --git a/tests/cli/i18n/I18nValueTest.php b/tests/cli/i18n/I18nValueTest.php index 44984d7b2..85ff00fee 100644 --- a/tests/cli/i18n/I18nValueTest.php +++ b/tests/cli/i18n/I18nValueTest.php @@ -5,28 +5,28 @@ require_once __DIR__ . '/../../../cli/i18n/I18nValue.php'; class I18nValueTest extends PHPUnit\Framework\TestCase { public static function testConstructorWithoutState(): void { $value = new I18nValue('some value'); - self::assertEquals('some value', $value->getValue()); + self::assertSame('some value', $value->getValue()); self::assertFalse($value->isIgnore()); self::assertFalse($value->isTodo()); } public static function testConstructorWithUnknownState(): void { $value = new I18nValue('some value -> unknown'); - self::assertEquals('some value', $value->getValue()); + self::assertSame('some value', $value->getValue()); self::assertFalse($value->isIgnore()); self::assertFalse($value->isTodo()); } public static function testConstructorWithTodoState(): void { $value = new I18nValue('some value -> todo'); - self::assertEquals('some value', $value->getValue()); + self::assertSame('some value', $value->getValue()); self::assertFalse($value->isIgnore()); self::assertTrue($value->isTodo()); } public static function testConstructorWithIgnoreState(): void { $value = new I18nValue('some value -> ignore'); - self::assertEquals('some value', $value->getValue()); + self::assertSame('some value', $value->getValue()); self::assertTrue($value->isIgnore()); self::assertFalse($value->isTodo()); } @@ -34,8 +34,8 @@ class I18nValueTest extends PHPUnit\Framework\TestCase { public static function testClone(): void { $value = new I18nValue('some value'); $clonedValue = clone $value; - self::assertEquals('some value', $value->getValue()); - self::assertEquals('some value', $clonedValue->getValue()); + self::assertSame('some value', $value->getValue()); + self::assertSame('some value', $clonedValue->getValue()); self::assertFalse($value->isIgnore()); self::assertFalse($clonedValue->isIgnore()); self::assertFalse($value->isTodo()); @@ -63,21 +63,21 @@ class I18nValueTest extends PHPUnit\Framework\TestCase { $value = new I18nValue('some value'); self::assertNull($reflectionProperty->getValue($value)); $value->markAsDirty(); - self::assertEquals('dirty', $reflectionProperty->getValue($value)); + self::assertSame('dirty', $reflectionProperty->getValue($value)); $value->unmarkAsIgnore(); - self::assertEquals('dirty', $reflectionProperty->getValue($value)); + self::assertSame('dirty', $reflectionProperty->getValue($value)); $value->markAsIgnore(); - self::assertEquals('ignore', $reflectionProperty->getValue($value)); + self::assertSame('ignore', $reflectionProperty->getValue($value)); $value->unmarkAsIgnore(); self::assertNull($reflectionProperty->getValue($value)); $value->markAsTodo(); - self::assertEquals('todo', $reflectionProperty->getValue($value)); + self::assertSame('todo', $reflectionProperty->getValue($value)); } public static function testToString(): void { $value = new I18nValue('some value'); - self::assertEquals('some value', $value->__toString()); + self::assertSame('some value', $value->__toString()); $value->markAsTodo(); - self::assertEquals('some value -> todo', $value->__toString()); + self::assertSame('some value -> todo', $value->__toString()); } } |