aboutsummaryrefslogtreecommitdiff
path: root/p
AgeCommit message (Collapse)Author
2020-04-09Fix BlueLagoon and Screwdriver hover title (#2884)Gravatar Alexandre Alapetite
#fix https://github.com/FreshRSS/FreshRSS/issues/2755 Follow-up of https://github.com/FreshRSS/FreshRSS/pull/2882#issuecomment-611136775 https://stackoverflow.com/questions/2837057/what-has-bigger-priority-opacity-or-z-index-in-browsers
2020-04-08Fix CSS hover long title (#2882)Gravatar Alexandre Alapetite
* Fix CSS hover long title #fix https://github.com/FreshRSS/FreshRSS/issues/2755 * Fix Ansum * Fix Mapco
2020-04-08Swap shortcuts for mark all articles as read / mark previous articles as ↵Gravatar Alexandre Alapetite
read (#2881) * Swap shortcuts for mark all articles as read / mark previous articles as read #fix https://github.com/FreshRSS/FreshRSS/issues/2865 Follow-up of https://github.com/FreshRSS/FreshRSS/pull/2843 * <kbd>⇧ Shift</kbd>+<kbd>R</kbd> to mark all articles as read; * <kbd>Alt ⎇</kbd>+<kbd>r</kbd> to mark previous articles as read. * i18n
2020-04-04Full with for audio UI (#2877)Gravatar Alexandre Alapetite
#fix https://github.com/FreshRSS/FreshRSS/issues/2875
2020-04-01API return proper newestItemTimestampUsec (#2854)Gravatar Alexandre Alapetite
* API return proper newestItemTimestampUsec #fix https://github.com/FreshRSS/FreshRSS/issues/2853 * Minor naming * Add newestItemTimestampUsec for labels * Do not use t.name after all
2020-03-30Simplify CSS remove z-index (#2861)Gravatar Alexandre Alapetite
* Simplify CSS remove z-index #fix https://github.com/FreshRSS/FreshRSS/issues/2860 Improvement of https://github.com/FreshRSS/FreshRSS/pull/2845 https://github.com/FreshRSS/FreshRSS/commit/22916d6a3ed259b5a5dca5cddb4a58433729384f#r38143737 * Fix when .nav_menu is not loaded This ability was lost with the last styling iterations
2020-03-30API return OK for an empty request (#2855)Gravatar Alexandre Alapetite
Fix https://framateam.org/freshrss/pl/yozcezrnufno9eut3173d4wpry
2020-03-28GReader API consistent default category (#2840)Gravatar Alexandre Alapetite
* GReader API consistent default category #Fix https://github.com/FreshRSS/FreshRSS/issues/2839 * Also for subscription/list
2020-03-28Loader animation while waiting for first articles (#2845)Gravatar Alexandre Alapetite
* Loader animation while waiting for first articles Especially useful when a slow search is being performed. Thanks to one new flush at the right time, the left colum and top menu will be there, waiting for the articles to come. This avoids layout flashes (the left column used to take the full width while waiting for articles). For optimal use, this assumes that the deployment has a proper buffering configuration, such as in our official Docker image (also when using Træfik as a reverse proxy in front). Might not work just as well with other Apache or nginx setups. * Fix on mobile And simplified CSS * Properly hide the loader It was not possible to find a position where the loading animation would be always hidden after load, so change strategy to hide it automatically by CSS when the actual content has arrived
2020-03-25Update RTL CSS files (#2848)Gravatar Frans de Jonge
* Update RTL CSS files * Add RTL for Alternative-Dark, cf. https://github.com/FreshRSS/FreshRSS/pull/2811 * Update RTL for base/Origine * Also include a `*.rtl.rtl.css` deletion in `make rtl` to work around https://github.com/MohammadYounes/rtlcss/issues/64 * forgot to commit Makefile
2020-03-23Shortcut mark previous articles as read (#2843)Gravatar Alexandre Alapetite
* Shortcut mark previous articles as read Address part of https://github.com/FreshRSS/FreshRSS/issues/2836 The shortcut [shift]+[r] now marks previous articles as read; The previous action of marking all articles as read is now achieved by [alt]+[r] So this is a slight breaking change, but I like the logic of the upward-facing [shift] arrow to hint at previous articles, while [alt] is more like "all", at least to my eyes :-) * Update app/i18n/nl/conf.php Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com> * [⇧ Shift] / [Alt ⎇] With standard Unicode signs * <kbd> + CSS styling * Missing themes Tested with all themes * Travis CSS Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2020-03-23Reset scroll (#2842)Gravatar Alexandre Alapetite
Address some of https://github.com/FreshRSS/FreshRSS/issues/2836 This patch resets the scrollbar to the top when a FreshRSS page is initialised. Makes sure that when a FreshRSS page is restored in a Web browser session, we do not hit the problematic situation when the content is refreshed but the scrollbar moved back to where it was, potentially erroneously marking as read many as read, of landing on the wrong focus.
2020-03-22New core-extensions to allow Docker volumes for third-party extensions (#2837)Gravatar Alexandre Alapetite
* New core-extensions to allow Docker volumes for third-party extensions #Fix https://github.com/FreshRSS/FreshRSS/issues/2650 Split our extensions directory into two: 1) Core extensions shipped with FreshRSS in ./lib/core-extensions/ 2) Third-party extensions modified by end-users in ./extensions/ which can easily be mounted as a Docker volume * Example of Docker Compose with extensions * Back-compatibility + fix array merge bug
2020-03-21Alternative-Dark theme (#2811)Gravatar fabianski7
* Alternative-Dark theme * Update template.css * Update adark.css * Update adark.css * Update template.css * Updates and fixes * Remaining minor whitespace * Remaining minor Travis * order/properties-order Co-authored-by: Fabiano <defabiano@tutanota.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-03-08Improve login and registration pages (#2794)Gravatar Marien Fressinaud
* Keep the user on login page on failure * Show an error if username already exists * Check the password format in the backend * Return a better message if username is invalid * Add a title to the login page * wip: Improve look of login and register pages * Set a capital M in username help message On the registration page, username tip started with a minuscule, while the password tip started with a capital. * Change message if username is taken
2020-03-01[UI] Add RTL support with RTLCSS (#2776)Gravatar Frans de Jonge
* Add dir info to gen.php & install.php! * Add `make rtl` command Using rtlcss because it has actually has a command-line application!
2020-02-29GReader remove unsused parameter (#2816)Gravatar Alexandre Alapetite
2020-02-29Better performance with yield (#2588)Gravatar Alexandre Alapetite
* Better performance with yield Largely decrease the time to first byte, and reduced memory consumtion. Before, we used to make several copies in memory of the whole list of articles before sending them to the client. Now streamed as they are processed. * Travis
2020-02-29No pre for enclosure-description (#2808)Gravatar Alexandre Alapetite
* No pre for enclosure-description #fix https://github.com/FreshRSS/FreshRSS/issues/2807 In browsers, the styling `white-space:pre-line` will be applied by CSS, but no styling will be done for clients via API. * Corresponding CSS change
2020-02-13Enhance content path feature (#2778)Gravatar Julien-Pierre Avérous
- Add a maintenance section to be able to clear cache and force reload a feed. - Add an icon next to path field to show a pop-up with the result of the content path. Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: Marien Fressinaud <dev@marienfressinaud.fr>
2020-01-18[API, extension] Use 'dateAdded()' to forge 'crawlTimeMsec' & ↵Gravatar Julien-Pierre Avérous
'timestampUsec' field in greader API. (#2773) - Add the ability to customize 'dateAdded()', so an extension can change it if needed.
2020-01-17fix: #2701 Fix look of authors (#2771)Gravatar Marien Fressinaud
This fix makes the authors part of the "title item", so it's not considered as another block. This is not perfect since authors will disappear on small screens, but we can discuss of putting titles on multi-lines (see https://github.com/FreshRSS/FreshRSS/issues/2344)
2020-01-16Pass the entries to 'entry_before_display' extension hook (#2763)Gravatar Julien-Pierre Avérous
* Pass the entries to 'entry_before_display' extension hook. - #2762 * Fix code-style. * - Fix 'Whitespace found at end of line'. Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2020-01-05Fix loader display in Dark theme (#2753)Gravatar Alexis Degrugillier
Before, the default loader was used. It rendered poorly since it has a white border. Now, the theme loader is used.
2020-01-03Fix logging environment constants (#2745)Gravatar Alexandre Alapetite
* Fix logging environment constants * COPY_LOG_TO_SYSLOG was only working when Syslog was used * FRESHRSS_ENV was not properly used to set logging level * Simplify code Always call `openlog()` even when it is not used * Always specify syslog properties https://github.com/FreshRSS/FreshRSS/pull/2745#discussion_r362207445 * $username is also needed further down * No new line in syslog
2019-12-29fix: Fix undefined function _t on WebSub (#2743)Gravatar Marien Fressinaud
I published an article via WebSub, but I never received it. So I checked my logs to find why and I found the following stacktrace: ``` 29/Dec/2019:15:58:32 +0000 "POST /api/pshb.php" 500 NOTICE: PHP message: PHP Fatal error: Uncaught Error: Call to undefined function _t() in /path/app/Models/Category.php:83 Stack trace: /path/app/Models/CategoryDAO.php(417): FreshRSS_Category->_id(1) /path/app/Models/CategoryDAO.php(192): FreshRSS_CategoryDAO::daoToCategory(Array) /path/app/Models/Feed.php(466): FreshRSS_CategoryDAO->searchById('1') /path/app/Controllers/feedController.php(416): FreshRSS_Feed->cleanOldEntries() /path/p/api/pshb.php(141): FreshRSS_feed_Controller::actualizeFeed(0, 'https://flus.io...', false, Object(SimplePie)) {main} thrown in /path/app/Models/Category.php on line 83 ``` The `_t` function should be loaded with the Minz_Translate class, but the latter isn't initialized on WebSub endpoint. In my opinion, we should not have to care about this kind of detail of implementation and it reveals a deeper architectural misconception, but for now the fix should be enough. It’s quite difficult to reproduce locally though.
2019-12-28Fix labels dropdown not scrollable after a while (#2727)Gravatar romibi
2019-12-04Update navigation on empty feeds (#2687)Gravatar Alexis Degrugillier
When using feed navigation, the previous behavior was to cycle through all available feeds regardless of their content. To match the behaviour of the first feed and last feed navigation shortcuts, the navigation now skips empty feeds. Now it's consistent through out the application. When using feed navigation with only empty feeds, the new behavior is to cycle through all available feeds. See #2385
2019-11-05Cookie same-site (#2630)Gravatar Alexandre Alapetite
* Set-Cookie SameSite * https://tools.ietf.org/html/draft-ietf-httpbis-cookie-same-site-00 * https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-5.3.7 * https://blog.mozilla.org/security/2018/04/24/same-site-cookies-in-firefox-60/ * https://blog.chromium.org/2019/10/developers-get-ready-for-new.html Set to Lax instead of Strict to allow linking to allow linking to FreshRSS sub-pages without having to log-in again
2019-11-05Fix favorite display for "current" articles (#2634)Gravatar Marien Fressinaud
Favorite articles have, in most of the themes, a gold background to distinguish them from the other articles. However, it can be distracting to have such a background when reading the articles, so we should turn them back to the "default" background when articles are opened (class `.current`). Bug introduced in e9ce27d8d991d7806ca2c2af7e5282279e378885 Related PRs: - https://github.com/FreshRSS/FreshRSS/pull/2477 - https://github.com/FreshRSS/FreshRSS/pull/2611 - https://github.com/FreshRSS/FreshRSS/pull/2612 Closes https://github.com/FreshRSS/FreshRSS/issues/2618
2019-11-02API 64-bit ID as string (#2621)Gravatar Alexandre Alapetite
Fix https://github.com/FreshRSS/FreshRSS/issues/2620
2019-10-28Fix unread styles (#2612)Gravatar Frans de Jonge
* [fix] Flat unread CSS style Same as #2611. * [fix] Origine-Compact unread CSS style Same as #2611. * [fix] Swage unread CSS style Same as #2611.
2019-10-27[fix] Origine unread CSS style (#2611)Gravatar Frans de Jonge
Fixes #2604.
2019-10-23Workaround for MySQL limitation 1093 (#2586)Gravatar Alexandre Alapetite
* Workaround for MySQL limitation 1093 https://github.com/FreshRSS/FreshRSS/pull/2335#issuecomment-545194606 including minor Travis fixes
2019-10-23Feature/new archiving (#2335)Gravatar Alexis Degrugillier
* Change archiving config page layout I've changed some wording and moved actions into a maintenance section. * Update purge action Now we have more control on the purge action. The configuration allows us to choose what to keep and what to discard in a more precise way. At the moment, the configuration applies for all feeds. * Add purge configuration on feed level Now the extend purge configuration is available on feed level. It is stored as attributes and will be used in the purge action. * Update purge action Now the purge action uses the feed configuration if it exists and defaults on user configuration if not. * Add empty option in period list * Fix configuration warnings * Add archiving configuration on categories See #2369 * Add user info back * Add explanations in UI * Fixes for SQLite + error + misc. * Fix invalid feed reference * Short array syntax Only for new code, so far * Fix prefix error * Query performance, default values Work in progress * Fix default values and confirm before leaving Form cancel and confirm changes before leaving were broken. And start taking advantage of the short echo syntax `<?= ?>` as we have moved to PHP 5.4+ * More work * Tuning SQL * Fix MariaDB + performance issue * SQL performance * Fix SQLite bug * Fix some attributes JSON encoding bugs Especially for SQLite export/import * More uniform, fix bugs More uniform between global, category, feed settings * Drop special cases for old articles during refresh Instead will use lastSeen date with the new archiving logic. This was generating problems anyway https://github.com/FreshRSS/FreshRSS/issues/2154 * Draft drop index keep_history Not needed anymore * MySQL typo Now properly tested with MySQL, PostgreSQL, SQLite * More work for legacy values Important to avoid overriding user's preference and risking deleting data erroneously * Fix PHP 7.3 / 7.4 warnings @aledeg "Trying to use values of type null, bool, int, float or resource as an array (such as $null["key"]) will now generate a notice. " https://php.net/migration74.incompatible * Reintroduce min articles and take care of legacy parameters * A few changes forgotten * Draft of migration + DROP of feed.keep_history * Fix several errors And give up using const for SQL to allow multiple database types (and we cannot redefine a const) * Add keep_min to categories + factorise archiving logic * Legacy fix * Fix bug yield from * Minor: Use JSON_UNESCAPED_SLASHE for attributes And make more uniform * Fix sign and missing variable * Fine tune the logic
2019-10-20Comply with LibreJS (#2576)Gravatar Alexandre Alapetite
https://www.gnu.org/software/librejs/ https://addons.mozilla.org/firefox/addon/librejs/ Did not touch jquery.min.js because it is a third party script, which is regularly updated, and the add-on does not seem to block it enough to break our statitics page, which remains usable.
2019-10-16Fix for broken read icon in Firefox (#2571)Gravatar Offerel
* Fix for broken reading view icon in Firefox * Update CREDITS.md * Update CREDITS.md * Fix for broken read icon in Firefox
2019-10-15Fix for broken reading view icon in Firefox (#2569)Gravatar Offerel
2019-10-09Fix API i18n (#2565)Gravatar Alexandre Alapetite
Fix https://github.com/FreshRSS/FreshRSS/issues/2564
2019-10-01Workaround for Firefox favicon glitch (#2543)Gravatar Alexandre Alapetite
Observed in Firefox 69: the favicon is sometimes refreshed with an old favicon that does not have the number of unread items on it. Seems to depend on load speed.
2019-09-29Quick fix: API PDO visibility bug (#2545)Gravatar Alexandre Alapetite
Introduced in https://github.com/FreshRSS/FreshRSS/pull/2522
2019-09-29PDO refactoring for code simplification (#2522)Gravatar Alexandre Alapetite
* PDO refactor * Automatic prefix when using the syntax `_tableName` * Uniformity: MySQL is now PDO::ATTR_EMULATE_PREPARES = false just like SQLite and PostgreSQL, with consequences such as only one statement per query * Use PDO methods exec(), query(), prepare() + execute() in a more efficient way * Remove auto-update SQL code for versions older than FreshRSS 1.5 (3 years old) * The name of the default category is set in PHP instead of in the DB (simplies SQL and allows changing the name according to the FreshRSS language) * Rename `->bd` to `->pdo` (less of a frenshism, and more informative) * Fix some requests, which were not compatible with MySQL prepared statements * Whitespace * Fix syntax for PostgreSQL sequences + MySQL install * Minor formatting * Fix lastInsertId for PostgreSQL * Use PHP 5.6+ const Take advantage of https://github.com/FreshRSS/FreshRSS/pull/2527 https://www.php.net/manual/en/migration56.new-features.php * A bit of forgotten PHP 5.6 simplification for cURL * Forgotten $s * Mini fix custom user config https://github.com/FreshRSS/FreshRSS/pull/2490/files#r326290346 * More work on install.php but not finished * install.php working * More cleaning of PDO in install * Even more simplification Take advantage of PDO->exec() to run multiple statements * Disallow changing the name of the default category https://github.com/FreshRSS/FreshRSS/pull/2522#discussion_r326967724
2019-09-28Optimize dynamic favicon for HiDPI screens (#2539)Gravatar rocka
This PR leveraging `window.devicePixelRatio` to generate high resolution favicons for HiDPI screens.
2019-09-18API Reeder compatibility (#2526)Gravatar Alexandre Alapetite
https://github.com/FreshRSS/FreshRSS/issues/2513
2019-08-29tec: Ignore theme folders starting by xTheme- (#2511)Gravatar Marien Fressinaud
2019-08-22IE11 / Edge keyboard compatibility (#2507)Gravatar Alexandre Alapetite
https://github.com/FreshRSS/FreshRSS/pull/2506#issuecomment-523544684
2019-08-21Prevent window opener vulnerability with space shortcut (#2506)Gravatar ArthurHoaro
* Prevent window opener vulnerability with space shortcut This change fixes a vulnerability introduced by `window.open()` on untrusted sources. It reproduces the effect of `rel="noreferrer"` with JS. Cross browser solution from: https://stackoverflow.com/a/40593743 ## Reproduction > tested with Firefox 68 1. Add this RSS feed 2. Open the 2nd link "À propos de la faille de sécurité liée à target="_blank" **using the space key shortcut**. 3. Click on the first of three links "http://bookmarks.ecyseo.net" Current behaviour: the FreshRSS tab changes. Expected behaviour: no effect on FreshRSS * Test for popup blockers
2019-08-20Require PHP 5.5+ (#2495)Gravatar Alexandre Alapetite
* Require PHP 5.5+ https://github.com/FreshRSS/FreshRSS/issues/2469#issuecomment-522255093 I think it would be reasonable to require PHP 5.5+ for the core of FreshRSS after all. As Frenzie said, WordPress currently requires PHP 5.6.20+, and it is the most popular PHP application. We would loose about 20% of the PHP servers according to https://w3techs.com/technologies/details/pl-php/5/all but I expect this number to drop fast after the release of CentOS 8 (CentOS accounts for 17% of Linux servers https://w3techs.com/technologies/details/os-linux/all/all ). Distributions: * no impact on Ubuntu, Fedora, Alpine, OpenWRT, FreeBSD, OpenSuze, Mageia, as all active versions have PHP > 7 * no impact on OpenSuze, Synology, as all active versions have PHP > 5.5 * we drop Debian 8 Jessie (-2020) - we keep supporting Debian 9 Stretch (2017-06) - current is Debian 10 Buster * we drop Red Hat 7 (-2024) - we keep supporting RHEL 8 (2019-05) * we drop CentOS 7 (-2024) - we will support CentOS 8 (to be released soonish) When dropping older versions, I can better like when it is for a good reason, and there is actually one with PHP 5.5, namely generators (yield) https://php.net/language.generators.overview which I consider using. * Version note for JSON.php * hex2bin * Update .travis.yml Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
2019-08-14[CI] Run stylelint (#2477)Gravatar Frans de Jonge
* [CI] Run stylelint Perform some basic CSS sanity checking and style enforcement. I removed vendor prefixed linear-gradient and transform because those are from the IE9 era. With IE11 as a minimum and soon obsolete requirement it doesn't make much sense anymore. * Remove as-link override * Don't require newline after comment * Also apply those newline rules to SCSS * refine opening/closing braces, allow for single-line
2019-08-14Added option to display authors under article titles (#2487)Gravatar Joris Kinable
This feature is particularly useful to display authors underneath scientific articles.