aboutsummaryrefslogtreecommitdiff
path: root/p
AgeCommit message (Collapse)Author
2020-05-30Fix alert-warn background (#3015)Gravatar Alexandre Alapetite
Fix minor CSS regression from https://github.com/FreshRSS/FreshRSS/pull/2990
2020-05-25Fix JS show password in install (#2999)Gravatar Alexandre Alapetite
The button for showing the password was not working in the install. Updated JavaScript file to ES6 at the same time.
2020-05-25Alternative-Dark theme use common template (#3000)Gravatar Alexandre Alapetite
* Alternative-Dark theme use common template #fix https://github.com/FreshRSS/FreshRSS/issues/2883 * Lint
2020-05-22fix: Fix .stick class for older Webkit versions (#2995)Gravatar Marien Fressinaud
It looks like inputs had a light margin on older Webkit versions, making the inputs slightly smaller than buttons in a .stick container. Reference: https://github.com/FreshRSS/FreshRSS/pull/2938#issuecomment-632429861
2020-05-21Better hide spinner (#2990)Gravatar Alexandre Alapetite
Fix https://github.com/FreshRSS/FreshRSS/issues/2986#issuecomment-631396735 By CSS, and also by JS https://framagit.org/nicofrand/xextension-threepanesview/-/issues/10
2020-05-20Fix Dark load (#2987)Gravatar Alexandre Alapetite
#fix https://github.com/FreshRSS/FreshRSS/issues/2986 😈😛
2020-05-18Fix nav_menu mark-as-read (#2909)Gravatar Alexandre Alapetite
* Fix nav_menu mark-as-read #Fix https://github.com/FreshRSS/FreshRSS/issues/2905 Fix regression from https://github.com/FreshRSS/FreshRSS/pull/2588 We need info about the first item (id_max) before being able to output nav_menu. Before https://github.com/FreshRSS/FreshRSS/pull/2588 we used to output everything in memory before starting to produce an output. Now that we stream the output, we need a temporary buffer until we have received the first item/article. * Repair loading page * Simplify CSS Make it work in Chrome as well * Lint * Partial revert * Base max_id solely on current time
2020-05-17Stream instead of memory copy of SimplePie entries (#2972)Gravatar Alexandre Alapetite
* Stream instead of memory copy of SimplePie entries https://github.com/FreshRSS/FreshRSS/issues/2952 * Undo lines delete * Typo * Remove unaccessible code https://github.com/FreshRSS/FreshRSS/pull/2972/files#r425624163 * Back-compatibility for Feed->entries https://github.com/FreshRSS/FreshRSS/pull/2972/files#r425631913
2020-05-16jQuery 3.5.1 (#2982)Gravatar Alexandre Alapetite
Minor version https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/
2020-05-08Fix bad relogging clients (#2961)Gravatar Alexandre Alapetite
* Fix bad relogging clients Some clients (like EasyRSS) are still using the old HTTP Authorization header after having logged to log in with another user. We should not attempt to process Authorization headers during a login request * Typo * A bit safer Avoid null exception
2020-05-07API relaxed detection of short/long item ID forms (#2957)Gravatar Alexandre Alapetite
#Fix https://github.com/FreshRSS/FreshRSS/issues/2956 Bug/feature introduced by https://github.com/FreshRSS/FreshRSS/pull/2947 (which was following the specification better) The original code `strpos($e_id, '/') !== null` was wrong (it can never be null, only false or integer), but the idea was to check whether the client was sending a short form (decimal) or long form of the ID (hexadecimal with prefixes including slashes). Since it has not given problem until my recent typo fix, this means that the short form is apparently not used by the clients we tested. But now that we are back to following the specification better, it looks like a client such as Reeder 4 is sending an hexadecimal form without a prefix, which breaks the detection. This patch changes the detection, which should work in all known cases AND comply with the specification https://feedhq.readthedocs.io/en/latest/api/terminology.html#items
2020-05-06Add/mobile feed configuration (#2938)Gravatar Marien Fressinaud
* Show subscription management button on mobile * Show aside box-shadow on Origine only when opened * Reduce padding of Origine posts on mobile * Shrink stick component with long input * Show Origine configure icons on mobile * Show the slider full width on mobile * Improve the look of forms on mobile * Fix Ansum theme * Fix BlueLagoon theme * Fix Dark theme * Fix Flat theme * Fix Mapco theme * Fix Origine-compact theme * Fix Pafat theme * Fix Screwdriver theme * Fix Swage theme * Fix Alternative-Dark theme * Apply RTL script on themes Co-authored-by: triatic <42704418+triatic@users.noreply.github.com>
2020-05-05Fix warning with FeedReader (#2947)Gravatar Alexandre Alapetite
FeedReader 2.10.0 sends something like `T=cd3421a73e8a09f955449d02beaf9593b0c0265cZZZZZZZZZZZZZZZZZ&r=user/-/state/com.google/read&i=-/tag%3Agoogle.com&i=-/2005%3Areader/item/0005a4b97779db22` to `/api/greader.php/reader/api/0/edit-tag` The first `i=-/tag/google.com` is wrong and cannot be converted to an entry ID. This resulted in: > PHP Warning: gmp_init(): Unable to convert variable to GMP - string is not an integer in /var/www/FreshRSS/p/api/greader.php on line 35
2020-05-03Fever integer type for numbers (#2946)Gravatar Alexandre Alapetite
* Fever integer type for feed ID #Fix https://github.com/FreshRSS/FreshRSS/issues/2940#issuecomment-623022435 * Fix feed_id * Ensure string for entry ID To be compatible with 32-bit platforms. Before, the type was inconsistent depending on architecture + database * Integer for entry count functions
2020-05-02Fever integer type for last_refreshed_on_time (#2944)Gravatar Alexandre Alapetite
#Fix https://github.com/FreshRSS/FreshRSS/issues/2940 https://feedafever.com/api
2020-04-30API Use string type for Usec (#2935)Gravatar Alexandre Alapetite
#Fix https://github.com/FreshRSS/FreshRSS/issues/2934
2020-04-20Enhance the way help elements are displayed (#2911)Gravatar Julien-Pierre Avérous
* - Always display help under the targeted element. - Use same help place for HTTP authentication in 'add' feed view than in 'update' feed view. - Move help under input field in register view, as all other places (homogeneity). * - Don't use "!important" as suggested by @Alkarex.
2020-04-18Fix CSS Edge glitch in archiving options (#2906)Gravatar Alexandre Alapetite
With Edge, only setting `.hidden = true` does not make the element and sub-elements properly visible. Should not make any difference for other browser.
2020-04-16Expose podcast in API (#2898)Gravatar Alexandre Alapetite
* Expose podcast in API Expose RSS enclosures in our API, e.g. for clients supporting podcasts * PHP CS? * Annoying linter * Light optimisation
2020-04-12Fix JS for statistics repartition select form (#2896)Gravatar Alexandre Alapetite
* Fix JS for statistics repartition select form Error was: `s.form is null in extra.js:166:7` At the same time, disable the form and clears the value while waiting for the next page to load, to better understand what is happening. * Whitespace
2020-04-12jQuery 3.5.0 (#2895)Gravatar Alexandre Alapetite
https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/
2020-04-10Minor stylelint exception formatting change (#2889)Gravatar Frans de Jonge
Slightly tidier
2020-04-10Fix search input styling in Safari (#2887)Gravatar kinoushe
* Fix search input styling in Safari #fix https://github.com/FreshRSS/FreshRSS/issues/2885 Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-04-09Fix BlueLagoon and Screwdriver hover title (#2884)Gravatar Alexandre Alapetite
#fix https://github.com/FreshRSS/FreshRSS/issues/2755 Follow-up of https://github.com/FreshRSS/FreshRSS/pull/2882#issuecomment-611136775 https://stackoverflow.com/questions/2837057/what-has-bigger-priority-opacity-or-z-index-in-browsers
2020-04-08Fix CSS hover long title (#2882)Gravatar Alexandre Alapetite
* Fix CSS hover long title #fix https://github.com/FreshRSS/FreshRSS/issues/2755 * Fix Ansum * Fix Mapco
2020-04-08Swap shortcuts for mark all articles as read / mark previous articles as ↵Gravatar Alexandre Alapetite
read (#2881) * Swap shortcuts for mark all articles as read / mark previous articles as read #fix https://github.com/FreshRSS/FreshRSS/issues/2865 Follow-up of https://github.com/FreshRSS/FreshRSS/pull/2843 * <kbd>⇧ Shift</kbd>+<kbd>R</kbd> to mark all articles as read; * <kbd>Alt ⎇</kbd>+<kbd>r</kbd> to mark previous articles as read. * i18n
2020-04-04Full with for audio UI (#2877)Gravatar Alexandre Alapetite
#fix https://github.com/FreshRSS/FreshRSS/issues/2875
2020-04-01API return proper newestItemTimestampUsec (#2854)Gravatar Alexandre Alapetite
* API return proper newestItemTimestampUsec #fix https://github.com/FreshRSS/FreshRSS/issues/2853 * Minor naming * Add newestItemTimestampUsec for labels * Do not use t.name after all
2020-03-30Simplify CSS remove z-index (#2861)Gravatar Alexandre Alapetite
* Simplify CSS remove z-index #fix https://github.com/FreshRSS/FreshRSS/issues/2860 Improvement of https://github.com/FreshRSS/FreshRSS/pull/2845 https://github.com/FreshRSS/FreshRSS/commit/22916d6a3ed259b5a5dca5cddb4a58433729384f#r38143737 * Fix when .nav_menu is not loaded This ability was lost with the last styling iterations
2020-03-30API return OK for an empty request (#2855)Gravatar Alexandre Alapetite
Fix https://framateam.org/freshrss/pl/yozcezrnufno9eut3173d4wpry
2020-03-28GReader API consistent default category (#2840)Gravatar Alexandre Alapetite
* GReader API consistent default category #Fix https://github.com/FreshRSS/FreshRSS/issues/2839 * Also for subscription/list
2020-03-28Loader animation while waiting for first articles (#2845)Gravatar Alexandre Alapetite
* Loader animation while waiting for first articles Especially useful when a slow search is being performed. Thanks to one new flush at the right time, the left colum and top menu will be there, waiting for the articles to come. This avoids layout flashes (the left column used to take the full width while waiting for articles). For optimal use, this assumes that the deployment has a proper buffering configuration, such as in our official Docker image (also when using Træfik as a reverse proxy in front). Might not work just as well with other Apache or nginx setups. * Fix on mobile And simplified CSS * Properly hide the loader It was not possible to find a position where the loading animation would be always hidden after load, so change strategy to hide it automatically by CSS when the actual content has arrived
2020-03-25Update RTL CSS files (#2848)Gravatar Frans de Jonge
* Update RTL CSS files * Add RTL for Alternative-Dark, cf. https://github.com/FreshRSS/FreshRSS/pull/2811 * Update RTL for base/Origine * Also include a `*.rtl.rtl.css` deletion in `make rtl` to work around https://github.com/MohammadYounes/rtlcss/issues/64 * forgot to commit Makefile
2020-03-23Shortcut mark previous articles as read (#2843)Gravatar Alexandre Alapetite
* Shortcut mark previous articles as read Address part of https://github.com/FreshRSS/FreshRSS/issues/2836 The shortcut [shift]+[r] now marks previous articles as read; The previous action of marking all articles as read is now achieved by [alt]+[r] So this is a slight breaking change, but I like the logic of the upward-facing [shift] arrow to hint at previous articles, while [alt] is more like "all", at least to my eyes :-) * Update app/i18n/nl/conf.php Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com> * [⇧ Shift] / [Alt ⎇] With standard Unicode signs * <kbd> + CSS styling * Missing themes Tested with all themes * Travis CSS Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2020-03-23Reset scroll (#2842)Gravatar Alexandre Alapetite
Address some of https://github.com/FreshRSS/FreshRSS/issues/2836 This patch resets the scrollbar to the top when a FreshRSS page is initialised. Makes sure that when a FreshRSS page is restored in a Web browser session, we do not hit the problematic situation when the content is refreshed but the scrollbar moved back to where it was, potentially erroneously marking as read many as read, of landing on the wrong focus.
2020-03-22New core-extensions to allow Docker volumes for third-party extensions (#2837)Gravatar Alexandre Alapetite
* New core-extensions to allow Docker volumes for third-party extensions #Fix https://github.com/FreshRSS/FreshRSS/issues/2650 Split our extensions directory into two: 1) Core extensions shipped with FreshRSS in ./lib/core-extensions/ 2) Third-party extensions modified by end-users in ./extensions/ which can easily be mounted as a Docker volume * Example of Docker Compose with extensions * Back-compatibility + fix array merge bug
2020-03-21Alternative-Dark theme (#2811)Gravatar fabianski7
* Alternative-Dark theme * Update template.css * Update adark.css * Update adark.css * Update template.css * Updates and fixes * Remaining minor whitespace * Remaining minor Travis * order/properties-order Co-authored-by: Fabiano <defabiano@tutanota.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2020-03-08Improve login and registration pages (#2794)Gravatar Marien Fressinaud
* Keep the user on login page on failure * Show an error if username already exists * Check the password format in the backend * Return a better message if username is invalid * Add a title to the login page * wip: Improve look of login and register pages * Set a capital M in username help message On the registration page, username tip started with a minuscule, while the password tip started with a capital. * Change message if username is taken
2020-03-01[UI] Add RTL support with RTLCSS (#2776)Gravatar Frans de Jonge
* Add dir info to gen.php & install.php! * Add `make rtl` command Using rtlcss because it has actually has a command-line application!
2020-02-29GReader remove unsused parameter (#2816)Gravatar Alexandre Alapetite
2020-02-29Better performance with yield (#2588)Gravatar Alexandre Alapetite
* Better performance with yield Largely decrease the time to first byte, and reduced memory consumtion. Before, we used to make several copies in memory of the whole list of articles before sending them to the client. Now streamed as they are processed. * Travis
2020-02-29No pre for enclosure-description (#2808)Gravatar Alexandre Alapetite
* No pre for enclosure-description #fix https://github.com/FreshRSS/FreshRSS/issues/2807 In browsers, the styling `white-space:pre-line` will be applied by CSS, but no styling will be done for clients via API. * Corresponding CSS change
2020-02-13Enhance content path feature (#2778)Gravatar Julien-Pierre Avérous
- Add a maintenance section to be able to clear cache and force reload a feed. - Add an icon next to path field to show a pop-up with the result of the content path. Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: Marien Fressinaud <dev@marienfressinaud.fr>
2020-01-18[API, extension] Use 'dateAdded()' to forge 'crawlTimeMsec' & ↵Gravatar Julien-Pierre Avérous
'timestampUsec' field in greader API. (#2773) - Add the ability to customize 'dateAdded()', so an extension can change it if needed.
2020-01-17fix: #2701 Fix look of authors (#2771)Gravatar Marien Fressinaud
This fix makes the authors part of the "title item", so it's not considered as another block. This is not perfect since authors will disappear on small screens, but we can discuss of putting titles on multi-lines (see https://github.com/FreshRSS/FreshRSS/issues/2344)
2020-01-16Pass the entries to 'entry_before_display' extension hook (#2763)Gravatar Julien-Pierre Avérous
* Pass the entries to 'entry_before_display' extension hook. - #2762 * Fix code-style. * - Fix 'Whitespace found at end of line'. Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2020-01-05Fix loader display in Dark theme (#2753)Gravatar Alexis Degrugillier
Before, the default loader was used. It rendered poorly since it has a white border. Now, the theme loader is used.
2020-01-03Fix logging environment constants (#2745)Gravatar Alexandre Alapetite
* Fix logging environment constants * COPY_LOG_TO_SYSLOG was only working when Syslog was used * FRESHRSS_ENV was not properly used to set logging level * Simplify code Always call `openlog()` even when it is not used * Always specify syslog properties https://github.com/FreshRSS/FreshRSS/pull/2745#discussion_r362207445 * $username is also needed further down * No new line in syslog
2019-12-29fix: Fix undefined function _t on WebSub (#2743)Gravatar Marien Fressinaud
I published an article via WebSub, but I never received it. So I checked my logs to find why and I found the following stacktrace: ``` 29/Dec/2019:15:58:32 +0000 "POST /api/pshb.php" 500 NOTICE: PHP message: PHP Fatal error: Uncaught Error: Call to undefined function _t() in /path/app/Models/Category.php:83 Stack trace: /path/app/Models/CategoryDAO.php(417): FreshRSS_Category->_id(1) /path/app/Models/CategoryDAO.php(192): FreshRSS_CategoryDAO::daoToCategory(Array) /path/app/Models/Feed.php(466): FreshRSS_CategoryDAO->searchById('1') /path/app/Controllers/feedController.php(416): FreshRSS_Feed->cleanOldEntries() /path/p/api/pshb.php(141): FreshRSS_feed_Controller::actualizeFeed(0, 'https://flus.io...', false, Object(SimplePie)) {main} thrown in /path/app/Models/Category.php on line 83 ``` The `_t` function should be loaded with the Minz_Translate class, but the latter isn't initialized on WebSub endpoint. In my opinion, we should not have to care about this kind of detail of implementation and it reveals a deeper architectural misconception, but for now the fix should be enough. It’s quite difficult to reproduce locally though.
2019-12-28Fix labels dropdown not scrollable after a while (#2727)Gravatar romibi