aboutsummaryrefslogtreecommitdiff
path: root/p
AgeCommit message (Collapse)Author
2025-02-03Shortcuts for adding labels (#7274)Gravatar maTh
* add shortcut in config * open my labels menu with shortcut * the first 9 items are selectable + input field * i18n * Update app/i18n/nl/conf.php Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> * index.menu.mylabels * order fixed --------- Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2025-01-31Improve notification banner (#7268)Gravatar maTh
* a -> button * i18n: Close * a.close -> .close * themes * Apply suggestions from code review Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> * Update app/i18n/fr/gen.php --------- Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-01-21Improve stats page layout (#7243)Gravatar maTh
* New stats box layout * repartition: table overview improved with links and icons * Show selected feed name in title * i18n string: overview * fix * fix * fix * delete unused stat in frss * Update app/i18n/fr/admin.php --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-01-21fix global view unread articles counter (#7247)Gravatar maTh
2025-01-21Hide base theme (#7234)Gravatar Alexandre Alapetite
2025-01-21smaller "mark as read" button in mobile view (#5220)Gravatar maTh
* wip * fix
2025-01-12Remove local reference to fonts/OpenSans (#7215)Gravatar Alexandre Alapetite
2025-01-10New: About page with env information (#7161)Gravatar maTh
* infobox * i18n * CSS improved * themes * Update app/views/index/about.phtml Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Update app/views/index/about.phtml Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Environment information => System information * Issue templates: Env info -> System info * i18n: IT Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * i18n: DE * Update app/i18n/it/index.php Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * added: php_uname() * i18n: fr * Add database version --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
2025-01-10Reduce undeeded use of elvis operator ?: (#7204)Gravatar Alexandre Alapetite
2025-01-06Implement custom order-by (#7149)Gravatar Alexandre Alapetite
Add option to sort results by received date (existing, default), publication date, title, URL (link), random. fix https://github.com/FreshRSS/FreshRSS/issues/1771 fix https://github.com/FreshRSS/FreshRSS/issues/2083 fix https://github.com/FreshRSS/FreshRSS/issues/2119 fix https://github.com/FreshRSS/FreshRSS/issues/2596 fix https://github.com/FreshRSS/FreshRSS/issues/3204 fix https://github.com/FreshRSS/FreshRSS/issues/4405 fix https://github.com/FreshRSS/FreshRSS/issues/5529 fix https://github.com/FreshRSS/FreshRSS/issues/5864 fix https://github.com/FreshRSS/Extensions/issues/161 URL parameters: * `&sort=id` (current behaviour, sorting according to newest received articles) * `&sort=date` (publication date, which is not indicative of how new an article is) * `&sort=title` * `&sort=link` * `&sort=rand` (random order - which disables infinite scrolling, at least for now) combined with `&order=ASC` or `&order=DESC` ![image](https://github.com/user-attachments/assets/2de5aef1-604e-4a73-a147-569f6f42a1be) ## Implementation notes The sorting criteria by *received date* (id), which is the default, and which was the only one before this PR, is the one that has the best sorting characteristics: * *uniqueness*: no entries have the exact same received date * *monotonicity*: new entries always have a higher received date * *performance*: this field is efficiently indexed in database for fast usage, including for paging (indexing could also be done to other fields, but with lower effective performance) In contrary, sorting criteria such as by *publication date*, by *title*, or by *link* are neither unique nor monotonic. In particular, multiple articles may share the same *publication date*, and we may receive articles with a *publication date* far in the future, and then later some new articles with a *publication date* far in the past. To understand why sorting by *publication date* is problematic, it helps to think about sorting by *title* or by *link*, as sorting by *title* and by *publication date* share more or less the same characteristics. ### Problem 1: new articles New articles may be received in the background after what is shown on screen, and before the next user action such as *mark all as read*. Due to the lack of *monotonicity* when sorting by e.g. *publication date* or *title*, users risk marking as read a batch of articles containing some fresh articles without seeing them. Mitigation: A parameter `idMax` tracks the maximum ID related to a batch of actions such as *mark all as read* to exclude articles received after those that are displayed. ### Problem 2: paging / pagination When navigating articles, only a few articles are displayed, and a new "page" of articles needs to be received from the database when scrolling down or when clicking the button to show more articles. When sorting by e.g. *publication date* or *title*, it is not trivial to show the next page without re-showing some of the same articles, and without skipping any. Indeed, views are often with additional criteria such as showing only unread articles, and users may mark some articles as read while viewing them, hereby removing some articles from the previous pages. And like for *Problem 1*, new articles may have been received in the background. Consequently, it is not possible to use `OFFSET` to implement pagination (so the patches suggested by a few users were wrong due to that, in particular). Mitigation: `idMax` is also used (just like for *Problem 1*) and a *Keyset Pagination* approach is used, combining an unstable sorting criterion such as *publication date* or *title*, together with *id* to ensure stable sorting. (So, 2 sorting criteria + 1 filter criteria) See e.g. https://www.alwaysdeveloping.net/dailydrop/2022/07/01-keyset-pagination/ ### Problem 3: performance Sorting by anything else than *received date* (id) is doomed to be slow(er) due to the combination of 3 criteria (see *Problem 2*). An `OFFSET` approach (which is not possible anyway as explained) would be even slower. Furthermore, we have no SQL index at the moment, but they would not necessarily help much due to the multiple sorting criteria needed and involving some `OR` logic which is difficult to optimise for databases. The nicest syntax would be using tuples and corresponding indexes, but that is poorly supported by MySQL https://bugs.mysql.com/bug.php?id=104128 Mitigation: a compatibility SQL syntax is used to implement *Keyset Pagination* ### Problem 4: user confusion Several users have shown that they do not fully understand the difference between *received date* and *publication date*, and particularly not the pitfalls of *publication date*. Mitigation: the menus to mark-as-read *before 1 day* and *before 1 week* are disabled when sorting by anything else than *received date*. Likewise, the separation headers *Today* and *Yesterday* and *Before yesterday* are only shown when sorting by *received date*. Again here, to better understand why, it helps to think about sorting by *title* or by *link*, as sorting by *title* and by *publication date* share more or less the same characteristics. * [ ] We should write a Q&A and/or documentation about the problems associated to *sorting by publication date*: risks of not noticing new publication, of inadvertently marking them as read, of having some articles with a date in the future hanging at the top of the views (vice versa when sorting in ascending order), performance, etc. ### Problem 5: APIs Sorting by anything else than *received date* breaks the guarantees needed for a successful synchronisation via API. Mitigation: sorting by *received date* is ensured for all API calls.
2024-12-29Fix access to manifest (#7158)Gravatar Alexandre Alapetite
* Fix access to manifest fix https://github.com/FreshRSS/FreshRSS/issues/7157 * Casing
2024-12-28Fix regressions on some array structures (#7155)Gravatar Alexandre Alapetite
regressions from https://github.com/FreshRSS/FreshRSS/pull/7131 fix https://github.com/FreshRSS/FreshRSS/issues/7154
2024-12-27Hint .htaccess (#7153)Gravatar Alexandre Alapetite
https://github.com/FreshRSS/FreshRSS/discussions/7145
2024-12-27PHPStan 2.0 (#7131)Gravatar Alexandre Alapetite
* PHPStan 2.0 fix https://github.com/FreshRSS/FreshRSS/issues/6989 https://github.com/phpstan/phpstan/releases/tag/2.0.0 https://github.com/phpstan/phpstan/blob/2.0.x/UPGRADING.md * More * More * Done * fix i18n CLI * Restore a PHPStan Next test For work towards PHPStan Level 10 * 4 more on Level 10 * fix getTagsForEntry * API at Level 10 * More Level 10 * Finish Minz at Level 10 * Finish CLI at Level 10 * Finish Controllers at Level 10 * More Level 10 * More * Pass bleedingEdge * Clean PHPStan options and add TODOs * Level 10 for main config * More * Consitency array vs. list * Sanitize themes get_infos * Simplify TagDAO->getTagsForEntries() * Finish reportAnyTypeWideningInVarTag * Prepare checkBenevolentUnionTypes and checkImplicitMixed * Fixes * Refix * Another fix * Casing of __METHOD__ constant
2024-12-27Search in all feeds (#7144)Gravatar Alexandre Alapetite
* Search in all feeds Search in PRIORITY_ARCHIVED with `&get=A` fix https://github.com/FreshRSS/FreshRSS/discussions/7143 * Fix type * Search in PRIORITY_ARCHIVED with `&get=Z` * More * Fixes * One more fix * Extra features in user queries * Move i18n key * Fix overview * Enlarge query boxes * Revert i18n spelling * i18n: it Thanks @UserRoot-Luca Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> --------- Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
2024-12-26new: reader view: footer has manage icons (#7133)Gravatar maTh
* add footer * rename content thin medium large class * rework css * footer improved
2024-12-18fix: sharing menu entry id (#7113)Gravatar maTh
* fix sharing menu entry id * Update main.js
2024-12-11Always prevent default regardless of window.open() return status (#7089)Gravatar Frans de Jonge
* Always prevent default regardless of window.open() return status Fixes regression noted in https://github.com/FreshRSS/FreshRSS/pull/7077#discussion_r1879016226 * Update p/scripts/main.js Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-12-08windows.open noopener (#7077)Gravatar Alexandre Alapetite
fix https://github.com/FreshRSS/FreshRSS/issues/6862 Rework https://github.com/FreshRSS/FreshRSS/pull/2506
2024-12-07improve(GReader): update doc URLs; add TODO (#7074)Gravatar Brandon Jones
* improve(GReader): update doc URLs; add TODO * Link update --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-12-07Optimize code: (#6983)Gravatar Luc SANCHEZ
before count(...)' is used in a loop and is a low performing construction. after Foreach instead (easier to read and support) Co-authored-by: LucS <l.sanchez-prestataire@alptis.fr>
2024-12-05Revert "Implement showing and hiding header depending on scroll (#7029)" (#7064)Gravatar Alexandre Alapetite
This reverts commit be9b6c7290dddcd8b8b6a8926bd101b7123528b3. https://github.com/FreshRSS/FreshRSS/pull/7029
2024-12-05API support edit multiple tags (#7060)Gravatar Alexandre Alapetite
* API support edit multiple tags fix https://github.com/FreshRSS/FreshRSS/issues/7057 * Doc typo
2024-12-04Implement showing and hiding header depending on scroll (#7029)Gravatar Frans de Jonge
* Implement showing and hiding header depending on scroll References #7011. * header.phtml: adjust indentation * minor efficiency improvement * Update p/scripts/main.js Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-12-04Fix initial scroll for some browsers (#7059)Gravatar aarnej
For some browsers (I tested desktop Edge and mobile Safari), setting document.scrollingElement.scrollTop to zero does not seem to be enough to reset the scroll position at start. Setting history.scrollRestoration = 'manual' seems to fix it for these browsers. Firefox seems to work without this fix but works also with it.
2024-11-30article footer small display (#7031)Gravatar maTh
2024-11-29API return all categories also without any feed (#7020)Gravatar Alexandre Alapetite
https://github.com/FreshRSS/FreshRSS/issues/7013#issuecomment-2495281874
2024-11-28Fix API use rawurldecode (#7033)Gravatar Alexandre Alapetite
Labels or categories containing a `+` were failing. And avoid returning everything if the label/category filter is not found. Compatibility with FocusReader
2024-11-28Upgrade code to php 8.1 (#6748)Gravatar Luc SANCHEZ
* revert Fix code indentation Fix code Upgrade code to php 8.1 * fix remarques * code review * code review * code review * Apply suggestions from code review * code review * Fixes * Many remainging updates of array syntax * Lost case 'reading-list' * Uneeded PHPDoc --------- Co-authored-by: Luc Sanchez <l.sanchez-prestataire@alptis.fr> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-11-26Async XHR for login form (#7023)Gravatar Alexandre Alapetite
Fix https://github.com/FreshRSS/FreshRSS/issues/7019
2024-11-23Fix API add category to multiple feeds (#7017)Gravatar Alexandre Alapetite
* Fix API add category to multiple feeds fix https://github.com/FreshRSS/FreshRSS/issues/7013 * Fix PHPDoc variable * Remove unused variable
2024-11-19Rework Apache deny access outside p (#7008)Gravatar Alexandre Alapetite
* Rework Apache deny access outside p The deny rules introduced by https://github.com/FreshRSS/FreshRSS/pull/6881 gave problems for API access. See also https://github.com/FreshRSS/FreshRSS/discussions/6879 * Fix scope of deny logic * Fix scope of deny logic * Allow .txt For e.g. `robots.txt`
2024-11-15New: Label menu in article row (#6984)Gravatar maTh
* configs * add the icon in the entry header line * rename comment * Update main.js * CSS * comment typo fix * fix gloabl view my labels menu * improved: my labels dropdown with triangle now. yay!
2024-11-13[Feature] 6975: Redirect to shortcut page on pressing '?' (#6981)Gravatar Olexandr Shaposhnyk
* [Feature] 6975: Redirect to shortcut page on pressing '?' * [Feature] 6975: Redirect to shortcut page on pressing '?' * Simplify code * Re-order for performance * Remove shift key --------- Co-authored-by: Olexandr Shaposhnyk <oshaposhnyk@intelliboard.net> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-11-01Fixed: article footer dropdowns (my labels, article tags, sharing) (#6959)Gravatar maTh
* fix dropdown triangle in mobile view * Nord theme * mobile view: width improved. Each theme can decide about border-radius * Ansum/Mapco theme * fix pink dark theme: label icon in pink now too * my labels: line breaks improved * article tags: headline added
2024-10-27Fix: (#6945) reading view: show subscr. mgm button (#6946)Gravatar maTh
* show subsc. mgm button in reading view * styling improved
2024-10-18JavaScript form validation compatibility older browsers (#6777)Gravatar Alexandre Alapetite
Restore compatibility with older browsers (e.g. Firefox and Chrome older than 2020) and simplify code at the same time https://developer.mozilla.org/en-US/docs/Web/API/SubmitEvent/submitter Contributes to https://github.com/FreshRSS/FreshRSS/issues/6776 Was introduced by https://github.com/FreshRSS/FreshRSS/pull/4370 (to be retested a bit more, though)
2024-10-17Use HTML5 hidden (#6910)Gravatar Alexandre Alapetite
https://html.spec.whatwg.org/multipage/interaction.html#the-hidden-attribute Remove remains of `aria-hidden` mostly not used anymore in our logic. fix https://github.com/FreshRSS/FreshRSS/issues/6909
2024-10-14New unicity policies for feeds with bad GUIDs (#4487)Gravatar Alexandre Alapetite
New set of unicity criteria options. New tolerance heuristic: > `$invalidGuidsTolerance` (default 0.05) The maximum ratio (rounded) of invalid GUIDs to tolerate before degrading the unicity criteria. > Example for 0.05 (5% rounded): tolerate 0 invalid GUIDs for up to 9 articles, 1 for 10, 2 for 30, 3 for 50, 4 for 70, 5 for 90, 6 for 110, etc. > The default value of 5% rounded was chosen to allow 1 invalid GUID for feeds of 10 articles, which is a frequently observed amount of articles.
2024-10-13Apache allow OIDC (#6893)Gravatar Alexandre Alapetite
fix https://github.com/FreshRSS/FreshRSS/issues/6890 Fix regression from https://github.com/FreshRSS/FreshRSS/pull/6881
2024-10-13New feed mode: HTML + XPath + JSON dot notation (JSON in HTML) (#6888)Gravatar Alexandre Alapetite
* New feed mode: HTML + XPath + JSON dot notation (JSON in HTML) Same as `JSON+DotNotation` but first extracting the JSON string from an HTML document thanks to an XPath expression. Example: `//script[@type='application/json']` fix https://github.com/FreshRSS/FreshRSS/discussions/6876 * JavaScript UI to show/hide new field * Casing xPathToJson * Slight renaming
2024-10-11Apache protect more non-public folders and files (#6881)Gravatar Alexandre Alapetite
* Apache protect more non-public folders * Also protect root * Do the same for /p/ * Simplify Require all denied In case of Apache 2.2, it will just make an error 500 instead of 403 * .htaccess.dist * Simplify * Better comment
2024-10-05refactor labels article menu (#6864)Gravatar maTh
* refactor labels menu with template * reduce network traffic
2024-10-02Allow dynamic search operator in user queries (#6851)Gravatar Alexandre Alapetite
* Allow dynamic search operator in user queries fix https://github.com/FreshRSS/FreshRSS/issues/6849 * Other approach
2024-10-01fix regression user query page (#6859)Gravatar maTh
2024-10-01improved: 'My Labels' field be searchable (#6753)Gravatar maTh
* datalist-labels * Update main.js
2024-09-29Improved: Subscription management page (#6816)Gravatar maTh
* i18n: Add an RSS feed -> Add a feed * manage mouse title for category * no white space between manage icon and favicon and title * add feed link: use icon instead of plus character * better CSS class for empty category and its alert text box * show muted icon and warning icon * the CSS magic incl. the themes improvements * fix * mute icon is more important than warning * feed mouse hover title * fix feed navigation sidebar: show error * fix btn with icon and text * fix aside feed: muted icon over warning icon
2024-09-22Refactored: JavaScript template (#6826)Gravatar maTh
2024-09-22Fix: (#6815) share menu shortcut (#6825)Gravatar maTh
* function show_share_menu(el) * scroll list if share button is not visible * refactor
2024-09-20SimplePie support for HTTP cache policies (#6812)Gravatar Alexandre Alapetite
* SimplePie support for HTTP cache policies Discussion in https://github.com/FreshRSS/simplepie/pull/26 * Bump SimplePie commit * Typos * Typos * Simpler logic * Explicitly disable cache for non-GET flows * Bump SimplePie commit * Bump SimplePie commit * Bump SimplePie commit * Bump SimplePie commit
generated by cgit v1.2.3 (git 2.39.1) at 2026-02-24 03:37:39 +0000