aboutsummaryrefslogtreecommitdiff
path: root/p
AgeCommit message (Collapse)Author
2025-05-31Fix user self-deletion (#7626)Gravatar Inverle
* Fix user self-deletion * Minor code cleanup
2025-05-31API fix default category (#7610)Gravatar Alexandre Alapetite
fix https://github.com/FreshRSS/FreshRSS/issues/7368
2025-05-10Implement loading spinner for marking as favorite/read, read/unread (#7564)Gravatar Inverle
* Implement loading spinner for marking as favorite * Ensure that the correct previous icon gets set * Remove delay * Improve compatibility with various parsers Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Support multiple icons (top, bottom) * Remove preload for now * Fix CSS, remove !important * Implement read/unread and alt * Ensure correct bookmark icon gets set after error --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-05-09Fix favicon hashing in GReader API (#7573)Gravatar CarelessCaution
* Fix favicon hashing in GReader API (#7570) This allows the correct iconUrl to be returned from the GReader API for a given feed. * Fix method signature * Fix Fever API --------- Co-authored-by: CarelessCaution <189675655+CarelessCaution@users.noreply.github.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-05-07Remove Apache 2.2 (only support Apache 2.4+) (#7561)Gravatar Alexandre Alapetite
Follow-up of https://github.com/FreshRSS/FreshRSS/pull/7552 I cannot find any distribution still supporting Apache 2.2
2025-05-07HTTP Cache-Control immutable (#7552)Gravatar Alexandre Alapetite
Start using `Cache-Control: immutable` for some resources served with a timestamp. https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Cache-Control#immutable The `<If>` directive requires Apache 2.4+
2025-05-02Fix file serving for symlinked extensions (#7545)Gravatar Inverle
* Fix file serving for symlinked extensions from ext.php * Don't resolve symlink when deleting extension * Minor syntax --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-04-27Themes fix CSS .as-link (#7526)Gravatar Alexandre Alapetite
* Themes fix CSS .as-link Add missing rules. fix https://github.com/FreshRSS/FreshRSS/pull/7489#issuecomment-2781146577 * More fixes
2025-04-08Fix regression ext.php (#7499)Gravatar Alexandre Alapetite
fix https://github.com/FreshRSS/FreshRSS/issues/7498 Regression from https://github.com/FreshRSS/FreshRSS/pull/7495
2025-04-07Secure serving of user files from extensions (#7495)Gravatar Alexandre Alapetite
* Secure serving of user files from extensions fix https://github.com/FreshRSS/FreshRSS/issues/4930 * More fixes * Typo
2025-04-05Use HTTP POST for logout (#7489)Gravatar Alexandre Alapetite
* Use HTTP POST for logout To avoid potential CSRF risks * Fixed button font issue * Minor whitespace
2025-04-05Add :focus style to .dropdown-menu .item (#7491)Gravatar Frans de Jonge
So you can see keyboard focus. In reply to <https://github.com/FreshRSS/FreshRSS/pull/7489#issuecomment-2774759046>.
2025-04-03fix regression mapco/ansum theme (#7490)Gravatar maTh
fix of https://github.com/FreshRSS/FreshRSS/pull/7489#discussion_r2023760515 Regression #7314
2025-04-01Fix ext.php: Restrict valid paths in ext.php for extensions (#7479)Gravatar Alexandre Alapetite
* Fix ext.php: Restrict valid paths in ext.php for extensions Rework https://github.com/FreshRSS/FreshRSS/pull/7474 * Fix wrong variable
2025-04-01Restrict valid paths in ext.php for extensions (#7474)Gravatar Alexandre Alapetite
* Restrict valid paths in ext.php for extensions * Disallow absolute paths as well
2025-04-01Partial revert Referrer-Policy (#7478)Gravatar Alexandre Alapetite
https://github.com/FreshRSS/FreshRSS/pull/6303#issuecomment-2768907702 Was already implemented conditionally https://github.com/FreshRSS/FreshRSS/pull/1198
2025-04-01Referrer-Policy: same-origin (#6303)Gravatar maTh
* Referrer-Policy: same-origin * same-origin for our own images --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-04-01Add CSP to favicons (#7471)Gravatar Alexandre Alapetite
E.g. for the case of SVGs
2025-03-25Update bcrypt.js from 2.4.4 to 3.0.2 (#7449)Gravatar Alexandre Alapetite
https://github.com/dcodeIO/bcrypt.js/releases/tag/v3.0.0 Can be updated to the latest version with: `curl -L https://unpkg.com/bcryptjs/umd/index.js > p/scripts/vendor/bcrypt.js`
2025-03-25JavaScript: new event to detect context loaded (#7452)Gravatar hkcomori
* Add JavaScript event: freshrss:globalContextLoaded * Update docs * Update docs: fix typo
2025-03-22Themes: .btn padding + small adjustments (#7168)Gravatar maTh
Closes https://github.com/FreshRSS/FreshRSS/issues/6262 Changes proposed in this pull request: - CSS: the search button was too big/not flexible enough for the height because of the padding How to test the feature manually: 1. browser configuration: change the default font size from (`16`pt mostly) to `15` or `14` 2. go to subscription management -> `Subscription tools` 3. there should be no scroll bar (because the left hand side navigation is short and the content right hand side is short too) Side effect: All buttons will be a bit smaller as before (because `px` -> `rem`) It should not be an issue at all
2025-03-22Fix API for labels with slash (#7437)Gravatar Alexandre Alapetite
fix https://github.com/FreshRSS/FreshRSS/issues/7435
2025-03-13Mark as read button: config for the size (#7314)Gravatar maTh
* settings * i18n: mark_read_button * big, small, none * fix * Fixes * make fix-all --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-03-13Add check for Apache mod_filter to ensure "AddOutputFilterByType" works. (#7419)Gravatar Dezponia
* Update .htaccess Add check for Apache mod_filter to ensure "AddOutputFilterByType" works. * Explicit enabling mod_filter in our Docker images --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-03-07improve origine theme (#7413)Gravatar maTh
* improve origine theme * .nav_menu .btn
2025-02-03Shortcuts for adding labels (#7274)Gravatar maTh
* add shortcut in config * open my labels menu with shortcut * the first 9 items are selectable + input field * i18n * Update app/i18n/nl/conf.php Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> * index.menu.mylabels * order fixed --------- Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
2025-01-31Improve notification banner (#7268)Gravatar maTh
* a -> button * i18n: Close * a.close -> .close * themes * Apply suggestions from code review Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> * Update app/i18n/fr/gen.php --------- Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-01-21Improve stats page layout (#7243)Gravatar maTh
* New stats box layout * repartition: table overview improved with links and icons * Show selected feed name in title * i18n string: overview * fix * fix * fix * delete unused stat in frss * Update app/i18n/fr/admin.php --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2025-01-21fix global view unread articles counter (#7247)Gravatar maTh
2025-01-21Hide base theme (#7234)Gravatar Alexandre Alapetite
2025-01-21smaller "mark as read" button in mobile view (#5220)Gravatar maTh
* wip * fix
2025-01-12Remove local reference to fonts/OpenSans (#7215)Gravatar Alexandre Alapetite
2025-01-10New: About page with env information (#7161)Gravatar maTh
* infobox * i18n * CSS improved * themes * Update app/views/index/about.phtml Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Update app/views/index/about.phtml Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Environment information => System information * Issue templates: Env info -> System info * i18n: IT Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * i18n: DE * Update app/i18n/it/index.php Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * added: php_uname() * i18n: fr * Add database version --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
2025-01-10Reduce undeeded use of elvis operator ?: (#7204)Gravatar Alexandre Alapetite
2025-01-06Implement custom order-by (#7149)Gravatar Alexandre Alapetite
Add option to sort results by received date (existing, default), publication date, title, URL (link), random. fix https://github.com/FreshRSS/FreshRSS/issues/1771 fix https://github.com/FreshRSS/FreshRSS/issues/2083 fix https://github.com/FreshRSS/FreshRSS/issues/2119 fix https://github.com/FreshRSS/FreshRSS/issues/2596 fix https://github.com/FreshRSS/FreshRSS/issues/3204 fix https://github.com/FreshRSS/FreshRSS/issues/4405 fix https://github.com/FreshRSS/FreshRSS/issues/5529 fix https://github.com/FreshRSS/FreshRSS/issues/5864 fix https://github.com/FreshRSS/Extensions/issues/161 URL parameters: * `&sort=id` (current behaviour, sorting according to newest received articles) * `&sort=date` (publication date, which is not indicative of how new an article is) * `&sort=title` * `&sort=link` * `&sort=rand` (random order - which disables infinite scrolling, at least for now) combined with `&order=ASC` or `&order=DESC` ![image](https://github.com/user-attachments/assets/2de5aef1-604e-4a73-a147-569f6f42a1be) ## Implementation notes The sorting criteria by *received date* (id), which is the default, and which was the only one before this PR, is the one that has the best sorting characteristics: * *uniqueness*: no entries have the exact same received date * *monotonicity*: new entries always have a higher received date * *performance*: this field is efficiently indexed in database for fast usage, including for paging (indexing could also be done to other fields, but with lower effective performance) In contrary, sorting criteria such as by *publication date*, by *title*, or by *link* are neither unique nor monotonic. In particular, multiple articles may share the same *publication date*, and we may receive articles with a *publication date* far in the future, and then later some new articles with a *publication date* far in the past. To understand why sorting by *publication date* is problematic, it helps to think about sorting by *title* or by *link*, as sorting by *title* and by *publication date* share more or less the same characteristics. ### Problem 1: new articles New articles may be received in the background after what is shown on screen, and before the next user action such as *mark all as read*. Due to the lack of *monotonicity* when sorting by e.g. *publication date* or *title*, users risk marking as read a batch of articles containing some fresh articles without seeing them. Mitigation: A parameter `idMax` tracks the maximum ID related to a batch of actions such as *mark all as read* to exclude articles received after those that are displayed. ### Problem 2: paging / pagination When navigating articles, only a few articles are displayed, and a new "page" of articles needs to be received from the database when scrolling down or when clicking the button to show more articles. When sorting by e.g. *publication date* or *title*, it is not trivial to show the next page without re-showing some of the same articles, and without skipping any. Indeed, views are often with additional criteria such as showing only unread articles, and users may mark some articles as read while viewing them, hereby removing some articles from the previous pages. And like for *Problem 1*, new articles may have been received in the background. Consequently, it is not possible to use `OFFSET` to implement pagination (so the patches suggested by a few users were wrong due to that, in particular). Mitigation: `idMax` is also used (just like for *Problem 1*) and a *Keyset Pagination* approach is used, combining an unstable sorting criterion such as *publication date* or *title*, together with *id* to ensure stable sorting. (So, 2 sorting criteria + 1 filter criteria) See e.g. https://www.alwaysdeveloping.net/dailydrop/2022/07/01-keyset-pagination/ ### Problem 3: performance Sorting by anything else than *received date* (id) is doomed to be slow(er) due to the combination of 3 criteria (see *Problem 2*). An `OFFSET` approach (which is not possible anyway as explained) would be even slower. Furthermore, we have no SQL index at the moment, but they would not necessarily help much due to the multiple sorting criteria needed and involving some `OR` logic which is difficult to optimise for databases. The nicest syntax would be using tuples and corresponding indexes, but that is poorly supported by MySQL https://bugs.mysql.com/bug.php?id=104128 Mitigation: a compatibility SQL syntax is used to implement *Keyset Pagination* ### Problem 4: user confusion Several users have shown that they do not fully understand the difference between *received date* and *publication date*, and particularly not the pitfalls of *publication date*. Mitigation: the menus to mark-as-read *before 1 day* and *before 1 week* are disabled when sorting by anything else than *received date*. Likewise, the separation headers *Today* and *Yesterday* and *Before yesterday* are only shown when sorting by *received date*. Again here, to better understand why, it helps to think about sorting by *title* or by *link*, as sorting by *title* and by *publication date* share more or less the same characteristics. * [ ] We should write a Q&A and/or documentation about the problems associated to *sorting by publication date*: risks of not noticing new publication, of inadvertently marking them as read, of having some articles with a date in the future hanging at the top of the views (vice versa when sorting in ascending order), performance, etc. ### Problem 5: APIs Sorting by anything else than *received date* breaks the guarantees needed for a successful synchronisation via API. Mitigation: sorting by *received date* is ensured for all API calls.
2024-12-29Fix access to manifest (#7158)Gravatar Alexandre Alapetite
* Fix access to manifest fix https://github.com/FreshRSS/FreshRSS/issues/7157 * Casing
2024-12-28Fix regressions on some array structures (#7155)Gravatar Alexandre Alapetite
regressions from https://github.com/FreshRSS/FreshRSS/pull/7131 fix https://github.com/FreshRSS/FreshRSS/issues/7154
2024-12-27Hint .htaccess (#7153)Gravatar Alexandre Alapetite
https://github.com/FreshRSS/FreshRSS/discussions/7145
2024-12-27PHPStan 2.0 (#7131)Gravatar Alexandre Alapetite
* PHPStan 2.0 fix https://github.com/FreshRSS/FreshRSS/issues/6989 https://github.com/phpstan/phpstan/releases/tag/2.0.0 https://github.com/phpstan/phpstan/blob/2.0.x/UPGRADING.md * More * More * Done * fix i18n CLI * Restore a PHPStan Next test For work towards PHPStan Level 10 * 4 more on Level 10 * fix getTagsForEntry * API at Level 10 * More Level 10 * Finish Minz at Level 10 * Finish CLI at Level 10 * Finish Controllers at Level 10 * More Level 10 * More * Pass bleedingEdge * Clean PHPStan options and add TODOs * Level 10 for main config * More * Consitency array vs. list * Sanitize themes get_infos * Simplify TagDAO->getTagsForEntries() * Finish reportAnyTypeWideningInVarTag * Prepare checkBenevolentUnionTypes and checkImplicitMixed * Fixes * Refix * Another fix * Casing of __METHOD__ constant
2024-12-27Search in all feeds (#7144)Gravatar Alexandre Alapetite
* Search in all feeds Search in PRIORITY_ARCHIVED with `&get=A` fix https://github.com/FreshRSS/FreshRSS/discussions/7143 * Fix type * Search in PRIORITY_ARCHIVED with `&get=Z` * More * Fixes * One more fix * Extra features in user queries * Move i18n key * Fix overview * Enlarge query boxes * Revert i18n spelling * i18n: it Thanks @UserRoot-Luca Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> --------- Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
2024-12-26new: reader view: footer has manage icons (#7133)Gravatar maTh
* add footer * rename content thin medium large class * rework css * footer improved
2024-12-18fix: sharing menu entry id (#7113)Gravatar maTh
* fix sharing menu entry id * Update main.js
2024-12-11Always prevent default regardless of window.open() return status (#7089)Gravatar Frans de Jonge
* Always prevent default regardless of window.open() return status Fixes regression noted in https://github.com/FreshRSS/FreshRSS/pull/7077#discussion_r1879016226 * Update p/scripts/main.js Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-12-08windows.open noopener (#7077)Gravatar Alexandre Alapetite
fix https://github.com/FreshRSS/FreshRSS/issues/6862 Rework https://github.com/FreshRSS/FreshRSS/pull/2506
2024-12-07improve(GReader): update doc URLs; add TODO (#7074)Gravatar Brandon Jones
* improve(GReader): update doc URLs; add TODO * Link update --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-12-07Optimize code: (#6983)Gravatar Luc SANCHEZ
before count(...)' is used in a loop and is a low performing construction. after Foreach instead (easier to read and support) Co-authored-by: LucS <l.sanchez-prestataire@alptis.fr>
2024-12-05Revert "Implement showing and hiding header depending on scroll (#7029)" (#7064)Gravatar Alexandre Alapetite
This reverts commit be9b6c7290dddcd8b8b6a8926bd101b7123528b3. https://github.com/FreshRSS/FreshRSS/pull/7029
2024-12-05API support edit multiple tags (#7060)Gravatar Alexandre Alapetite
* API support edit multiple tags fix https://github.com/FreshRSS/FreshRSS/issues/7057 * Doc typo
2024-12-04Implement showing and hiding header depending on scroll (#7029)Gravatar Frans de Jonge
* Implement showing and hiding header depending on scroll References #7011. * header.phtml: adjust indentation * minor efficiency improvement * Update p/scripts/main.js Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
2024-12-04Fix initial scroll for some browsers (#7059)Gravatar aarnej
For some browsers (I tested desktop Edge and mobile Safari), setting document.scrollingElement.scrollTop to zero does not seem to be enough to reset the scroll position at start. Setting history.scrollRestoration = 'manual' seems to fix it for these browsers. Firefox seems to work without this fix but works also with it.
generated by cgit v1.2.3 (git 2.39.1) at 2026-02-10 07:05:36 +0000