From 3ec0bdab3840feb7140d70d0eb8d60065337e33a Mon Sep 17 00:00:00 2001 From: Bryan Butler <3256910+BryanButlerGit@users.noreply.github.com> Date: Fri, 7 Mar 2025 15:29:27 -0700 Subject: Fix issue where $keepMax is defaulted to const when non-zero value is compared. (#7416) Fix issue where $keepMax is defaulted to const when non-zero value is compared. Fix an issue where $keepMax var is set to ARCHIVING_RETENTION_COUNT_LIMIT when a user sets "Archiving" -> "Maximum number of articles to keep per feed" to a non-zero value for a given category. [EXAMPLE]: User sets value to 50 (int), This matches the !== comparison and thus is overridden by ARCHIVING_RETENTION_COUNT_LIMIT. --- app/Controllers/categoryController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Controllers/categoryController.php b/app/Controllers/categoryController.php index 9fd5fd630..956a462e1 100644 --- a/app/Controllers/categoryController.php +++ b/app/Controllers/categoryController.php @@ -113,7 +113,7 @@ class FreshRSS_category_Controller extends FreshRSS_ActionController { } else { if (!Minz_Request::paramBoolean('enable_keep_max')) { $keepMax = false; - } elseif (($keepMax = Minz_Request::paramInt('keep_max')) !== 0) { + } elseif (($keepMax = Minz_Request::paramInt('keep_max')) === 0) { $keepMax = FreshRSS_Feed::ARCHIVING_RETENTION_COUNT_LIMIT; } if (Minz_Request::paramBoolean('enable_keep_period')) { -- cgit v1.2.3