From 5e66adcc51446fe93b2cba7c25e28a06d9903223 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Tue, 23 Apr 2024 10:59:09 +0200 Subject: Remove noise parameters in query URL (#6371) * Remove noise parameters in query URL Remove undeeded `name` and `rid` parameters from saved user query * Fix logic --- app/Controllers/configureController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'app/Controllers/configureController.php') diff --git a/app/Controllers/configureController.php b/app/Controllers/configureController.php index 4fd9a2f28..d766aa97d 100644 --- a/app/Controllers/configureController.php +++ b/app/Controllers/configureController.php @@ -374,7 +374,6 @@ class FreshRSS_configure_Controller extends FreshRSS_ActionController { if ('' === $name) { $name = _t('conf.query.number', $id + 1); } - $queryParams['name'] = $name; if (!empty($params['get']) && is_string($params['get'])) { $queryParams['get'] = htmlspecialchars_decode($params['get'], ENT_QUOTES); } @@ -399,6 +398,7 @@ class FreshRSS_configure_Controller extends FreshRSS_ActionController { $queryParams['shareOpml'] = (bool)$params['shareOpml']; } $queryParams['url'] = Minz_Url::display(['params' => $queryParams]); + $queryParams['name'] = $name; $queries = FreshRSS_Context::userConf()->queries; $queries[$id] = (new FreshRSS_UserQuery($queryParams, FreshRSS_Context::categories(), FreshRSS_Context::labels()))->toArray(); @@ -442,6 +442,7 @@ class FreshRSS_configure_Controller extends FreshRSS_ActionController { $queries[$key] = (new FreshRSS_UserQuery($query, FreshRSS_Context::categories(), FreshRSS_Context::labels()))->toArray(); } $params = $_GET; + unset($params['name']); unset($params['rid']); $params['url'] = Minz_Url::display(['params' => $params]); $params['name'] = _t('conf.query.number', count($queries) + 1); -- cgit v1.2.3