From 256dcc21bb222184d5e917ea57cec334b74b96f4 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 14 Oct 2024 09:34:16 +0200 Subject: New unicity policies for feeds with bad GUIDs (#4487) New set of unicity criteria options. New tolerance heuristic: > `$invalidGuidsTolerance` (default 0.05) The maximum ratio (rounded) of invalid GUIDs to tolerate before degrading the unicity criteria. > Example for 0.05 (5% rounded): tolerate 0 invalid GUIDs for up to 9 articles, 1 for 10, 2 for 30, 3 for 50, 4 for 70, 5 for 90, 6 for 110, etc. > The default value of 5% rounded was chosen to allow 1 invalid GUID for feeds of 10 articles, which is a frequently observed amount of articles. --- app/Controllers/feedController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'app/Controllers/feedController.php') diff --git a/app/Controllers/feedController.php b/app/Controllers/feedController.php index 2b757177c..26e3caa3c 100755 --- a/app/Controllers/feedController.php +++ b/app/Controllers/feedController.php @@ -716,7 +716,8 @@ class FreshRSS_feed_Controller extends FreshRSS_ActionController { } } } - if (!empty($feedProperties)) { + if (!empty($feedProperties) || $feedIsNew) { + $feedProperties['attributes'] = $feed->attributes(); $ok = $feedDAO->updateFeed($feed->id(), $feedProperties); if (!$ok && $feedIsNew) { //Cancel adding new feed in case of database error at first actualize -- cgit v1.2.3