From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- app/Controllers/feedController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'app/Controllers/feedController.php') diff --git a/app/Controllers/feedController.php b/app/Controllers/feedController.php index 018bdb382..c194baf95 100644 --- a/app/Controllers/feedController.php +++ b/app/Controllers/feedController.php @@ -30,8 +30,9 @@ class FreshRSS_feed_Controller extends FreshRSS_ActionController { /** * @param array $attributes * @throws FreshRSS_AlreadySubscribed_Exception - * @throws FreshRSS_FeedNotAdded_Exception + * @throws FreshRSS_BadUrl_Exception * @throws FreshRSS_Feed_Exception + * @throws FreshRSS_FeedNotAdded_Exception * @throws Minz_FileNotExistException */ public static function addFeed(string $url, string $title = '', int $cat_id = 0, string $new_cat_name = '', @@ -874,7 +875,6 @@ class FreshRSS_feed_Controller extends FreshRSS_ActionController { /** * @throws Minz_ConfigurationNamespaceException - * @throws JsonException * @throws Minz_PDOConnectionException */ public static function renameFeed(int $feed_id, string $feed_name): bool { -- cgit v1.2.3