From 3336631a846c2e34f55b2ecb76b46cd68228486f Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Tue, 1 Apr 2025 17:55:20 +0200 Subject: Catch extension exceptions in override (#7475) * Catch extension exceptions in override https://github.com/FreshRSS/Extensions/pull/300#issuecomment-2768578464 * Fix error message --- app/Controllers/extensionController.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'app/Controllers') diff --git a/app/Controllers/extensionController.php b/app/Controllers/extensionController.php index eb2c3f8d8..f08013e7d 100644 --- a/app/Controllers/extensionController.php +++ b/app/Controllers/extensionController.php @@ -131,7 +131,12 @@ class FreshRSS_extension_Controller extends FreshRSS_ActionController { FreshRSS_View::prependTitle($ext->getName() . ' · ' . _t('admin.extensions.title') . ' · '); $this->view->extension = $ext; - $this->view->extension->handleConfigureAction(); + try { + $this->view->extension->handleConfigureAction(); + } catch (Minz_Exception $e) { // @phpstan-ignore catch.neverThrown (Thrown by extensions) + Minz_Log::error('Error while configuring extension ' . $ext->getName() . ': ' . $e->getMessage()); + Minz_Request::bad(_t('feedback.extensions.enable.ko', $ext_name, _url('index', 'logs')), ['c' => 'extension', 'a' => 'index']); + } } /** -- cgit v1.2.3