From 6f23999c7b3de1a69fea4dea056aed2548c4a32d Mon Sep 17 00:00:00 2001 From: Prashant Tholia <65695939+prashanttholia@users.noreply.github.com> Date: Mon, 2 Nov 2020 16:33:16 +0530 Subject: Remember open categories (#3185) * feature(normal) - Remember opened categories in the left menu Session storage based implementation to remember opened categories in left menu Issue Ref: #2248 * lib_phpQuery updates * Updates covering feedback points and functionality fixes * Feedback updates * Revert "lib_phpQuery updates" This reverts commit dcd23b9418405a2d14ee03c1fcadf90c04b267e1. * First review Change variable name to "remember" instead of "open". Start using localStorage instead of sessionStorage. Simplify code. * Simplify remember categories init function Replace 'session' with 'local' in function names and comment Set open categories CSS as same as when category is opened in 'active' unfold mode * Remove URLSearchParams check in remember categories init function * Delete open categories on login and logout * JSHint check fix * Second review * Make new mode the default for new users * Always open active category * Reduce / simplify code * i18n French * Revert default value Wait a bit more for this decision / change Co-authored-by: Alexandre Alapetite --- app/Models/ConfigurationSetter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/Models/ConfigurationSetter.php') diff --git a/app/Models/ConfigurationSetter.php b/app/Models/ConfigurationSetter.php index 1d4b7f667..2a5f59226 100644 --- a/app/Models/ConfigurationSetter.php +++ b/app/Models/ConfigurationSetter.php @@ -183,7 +183,7 @@ class FreshRSS_ConfigurationSetter { } private function _display_categories(&$data, $value) { - if (!in_array($value, [ 'active', 'all', 'none' ], true)) { + if (!in_array($value, [ 'active', 'remember', 'all', 'none' ], true)) { $value = $value === true ? 'all' : 'active'; } $data['display_categories'] = $value; -- cgit v1.2.3