From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- app/Models/Context.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'app/Models/Context.php') diff --git a/app/Models/Context.php b/app/Models/Context.php index bb6fa4cbd..2d22290bc 100644 --- a/app/Models/Context.php +++ b/app/Models/Context.php @@ -75,6 +75,9 @@ final class FreshRSS_Context { } } + /** + * @throws FreshRSS_Context_Exception + */ public static function &systemConf(): FreshRSS_SystemConfiguration { if (FreshRSS_Context::$system_conf === null) { throw new FreshRSS_Context_Exception('System configuration not initialised!'); @@ -88,7 +91,6 @@ final class FreshRSS_Context { /** * Initialize the context for the current user. - * @throws Minz_ConfigurationParamException */ public static function initUser(string $username = '', bool $userMustExist = true): void { FreshRSS_Context::$user_conf = null; @@ -153,6 +155,9 @@ final class FreshRSS_Context { } } + /** + * @throws FreshRSS_Context_Exception + */ public static function &userConf(): FreshRSS_UserConfiguration { if (FreshRSS_Context::$user_conf === null) { throw new FreshRSS_Context_Exception('User configuration not initialised!'); -- cgit v1.2.3