From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- app/Models/Entry.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'app/Models/Entry.php') diff --git a/app/Models/Entry.php b/app/Models/Entry.php index 16f01483a..d3cfa07de 100644 --- a/app/Models/Entry.php +++ b/app/Models/Entry.php @@ -691,6 +691,7 @@ HTML; /** * @param array $attributes + * @throws Minz_Exception */ public static function getContentByParsing(string $url, string $path, array $attributes = [], int $maxRedirs = 3): string { $cachePath = FreshRSS_Feed::cacheFilename($url, $attributes, FreshRSS_Feed::KIND_HTML_XPATH); @@ -741,7 +742,7 @@ HTML; $html = trim(sanitizeHTML($content, $base)); return $html; } else { - throw new Exception(); + throw new Minz_Exception(); } } -- cgit v1.2.3