From 1335a0e3cf11a0d4248e9eaaf748b89e6df741ef Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Tue, 4 Jan 2022 13:59:09 +0100 Subject: PHPStan level 5 (#4110) * Fix most PHPDocs errors Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 https://phpstan.org/writing-php-code/phpdoc-types * Avoid func_get_args Use variadic syntax instead https://php.net/manual/functions.arguments#functions.variable-arg-list And avoid dynamic functions names when possible to more easily identify calls and unused functions. Contributes to https://github.com/FreshRSS/FreshRSS/issues/4103 * PHPStan level 3 * PHPStand level 4 * Update default to PHPStan level 4 * Towards level 5 * Fix level 4 regression * Towards level 5 * Pass PHPStan level 5 * Towards level 6 * Remove erronenous regression from changelog https://github.com/FreshRSS/FreshRSS/pull/4116 --- app/Models/StatsDAO.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'app/Models/StatsDAO.php') diff --git a/app/Models/StatsDAO.php b/app/Models/StatsDAO.php index 33e5426b5..612fe5cab 100644 --- a/app/Models/StatsDAO.php +++ b/app/Models/StatsDAO.php @@ -133,7 +133,7 @@ SQL; * * @param string $period format string to use for grouping * @param integer $feed id - * @return array + * @return array */ protected function calculateEntryRepartitionPerFeedPerPeriod($period, $feed = null) { $restrict = ''; @@ -178,7 +178,7 @@ SQL; * Calculates the average number of article per hour per feed * * @param integer $feed id - * @return integer + * @return float */ public function calculateEntryAveragePerFeedPerHour($feed = null) { return $this->calculateEntryAveragePerFeedPerPeriod(1 / 24, $feed); @@ -188,7 +188,7 @@ SQL; * Calculates the average number of article per day of week per feed * * @param integer $feed id - * @return integer + * @return float */ public function calculateEntryAveragePerFeedPerDayOfWeek($feed = null) { return $this->calculateEntryAveragePerFeedPerPeriod(7, $feed); @@ -198,7 +198,7 @@ SQL; * Calculates the average number of article per month per feed * * @param integer $feed id - * @return integer + * @return float */ public function calculateEntryAveragePerFeedPerMonth($feed = null) { return $this->calculateEntryAveragePerFeedPerPeriod(30, $feed); @@ -209,7 +209,7 @@ SQL; * * @param float $period number used to divide the number of day in the period * @param integer $feed id - * @return integer + * @return float */ protected function calculateEntryAveragePerFeedPerPeriod($period, $feed = null) { $restrict = ''; @@ -337,7 +337,7 @@ SQL; /** * Gets days ready for graphs * - * @return string + * @return array */ public function getDays() { return $this->convertToTranslatedJson(array( @@ -354,7 +354,7 @@ SQL; /** * Gets months ready for graphs * - * @return string + * @return array */ public function getMonths() { return $this->convertToTranslatedJson(array( @@ -377,7 +377,7 @@ SQL; * Translates array content * * @param array $data - * @return array + * @return array */ private function convertToTranslatedJson($data = array()) { $translated = array_map(function($a) { -- cgit v1.2.3