From b1d24fbdb7d1cc948c946295035dad6df550fb7e Mon Sep 17 00:00:00 2001
From: Alexandre Alapetite <alexandre@alapetite.fr>
Date: Fri, 27 Dec 2024 12:12:49 +0100
Subject: PHPStan 2.0 (#7131)

* PHPStan 2.0
fix https://github.com/FreshRSS/FreshRSS/issues/6989
https://github.com/phpstan/phpstan/releases/tag/2.0.0
https://github.com/phpstan/phpstan/blob/2.0.x/UPGRADING.md

* More

* More

* Done

* fix i18n CLI

* Restore a PHPStan Next test
For work towards PHPStan Level 10

* 4 more on Level 10

* fix getTagsForEntry

* API at Level 10

* More Level 10

* Finish Minz at Level 10

* Finish CLI at Level 10

* Finish Controllers at Level 10

* More Level 10

* More

* Pass bleedingEdge

* Clean PHPStan options and add TODOs

* Level 10 for main config

* More

* Consitency array vs. list

* Sanitize themes get_infos

* Simplify TagDAO->getTagsForEntries()

* Finish reportAnyTypeWideningInVarTag

* Prepare checkBenevolentUnionTypes and checkImplicitMixed

* Fixes

* Refix

* Another fix

* Casing of __METHOD__ constant
---
 app/Models/UserDAO.php | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

(limited to 'app/Models/UserDAO.php')

diff --git a/app/Models/UserDAO.php b/app/Models/UserDAO.php
index 5ae57dd65..4cbfa7412 100644
--- a/app/Models/UserDAO.php
+++ b/app/Models/UserDAO.php
@@ -8,6 +8,9 @@ class FreshRSS_UserDAO extends Minz_ModelPdo {
 
 		try {
 			$sql = $GLOBALS['SQL_CREATE_TABLES'];
+			if (!is_string($sql)) {
+				throw new Exception('SQL_CREATE_TABLES is not a string!');
+			}
 			$ok = $this->pdo->exec($sql) !== false;	//Note: Only exec() can take multiple statements safely.
 		} catch (Exception $e) {
 			$ok = false;
@@ -29,7 +32,11 @@ class FreshRSS_UserDAO extends Minz_ModelPdo {
 		}
 
 		require(APP_PATH . '/SQL/install.sql.' . $this->pdo->dbType() . '.php');
-		$ok = $this->pdo->exec($GLOBALS['SQL_DROP_TABLES']) !== false;
+		$sql = $GLOBALS['SQL_DROP_TABLES'];
+		if (!is_string($sql)) {
+			throw new Exception('SQL_DROP_TABLES is not a string!');
+		}
+		$ok = $this->pdo->exec($sql) !== false;
 
 		if ($ok) {
 			$this->close();
-- 
cgit v1.2.3