From 314077a457f04cc2f0472e036af029e2676fbf02 Mon Sep 17 00:00:00 2001 From: Alexandre Alapetite Date: Mon, 15 Jan 2024 10:36:30 +0100 Subject: PHPStan prepare exceptions (#6037) Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: https://github.com/FreshRSS/FreshRSS/pull/5504 Preparation needed before new PRs of the same type: https://github.com/FreshRSS/FreshRSS/pull/5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block. --- app/Models/UserQuery.php | 6 ------ 1 file changed, 6 deletions(-) (limited to 'app/Models/UserQuery.php') diff --git a/app/Models/UserQuery.php b/app/Models/UserQuery.php index 85df49f1c..000cfbbdd 100644 --- a/app/Models/UserQuery.php +++ b/app/Models/UserQuery.php @@ -109,8 +109,6 @@ class FreshRSS_UserQuery { /** * Parse the query string when it is a "category" query - * - * @throws FreshRSS_DAO_Exception */ private function parseCategory(int $id): void { if ($this->category_dao === null) { @@ -127,8 +125,6 @@ class FreshRSS_UserQuery { /** * Parse the query string when it is a "feed" query - * - * @throws FreshRSS_DAO_Exception */ private function parseFeed(int $id): void { if ($this->feed_dao === null) { @@ -145,8 +141,6 @@ class FreshRSS_UserQuery { /** * Parse the query string when it is a "tag" query - * - * @throws FreshRSS_DAO_Exception */ private function parseTag(int $id): void { if ($this->tag_dao === null) { -- cgit v1.2.3