From d23d10bcde1a9b86c784d58b891f61e740e0124e Mon Sep 17 00:00:00 2001 From: Luc SANCHEZ <4697568+ColonelMoutarde@users.noreply.github.com> Date: Fri, 7 Apr 2023 12:32:10 +0200 Subject: Phpstan Level6 for View.php (#5269) * Remarque's from Alkarex * indentation * indentation * Apply suggestions from code review Co-authored-by: Alexandre Alapetite * Remarque's from Alkarex * A few improvements * Remarque's from Alkarex * Remarque's from Alkarex * Remarque's from Alkarex * Remarque's from Alkarex * Fixes and improvments * Fix getTagsForEntry --------- Co-authored-by: Luc Co-authored-by: Alexandre Alapetite --- app/Services/ExportService.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'app/Services/ExportService.php') diff --git a/app/Services/ExportService.php b/app/Services/ExportService.php index 697e091e7..949556700 100644 --- a/app/Services/ExportService.php +++ b/app/Services/ExportService.php @@ -75,9 +75,7 @@ class FreshRSS_Export_Service { $view->list_title = _t('sub.import_export.starred_list'); $view->type = 'starred'; - $entriesId = $this->entry_dao->listIdsWhere( - $type, 0, FreshRSS_Entry::STATE_ALL, 'ASC', -1 - ); + $entriesId = $this->entry_dao->listIdsWhere($type, 0, FreshRSS_Entry::STATE_ALL, 'ASC', -1) ?: []; $view->entryIdsTagNames = $this->tag_dao->getEntryIdsTagNames($entriesId); // The following is a streamable query, i.e. must be last $view->entries = $this->entry_dao->listWhere( @@ -115,7 +113,7 @@ class FreshRSS_Export_Service { $view->type = 'feed/' . $feed->id(); $entriesId = $this->entry_dao->listIdsWhere( 'f', $feed->id(), FreshRSS_Entry::STATE_ALL, 'ASC', $max_number_entries - ); + ) ?: []; $view->entryIdsTagNames = $this->tag_dao->getEntryIdsTagNames($entriesId); // The following is a streamable query, i.e. must be last $view->entries = $this->entry_dao->listWhere( -- cgit v1.2.3